From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C143CCA1D for ; Mon, 9 Mar 2026 17:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773078869; cv=none; b=KYlyBpPQXzp28jN1T3Mp+zh7q/n21+10IDi2oogPY2Mp9LZ+hKe2BSnB7PUgsEL3voCzTbEXGmjUTsuR+V2jPJk887HxVuDz3fGbAQeuyU6f6TrgZ9R8Cx0EIstmIVtZccydMQ4xzY6r/EaAqbmK5BjFWrwYSu9Gz4JzIbTX2NY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773078869; c=relaxed/simple; bh=sX8cJ2n5diYdt9m+igTcurQ2Jggi3oVt+b9O4254BA8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mUN48mmPHhqf45YtA1k9/5gTqr9v+YIapkrCxSEFAX4og2fgk1NlsopJyAT55gXwT7DSgcVRKn3O5JQsEm0VJs6Rh4V0Pe9+q0K4Vzs8Us+Wk/ZH0E6bpzHJPLI9OPCjUzO8JI+hSAWFtU0gphICeX0cOBZwVXQ49vTJK8lbrBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=BOgklEP1; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="BOgklEP1" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8cd759f502dso253727485a.3 for ; Mon, 09 Mar 2026 10:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1773078864; x=1773683664; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9lfgX4em38pbhc6TYJlG7GYrzpl0a5OWL9SJYa4uhDY=; b=BOgklEP1rVKeRYvRVcF8dkSYSNz524JVsZQ3oLxk9x4nHgrObcX0qmqRelvXQ3zOMJ zauwi2CvJridD0lhyqfuFdC3J3jY4JFiENN6mX71fTWX/xHDFCLKK8XLZu+i5FxS62FY 45Sw/AzeicW51uphGwuy2B4Y1+KvJ81PDo/+X7yCJZNeII531btGTaGS1Mex3Mqil5q7 7rRNiDImOH50nunHRiI0tJeitMoZaRN66FgoOjp6wJR2Rx6C6+96AmLVfsnPd19HRsWZ p7xyDOiV17eXMJhemTgj9dslmvQzO3/4OFIeTQUweXXF4KFV7SnxvNtqsQKQzkXozoPn Z8LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773078864; x=1773683664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9lfgX4em38pbhc6TYJlG7GYrzpl0a5OWL9SJYa4uhDY=; b=L1xHOEYjJB5Pr6yfmhNvVpLB5JfF7Mktd7LhkhS3vKeK4GhrJFv+i9oRiji5yzGcer rbumAdIJm5YbCYHXLpZxQF0zVLJ2crk+Upm/y4B+zSurwBPJCJTTl/6X5oTYI7/CGcMf eLU+au9b4RxptGjByyTiIus2rqVODIzhHspG8QGBjB0bmK1lJbOd7hRPcadofqgLHD6c n37hW0Fy3aXzBJ87DDW7BtkbNOjIuo0Qhm77XuhnhckZXlv9eOxVEJGn4k8w7FIrc558 16rxxyzNSSbddCibXRMRXIJsXaGA/Aj6eGcpfm8FkVcLVirQNR5HWmUPAI9dZHBrUb82 pEvw== X-Forwarded-Encrypted: i=1; AJvYcCWi3MvC5dSJCPxDW3IAVkCm43QKcjxBCmZbno1DV82cyBSz4c4YuNDWi4zM+iMrRqkPWQm8b1Fv+2Hv7Tw=@vger.kernel.org X-Gm-Message-State: AOJu0YyBH1YvNd6/cDtXt9aqVMJdc6REdOdD6cj8yBAYXBcHbsHEnP3D XMfIdktvHNKSXYyEnh1jk9MYQb3+lvAWGwBw8xKMAl0XIixRF5ta/JTwrHJ1srL8W0k= X-Gm-Gg: ATEYQzyBNob6mfhAucd/WK8jmflIr37nhTe8pIN2WGsAFlTnUaeMGVimQwaYxIzFoJr QNw4VqY7Bk7HCHrTQulB35zRnv9uG5SN4N8Y3+U16scf4R8jH+0hJYj4t4wDCb+HhXJpdUZL9qR A0R1jto2xpci6J7g9ZZjkdabFxRO7SZ59yW/H3dIqPl0vLYLvxVnO+D+9SNAwMcfMthCUQl2rdL gynzibjeQUu5MDUP8dz5be6ykLOPX8be/MHW3SQ4zX5wwRP1FgipFzGG6J0G1U+4sYBn1L7ep12 gtbMeEAgFNDPFujqKp+SnfnlGp9vfFjhDiihv0Lym3Hw/xHyVFlw6r9wtbJvImdycpxHsdlQSlg eYyOLfCE/NP8sZ6Q6FCpHpX5/vCjMgDyID76XYVhSIg6ZD3BtifTFq8bkHB61IDgfnbD8od0cvH ay6LQhoCLy+zRkUX/XaPridKnHGVQBdD/246dsGdNSFYt6btfio/7UXB3en4c6ENv3Pc9iGKcFb fDa627Qmg== X-Received: by 2002:a05:620a:700a:b0:8b2:ea5a:4149 with SMTP id af79cd13be357-8cd6d4d544bmr1554684285a.65.1773078863734; Mon, 09 Mar 2026 10:54:23 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd6f4878bbsm718502285a.4.2026.03.09.10.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 10:54:23 -0700 (PDT) Date: Mon, 9 Mar 2026 13:54:20 -0400 From: Gregory Price To: Shivank Garg Cc: akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@kernel.org, willy@infradead.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, ying.huang@linux.alibaba.com, apopple@nvidia.com, dave@stgolabs.net, Jonathan.Cameron@huawei.com, rkodsara@amd.com, vkoul@kernel.org, bharata@amd.com, sj@kernel.org, weixugc@google.com, dan.j.williams@intel.com, rientjes@google.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, dave.hansen@intel.com, hannes@cmpxchg.org, jhubbard@nvidia.com, peterx@redhat.com, riel@surriel.com, shakeel.butt@linux.dev, stalexan@redhat.com, tj@kernel.org, nifan.cxl@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Day Subject: Re: [RFC PATCH v4 4/6] mm/migrate: add copy offload registration infrastructure Message-ID: References: <20260309120725.308854-3-shivankg@amd.com> <20260309120725.308854-12-shivankg@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309120725.308854-12-shivankg@amd.com> On Mon, Mar 09, 2026 at 12:07:29PM +0000, Shivank Garg wrote: ... snip ... > > Only one migrator can be active a time. A second registration returns > -EBUSY, and only the active migrator can stop itself. The static_call > dispatch is under SRCU so synchronize_srcu() in stop path guarantees > no in-flight copy before the module reference is dropped. > ... snip ... > @@ -1820,11 +1833,18 @@ static int migrate_pages_batch(struct list_head *from, > > +#ifdef CONFIG_MIGRATION_COPY_OFFLOAD > + /* Check if the offload driver wants to batch for this reason */ > + if (static_branch_unlikely(&migrate_offload_enabled)) > + do_batch = static_call(migrate_should_batch)(reason); > +#endif > + should the migrate_should_batch call also be done under srcu? In theory it's an incredibly small window, but there is a race window. ~Gregory