From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B71318ED9 for ; Thu, 29 Jan 2026 14:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769697709; cv=none; b=WL1oLahqOk7D7Hj/XzBQPCSq7xzT/BLZQApapUqy7XhUXOhqcKUcYR0SKIePV0QhnyiM1ugaZ3lPtVse2zrvSrfvST7Yvj+4/yqd0WD1wMnK8L7Bk2ULQBRjnsgqk4pIq6Yza2iylxUBAT7irZy/1D2a9XHCXR/d/sW0HiCjA/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769697709; c=relaxed/simple; bh=F0b8hnfWHbsOvhccuNKow2wnsDEWWek2mfssz8GMxsU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lLrS96cdAz2Jnx3JuLVVJ1kv2tykVa17383i42FABykbMvv9UuWdIEfaex4NVdmNbRHXFoadwZxhyeyAoeh/oiwTcYc9o3U8McRAoTwYHqnNxY5DwWYiz6v3QGac9UMzZehquCRLjoI61GTIqwRuFNKf3H7br0qDC7DUNLM2e/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=DCdmfDvY; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="DCdmfDvY" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so7869965e9.3 for ; Thu, 29 Jan 2026 06:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769697706; x=1770302506; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RiXqWFBbTqasdWh8G25vCefiMtu7P/aKonwdz1Q+QEk=; b=DCdmfDvYjNE7C1O2jiZtSAx5VFyXp7kD/Q7BI5euaOR+Aece3eGzUKs2VWuSK81cFV 1GFRfcCRI5Gukv0bp9TizXNuyZfwsTpyqy5P+VkNyNxkRnws1AEIYl2hhEUd8UPa0/PW y+3TgGZgtrKtkyDwNhatNcP1EY9CAYjT70lD1b7Fs8UyFAO/WOJh+HnBMwFvQxOZlZBz QuNuFBwZImsqcYQ1MDZ/A8alCPRdprBiX4rjuvwJ24bIc5V0PHY1wJV1+QrbSDS7TFwP 0REI1tXsfsQnH7ryQMfgAhS9va5/2Ax1ONsbMHGzdnpe132FZc+P1kz/N4aylIk7XgMh TwAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769697706; x=1770302506; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RiXqWFBbTqasdWh8G25vCefiMtu7P/aKonwdz1Q+QEk=; b=qIV7QMeQ4cZ3U/5tshPIRXhHNZZ68Qudi62rs5cRi36QdRpq37VTih0K5TpGH/MOMl CeO8+djmBZZ0JG5ONUi2YBq0Hpkpn1TSgqYhbQ5VBpySsEjYayBDBFKTNSsXVbW8xZ4m d74IhIHfi8XFemwWa9rsHDv7c290S/i2OCgaotGlViGdNcIGrE78TjL3mL1tuN7XOKn+ SYMp6jBQ6etqV9B3nA1s7Q08MW5eDy8igpF+9IyBSndTF7UvKVp3rcU0VXea5FgoyNQK 3nD15h+CzDhO3Te6rc0eH2tWVAU3KqCaIu9ATdTOwkYxuKOqhVL6MfPaD1R0eW/wtul+ YQ0w== X-Forwarded-Encrypted: i=1; AJvYcCUgtQmfEkrww09tYs+5Zb83VEogHTGv/rn//warxnFh9V5ka0HAECHpLhDXh1xHRcJpvmCfS2X2jwfTilM=@vger.kernel.org X-Gm-Message-State: AOJu0YxdCuOb4VRPLOYU3gZmZ0gWiCED4Afr9S8OwpIn6PsdhOPkRzrH qXMhKkaModqdAIl0gw/FrQ+vDc4KWaEwMe8bxVc5FMz0s/ifqL+OStHPa6NuJWLUGC8= X-Gm-Gg: AZuq6aKf4leElOF0X+7lNr/yxEJqh7Y29XgL+59UGlCo3sUZxpMpfeYQREZvbjpFdCR 2pHWuOnQQNQuzepYM6JMZxXt8axQgKAGSaoxPbC3btBybgWHy7/OizHZ6reRW+ECFRl4MJ0mhG4 OdD5as3QBZ4aTnSiAJ7PHmFxodm+APQ1YbpfSu9wNBQ4RVFQdIK4+sebDDFiiWv3kaGX1vdV2wU JgVACrkw0lJ7M+5b3oat85f+nPi5ItPc/wFf1xcfal23+FIZAT249EBBBWCGYjYgaSVo9jNZN/R iC3dwVdzffYFFd9cjLd1Pc79TOyVZl+c8s9APT+WHGsLVQsusugCJzfMVY72i1Iq7VS3u0jnyvT IqUTJlY5pFduk9sGq2lSGgCwozK9U86nfDt5jAzRnEcVAtWD0Bi8FI4b3JKsPKlPun9vwKr1KOO qGX7vXbXsjCzzC8uUGPg9Snc1n97mfQw== X-Received: by 2002:a05:600c:8b76:b0:480:2521:4d92 with SMTP id 5b1f17b1804b1-48069c49d54mr120114805e9.24.1769697705735; Thu, 29 Jan 2026 06:41:45 -0800 (PST) Received: from [10.0.1.22] (109-81-1-107.rct.o2.cz. [109.81.1.107]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066c37433sm182396725e9.10.2026.01.29.06.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 06:41:45 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 15:41:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/17] module: Move signature splitting up To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Nicolas Schier , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Schier , Nicolas Bouchinet , Xiu Jianfeng , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?UTF-8?Q?C=C3=A2ju_Mihai-Drosi?= , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-12-0b932db9b56b@weissschuh.net> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260113-module-hashes-v4-12-0b932db9b56b@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/13/26 1:28 PM, Thomas Weißschuh wrote: > The signature splitting will also be used by CONFIG_MODULE_HASHES. > > Move it up the callchain, so the result can be reused. > > Signed-off-by: Thomas Weißschuh > --- > [...] > diff --git a/kernel/module/main.c b/kernel/module/main.c > index c09b25c0166a..d65bc300a78c 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -3346,10 +3346,21 @@ static int early_mod_check(struct load_info *info, int flags) > > static int module_integrity_check(struct load_info *info, int flags) > { > + bool mangled_module = flags & (MODULE_INIT_IGNORE_MODVERSIONS | > + MODULE_INIT_IGNORE_VERMAGIC); > + size_t sig_len; > + const u8 *sig; > int err = 0; > > + if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { > + err = mod_split_sig(info->hdr, &info->len, mangled_module, > + &sig_len, &sig, "module"); > + if (err) > + return err; > + } > + > if (IS_ENABLED(CONFIG_MODULE_SIG)) > - err = module_sig_check(info, flags); > + err = module_sig_check(info, sig, sig_len); > > if (err) > return err; I suggest moving the IS_ENABLED(CONFIG_MODULE_SIG) block under the new IS_ENABLED(CONFIG_MODULE_SIG_POLICY) section. I realize that CONFIG_MODULE_SIG implies CONFIG_MODULE_SIG_POLICY, but I believe this change makes it more apparent that this it the case. Otherwise, one might for example wonder if sig_len in the module_sig_check() call can be undefined. if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { err = mod_split_sig(info->hdr, &info->len, mangled_module, &sig_len, &sig, "module"); if (err) return err; if (IS_ENABLED(CONFIG_MODULE_SIG)) err = module_sig_check(info, sig, sig_len); } -- Thanks, Petr