From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812EFC433EF for ; Sat, 26 Mar 2022 16:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233799AbiCZQzv (ORCPT ); Sat, 26 Mar 2022 12:55:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbiCZQzt (ORCPT ); Sat, 26 Mar 2022 12:55:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 181BD270B for ; Sat, 26 Mar 2022 09:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648313651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=za0ay3SJgRTnl3/ewAAkXDmVNyKbkPpJW3j9ur8gjYg=; b=NHiMQ2rI3sUV+rbLsKQPJ9UzHXfaNf4ALDqCzLbrOlyL77Kwed3p25++QuLNNAXZLf2uCg x0W+p88cmKg2RL09r+1/0DPcGwJECtiu1tl4Dk+XOX2b5yXN73r9kG5BqelSqFhZbkiw8t 4C011ARk2Exo7NOWM7gBlxyJ/zJkmhA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-RDJ3wUMgPNe4QYFlnho3nw-1; Sat, 26 Mar 2022 12:54:09 -0400 X-MC-Unique: RDJ3wUMgPNe4QYFlnho3nw-1 Received: by mail-qk1-f198.google.com with SMTP id bs8-20020a05620a470800b0067e383077adso6954610qkb.10 for ; Sat, 26 Mar 2022 09:54:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=za0ay3SJgRTnl3/ewAAkXDmVNyKbkPpJW3j9ur8gjYg=; b=FDkkP6BquIsB8Xm9jDvZl6CwzH0qrm61TmP5SRTrkNBvVQ1uIkcSubrehuu9/q5byL uZE+o5+9jsvkZCaiedgC8Wo4L1AfaazEjSF6w1OkV2/s8bPAEjXOncH0/qMB6IzwL+9h E7cXVz4FT2V6IDBWWmZJnpYfqXsdgR6WQ7hto3xLOdbYrN67GTkWfD+GLWjt2nnGWHn8 hkhHKK598HYigXNHWppg6o+cntOQftJAiiUN5RAE9GfRwbalRLtQtx2UDmFwzBD/PjkC ElEXQvq0ws7pdoFLOGr1EvcMpQBRNlraGGSYAyPr22/bX0Do/l47L9Ni4V99++exnuzd cKCQ== X-Gm-Message-State: AOAM532NB0efMufhJ9ke8JvEORbfus7tSwgjjZkt6LqhZbZhbhqRQ3kh LQa64j9wu0ETv3/7YRjw//xgCXyEizDEl7MpDzNhYm9BP9bGcyK72srglYiDDkpRjlrEMDrJmLK m3R25T6UjJ1eydJuExODvg2hC X-Received: by 2002:a05:620a:2453:b0:67d:9539:495c with SMTP id h19-20020a05620a245300b0067d9539495cmr11101494qkn.30.1648313649222; Sat, 26 Mar 2022 09:54:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiPtOqE8LTGIHc8M7DmjMjq3TXcyBVbM2eRHpJShxnnQ1BzEa9HJ1tbpil4Kaf4dCjWy+54A== X-Received: by 2002:a05:620a:2453:b0:67d:9539:495c with SMTP id h19-20020a05620a245300b0067d9539495cmr11101485qkn.30.1648313648964; Sat, 26 Mar 2022 09:54:08 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id x19-20020a05620a14b300b0067e09a47e39sm4931700qkj.34.2022.03.26.09.54.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Mar 2022 09:54:08 -0700 (PDT) Subject: Re: [PATCH v2 1/5] fpga: zynq: Fix incorrect variable type To: Nava kishore Manne , mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com References: <20220322082202.2007321-1-nava.manne@xilinx.com> <20220322082202.2007321-2-nava.manne@xilinx.com> From: Tom Rix Message-ID: Date: Sat, 26 Mar 2022 09:54:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220322082202.2007321-2-nava.manne@xilinx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/22 1:21 AM, Nava kishore Manne wrote: > zynq_fpga_has_sync () API is expecting "u8 *" but the > formal parameter that was passed is of type "const char *". > To fix this issue cast the const char pointer to u8 pointer. > > Signed-off-by: Nava kishore Manne > --- > Changes for v2: > -None. > > drivers/fpga/zynq-fpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index 426aa34c6a0d..12f644e79e91 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -275,7 +275,7 @@ static int zynq_fpga_ops_write_init(struct fpga_manager *mgr, > > /* don't globally reset PL if we're doing partial reconfig */ > if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) { > - if (!zynq_fpga_has_sync(buf, count)) { > + if (!zynq_fpga_has_sync((u8 *)buf, count)) { Instead of casting, change the signature of zynq_fpga_has_sync to use const char * over const *u8. Also please review the implementation of zynq_fpga_has_sync. The comments says 'It must start with .. ' but the loop looks over the whole buffer Tom > dev_err(&mgr->dev, > "Invalid bitstream, could not find a sync word. Bitstream must be a byte swapped .bin file\n"); > err = -EINVAL;