From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5F738F251 for ; Mon, 9 Mar 2026 22:28:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095327; cv=none; b=PVtkPx96TppGKV753Cpsw16GerDo1zh/VLAqq7PuHkQwnVruydSWTRI5TDBK8fn7MmMOoncHc25DNjCDONPf2YCTgvGxRMbjYKU939XZm+CmHcKvuD5XfLWzVCGnJYQrDurPdY8LzgvqMFLilaq6t3bTfhlkX5cJI/Bf9Fh+O7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773095327; c=relaxed/simple; bh=jZe33NHvCpQzQ05RR193bC1srRh1cAqWr65aMtAsAwA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jj9q3M8VveBMLh3k71WUXQGpKNpsxSwiKV8nG8mczeqB3YLqpy2Jd3qCIa8Ny/KawtASmIJG9Ln628zm0FE1JUFkC/fPJ6MVCGVdzbzTwTxmc7aRoHGiR5qTT22esUkoYmdzFyf5QfPzkObstObM9ocKj4be/hWNKajcjrHrrGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WOv2SQa4; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WOv2SQa4" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-89a06bc2f1bso139742936d6.1 for ; Mon, 09 Mar 2026 15:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773095325; x=1773700125; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uelqhot/SS82mnivEOGwZ5YeQ/ZVb2Ub9laQIz/Sv+M=; b=WOv2SQa4QVLsDrZMUgqqUxwhimqRna7bBMLT2t7DAgtaPKnMxyzxXqtS9BpvXyBkEm LQBG+TTtAl7a2hLZb5CBrdSVY23jQTdaqb/2Gj2zYmBPy5Jfx4/Qy2wfxkhGtHMOQXXP katLe/1YrePIKqBWJFeu8EIgxpOIwPnXhaX+NoJfaO49U9bEZDa/ZAx6Nt7Gw9+FxDr7 TpXOZlp81m/ATHgjCt4eUtJv3wckiErYoEPCNS673GPwdeLzwEIT9VUcgBU/3Gndzi1y 5TQR8YG2LnEqZtRTNXjPxRJsHa/UPBNzIDwCaUAK60Siph46n13Hb2wCQ4aYdaO1fEkG 7wwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773095325; x=1773700125; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uelqhot/SS82mnivEOGwZ5YeQ/ZVb2Ub9laQIz/Sv+M=; b=O5ocpupihzAzBOBdHqG0K+PpxXmuxy6//HXDjvoQFlb23BtEqnMlC7TZHCIueKVSVY IyjpIbi8gGzEPHkn97k05m1g9Gk+Iw89cDiX7Nqt/OoliMYXQw0LS6NHwZMvJT0aTLa5 1U9e0flH5pEtm9TJquJc9sVqxJ658wm2o3/aVwm8DYYYdiRJKNsewupYRsw8cdSuDJ1i 8YH5sf9U+OH+45nFd8iROZE+gLPjvAIB+w6y/ctq7qPEXEIxkeS9J2Zla4o4xkdSUbF4 vE8OZHbvrH7bTPHe+wba0UnaDIWTYmTSJ0nXKWie1XorrZ4ui56D9dssw6bKIfTzQx9F 2cdw== X-Forwarded-Encrypted: i=1; AJvYcCX00PeFUIz1Tnbe8JBHsb7O4Yjucsr0V44NiXpBD8YY8nyl5yhjJlh3Uu00YnhcSoUABGhW2hvdbaxyDBo=@vger.kernel.org X-Gm-Message-State: AOJu0YzYuJlYR8sPisYCYRtHSG1CdR+5j9XYigAUVIYuAdjyeG99DyrE LYx5np74j8Q2DXne5oy5Yn55deQpVLGEjNo5GSOo+xIYLFajCXRXf2ZN X-Gm-Gg: ATEYQzx/XBLbk4zTROzUI2zIQ0CC4JZ7pyueaL9ivXp7ghanvEpQLX5aiCXVGlj9Ej+ cdek7izgPdCcB/RE98m5WBZzSV4kJ7zeQ4PnszqicdVTbmwEOcZ4gL0vUY2Gno32HCqoljLJsAM cnNjS9zU2eshKcTHYwQb/lOEsZGDnO60y+xNA8JSIwaMPauT4TXZGcdo50V1YOVB/2xwxaiBfMo 45kyrle8Dy71Mq9dGeki/IarQ+9e4M+32TaCGt99JMGR9SaI+Yj15f5wbUJyB5ST4olic10QZdW t0+EPIPCU3ubEyDDnl+AwZPYSkrTVVfhCIkQVrah+oO05g0++i/DnCTj0wjcBenuYgotVVlpOxG eDkykxsCKYghPLgqaRH9lwj6DYAXg6TLCdpwfJvUYSkRFLGuhsyauzgyBcyGtXj8hE+oA8dv4qF xaK8Py2vlEuGoXJu/OLLYwwyU= X-Received: by 2002:a05:6214:e4c:b0:897:255:d5c2 with SMTP id 6a1803df08f44-89a30a4d3cdmr192944066d6.26.1773095325119; Mon, 09 Mar 2026 15:28:45 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a57a1e68esm6918006d6.2.2026.03.09.15.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 15:28:44 -0700 (PDT) Date: Tue, 10 Mar 2026 06:28:08 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Shangjuan Wei , Maxime Chevallier , Chen-Yu Tsai , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH net-next v8 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260309004305.315018-1-inochiama@gmail.com> <20260309004305.315018-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 09, 2026 at 11:57:51AM +0000, Russell King (Oracle) wrote: > On Mon, Mar 09, 2026 at 08:42:44AM +0800, Inochi Amaoto wrote: > > +static int spacemit_dwmac_update_irq_config(struct spacmit_dwmac *dwmac, > > + struct stmmac_resources *stmmac_res) > > +{ > > + unsigned int mask = CTRL_WAKE_IRQ_EN; > > + unsigned int val = stmmac_res->wol_irq >= 0 ? CTRL_WAKE_IRQ_EN : 0; > > This looks like the last thing I can spot that needs to be addressed. > netdev wants to see "reverse christmas tree" local variable > declarations. > > Please reverse the order of these two declarations to achieve that. > > With that fixed: > > Reviewed-by: Russell King (Oracle) > > Thanks! > Great, after some lookup, I find the variables in function spacemit_set_phy_intf_sel() are also needed to reversed. I will also fix this in the next version. Regards, Inochi