From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6ACC433EF for ; Tue, 1 Mar 2022 02:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231211AbiCACod (ORCPT ); Mon, 28 Feb 2022 21:44:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230498AbiCACob (ORCPT ); Mon, 28 Feb 2022 21:44:31 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF5CD369E6; Mon, 28 Feb 2022 18:43:50 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 10:43:48 +0800 Message-ID: Date: Tue, 1 Mar 2022 10:43:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot Content-Language: en-US To: Greg Kroah-Hartman , Dan Carpenter CC: , , , , Jiri Slaby , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , kernel test robot References: <20220228135530.6918-1-yu.tu@amlogic.com> <20220228142751.GF2812@kadam> From: Yu Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi greg and dan, Thank you very much for your reply. I will make a separate submission as you suggested to fix Dan's suggestion. On 2022/3/1 5:23, Greg Kroah-Hartman wrote: > [ EXTERNAL EMAIL ] > > On Mon, Feb 28, 2022 at 05:27:52PM +0300, Dan Carpenter wrote: >> On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote: >>> Describes the calculation of the UART baud rate clock using a clock >>> frame. Forgot to add in Kconfig kernel test Robot compilation error >>> due to COMMON_CLK dependency. >>> >>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“) >>> Reported-by: kernel test robot >>> Reported-by: Dan Carpenter >>> Signed-off-by: Yu Tu >>> --- >>> drivers/tty/serial/Kconfig | 1 + >>> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++---------- >>> 2 files changed, 27 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >>> index e952ec5c7a7c..a0f2b82fc18b 100644 >>> --- a/drivers/tty/serial/Kconfig >>> +++ b/drivers/tty/serial/Kconfig >>> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI >>> config SERIAL_MESON >>> tristate "Meson serial port support" >>> depends on ARCH_MESON || COMPILE_TEST >>> + depends on COMMON_CLK >>> select SERIAL_CORE >>> help >>> This enables the driver for the on-chip UARTs of the Amlogic >> >> >> This is a link issue. The rest is an unrelated error handling fix. >> It should really be sent as two patches. > > I'll take the first version of this patch, which just did this portion, > and the rest can be an independant change. > > thanks, > > greg k-h >