From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbdK1IWk (ORCPT ); Tue, 28 Nov 2017 03:22:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:35398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdK1IWj (ORCPT ); Tue, 28 Nov 2017 03:22:39 -0500 Subject: Re: [PATCH] mm/page_owner: Use PTR_ERR_OR_ZERO() To: Vasyl Gomonovych , akpm@linux-foundation.org, mhocko@suse.com, gregkh@linuxfoundation.org, tglx@linutronix.de, vinmenon@codeaurora.org, guptap@codeaurora.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org References: <1511824101-9597-1-git-send-email-gomonovych@gmail.com> From: Vlastimil Babka Message-ID: Date: Tue, 28 Nov 2017 09:22:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511824101-9597-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 12:08 AM, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > mm/page_owner.c:639:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych Acked-by: Vlastimil Babka > --- > mm/page_owner.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 4f44b95b9d1e..79ae586d1bce 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -636,9 +636,7 @@ static int __init pageowner_init(void) > > dentry = debugfs_create_file("page_owner", S_IRUSR, NULL, > NULL, &proc_page_owner_operations); > - if (IS_ERR(dentry)) > - return PTR_ERR(dentry); > > - return 0; > + return PTR_ERR_OR_ZERO(dentry); > } > late_initcall(pageowner_init) >