From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A42E37AA72 for ; Thu, 26 Feb 2026 12:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772107281; cv=none; b=a0X1KkPYV4ore2lY8QKC/X7uvR29Ea/9LIv3m1QxEnhlxOBLSylZdV6ODJe1wmgq3E8HmhLpAOWQAsi8fSrnpwk2Wo03Tn6M00GHv5VQbQ4ckXpyoq+0d+9m6bsQl1iPXPhmd+wHe7upJnRWAIGV6tXs5GSpNaVDnpQcEJFjjFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772107281; c=relaxed/simple; bh=6rJNYnzuTkh5WwwqWmcNActQn5KLZirtrp12d4+C6QA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d7n+PMhczLtJCfoImOnnpDQC7Gv4FUk+rRGXy9uBCBsuGGE9+R7AiADU8YWaoc8j1+uB1RsxAU1nVCsRpsZY0CcsS+/mzA+RMwukXbPf9jhdU09LBef6aqrE+0BVj7I0U1vEfRmrIyhb8ZpJC0bPw8MnAqnc3f0028ZmCV3hfRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=z8QbA4u+; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="z8QbA4u+" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48371119eacso9112445e9.2 for ; Thu, 26 Feb 2026 04:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772107279; x=1772712079; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CVm53FXc7NhFRHAhfOKSIzY4AVtkoS2iWS1y3j0TwRs=; b=z8QbA4u+ijcr7KDgPxE7IBC7vmb4stMUEKQyaimCkB023L0JLSHzxp6n2kB2Yh1u30 ske0MrxSu6zK6vvv+Iup84fGm31HrXJeTBywot2NUB8PaC+vKtwaPfHYsSmZwo8U9ES+ n07rJMMhGb58rtRpNWv+9rFLDdGJ/Ro4RBag660y+ybcDBDp4e7IDgYk31buWYdGtxEr ILXhXMPqK2Mfg3AkMnRiT8cj/SM53iCSgOgCRx6tOGEzsF/Z+TAa5MPzJLrkXc3enbSH pyyWOrafY1MdDCR88QRLAUW7tt1rrMIGGRNk9tHYBaSPTPNVL5TSsVImKcPllpOVk+6B 6y5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772107279; x=1772712079; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CVm53FXc7NhFRHAhfOKSIzY4AVtkoS2iWS1y3j0TwRs=; b=F6YpjEWk6GGgkYirD7AWLyEk1hUWwtyeya4JLC+LCPpsq/aHS3JV9l/sZpNQa/uCHQ sjJbatr4Wbl8+p6zkoM4dNMhLh8AqqvKFN27ig+vS+pzPFH87Z0Uw8KBowv5z3Mi/W/T ThrgcCzxx3mnuRYTsa7oo/jwGMBTeN9fwkuz89l95LCLNqvCMfkgB2quNdXk8x05RFZw Ig3nSdC1wWlyqtai7Azv5b6vRAetUkwI8ndjoiZm/+nS7vaP6WQTHUiSxsZlcPhYzSNw X+JDGpw+4uIeMhd2KwiV01QpPJtRqI1m+yzgjTrKP0C+Y/JzFy0b4usBU05Z9h6ROu/U srmg== X-Forwarded-Encrypted: i=1; AJvYcCUuZsx33B8+DisNJe5rCLGUzjQVGsP3nb7W3+f85VpBHB16gDUOEmNobjILJXI9Bg/7P6RJBgj+s6+Vqiw=@vger.kernel.org X-Gm-Message-State: AOJu0YxmmmF9dktXa7Eo/fa7/HkIEcICHPQk+knm/F3LV2xornZRxz6T ft6/wsciF1hNvtdTm1ViIyesDCY02F++oxvvoAbuycmR/UAa8bPlJWO+w4ojbC1p978= X-Gm-Gg: ATEYQzzNEcdvcvSjkYDyAOWQJfhBtnSM/GG4c7MYlMUgqogvRJsJr9DZKGIfmzCsapI jHsGtwYvkQz1MiiFsLNRAoH7Xd6YSeCsqsziYWw+jX6D0R++urn9Vms+qZRNZOksPDXJ/0+lfe1 gppId243nx2PPgZm4Sgy+jHgz35Zv6BVw2lGCA6nzzUuDAJTSXT9kkC5GAzJghb3LqCMCb3M+gl NqzuyEIDgyPLHFA5wNJyfnrmk8CsJWjI3y4MS1FJ5GiH1mIKjzq2Sw94zMH+TBDvep9E6359vRA HJvybWdEWeNzYA5yOm5SycTT5MV1QVkB4xjdV64PxBwegmgkGwPdNybqrQgoUdiDG+lGawTX7U+ /NGD4Ro+Bu1iFF8MMknqmDfSk4Rk90ChFsV81r2nrn7bZYdAcRre+A4W8hrVkXwum/c9T0mGKXt UtHReVpuS48/VWsjrqfADj2SePhhDP X-Received: by 2002:a05:600c:3146:b0:477:79c7:8994 with SMTP id 5b1f17b1804b1-483c3df2ab2mr33696325e9.30.1772107278470; Thu, 26 Feb 2026 04:01:18 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcd0b14sm34546285e9.27.2026.02.26.04.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 04:01:18 -0800 (PST) Date: Thu, 26 Feb 2026 15:01:15 +0300 From: Dan Carpenter To: tomasz.unger@yahoo.pl Cc: hansg@kernel.org, mchehab@kernel.org, andriy.shevchenko@intel.com, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: media: atomisp: replace sprintf() with strscpy() Message-ID: References: <20260226111653.74371-1-tomasz.unger.ref@yahoo.pl> <20260226111653.74371-1-tomasz.unger@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226111653.74371-1-tomasz.unger@yahoo.pl> On Thu, Feb 26, 2026 at 12:16:53PM +0100, tomasz.unger@yahoo.pl wrote: > From: Tomasz Unger > > Auditing calls to sprintf(). This code is fine because we are > copying 9 characters into a 52 character buffer. But it would > be cleaner to use strscpy() instead. Additionally, the 2-argument > version of strscpy() checks at compile time that dst is an array, > not just a pointer. > > This is the only sprintf() call in the whole driver. > > Signed-off-by: Tomasz Unger > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter