From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outboundhk.mxmail.xiaomi.com (outboundhk.mxmail.xiaomi.com [118.143.206.90]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE71F399036; Thu, 26 Feb 2026 09:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.143.206.90 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772098106; cv=none; b=pDM/J047t/6PRhh5H+VRGXxtm/xaQtIxVYlaoC+V+fM7inuYUM4Hm75rm+0LDiSvfutGrMpNRfYqmsmWQDUR3jPfc76BD7Qkx+N0wgvK5tQmykOHGQ0poKfHBLMCjs5KY0dz+o7OXjNQ2fqE7jY1P4NM+XBtbYcg/woZq8wzZio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772098106; c=relaxed/simple; bh=8gETV4BrYJMCYq16lBMm+D36kDpEAoQEeE8bWymmCWI=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lvFTEyydXG3m1Feu8Q2ddqoYYuZtUToR9CFviDXPuE/88LenhScK7MRJIP2m1N2HUZVgbCrYvlKJYenIh8Dm7ACnljTDodq6cHnHqmFjt/5bUmPEwmdTliWTQTf1eUmRDVdZIaxPp/oxs83Rz0WXNULpD5f1CqLOk65ZrPlm6yE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=xiaomi.com; spf=pass smtp.mailfrom=xiaomi.com; arc=none smtp.client-ip=118.143.206.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=xiaomi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xiaomi.com X-CSE-ConnectionGUID: QropyfqKQWCBvs6mkB8INg== X-CSE-MsgGUID: m18cEuWIQdy4OrK/F56LLw== X-IronPort-AV: E=Sophos;i="6.21,312,1763395200"; d="scan'208";a="141931651" Date: Thu, 26 Feb 2026 17:27:01 +0800 From: Dayu Jiang To: Greg Kroah-Hartman CC: Mathias Nyman , Longfang Liu , , , yudongbin , guhuinan , chenyu45 , mahongwei3 , Dayu Jiang Subject: Re: [PATCH] usb: xhci: add xhci_halt() for HCE Handling Message-ID: References: <20260127110422.306711-1-jiangdayu@xiaomi.com> <2026012708-liability-sincere-5ed4@gregkh> <2026012857-deprive-putdown-0ee8@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2026012857-deprive-putdown-0ee8@gregkh> X-ClientProxiedBy: BJ-MBX02.mioffice.cn (10.237.8.122) To BJ-MBX03.mioffice.cn (10.237.8.123) Hi Greg, I have updated the changelog text as requested and resubmitted the patch. https://lore.kernel.org/linux-usb/20260128100746.561626-1-jiangdayu@xiaomi.com/ Please kindly review it and let me know if it is acceptable now. Thanks, Dayu Jiang On Wed, Jan 28, 2026 at 09:56:18AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 28, 2026 at 04:48:49PM +0800, Dayu Jiang wrote: > > On Tue, Jan 27, 2026 at 12:22:40PM +0100, Greg Kroah-Hartman wrote: > > > > if (status & STS_HCE) { > > > > xhci_warn(xhci, "WARNING: Host Controller Error\n"); > > > > + xhci_halt(xhci); > > > > > > What is going to start things back up again? And as you are calling > > > this function, why is the warning message needed anymore? The > > > tracepoint information will give you that message now, right? > > When HCE is triggered, it indicates a critical hardware failure. > > Aligning with the handling of HSE (STS_FATAL) by adding > > xhci_halt() here is more reasonable: without xhci_halt(), the > > USB controller may fall into an unpredictable and unstable state, > > which could exacerbate system issues. > > > > Retaining the warning message is necessary because it is directly > > visible in dmesg, whereas tracepoint information requires explicitly > > enabling xHCI tracepoints. Additionally, if xhci_halt() is called in > > xhci_irq() without the warning log, it would be impossible to > > distinguish whether the halt was triggered by HCE or HSE. > > > > > > And is this just papering over a hardware bug? Should this really be > > > happening for any normal system? > > Yes, this issue has been reproducible on real-world hardware: HCE is > > triggered in UAS Storage Device plug/unplug scenarios on Android > > devices, which enters this error branch and causes an interrupt storm, > > leading to severe system-level faults. > > Great, please provide this information in the changelog text when you > resubmit this, thanks! > > greg k-h