From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D46E3A0B28 for ; Thu, 26 Feb 2026 09:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772097865; cv=none; b=nHSp7toyEJi4/Yur5anCN02z6SKRuEzysDrLLJww8ucjXs6LeR0T063C7w/rFa8ODh7ryNYxuGYUeC6T73rLBNa4REIbc6OgWqr1ul31xvetw8jLXTUc80iRnuWw7ZjM8ixwKcjJ5cZzkta/kPZzCfLYqfvZ1v9pTUV848tGi70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772097865; c=relaxed/simple; bh=yKA7jbVMiaFWtffnJDetegTka4gNZTSWV8guGy+9b9s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bch0Na8+4E0HIQKBBQfEh4r5t+SoEXtZiJCMpdc/XnB33Wi0SxMa6pALa5Avua4ag+jay37xaVney743M9GVt++OTM+DvUu3ADYVG6kUAET6VsC5oiuEKVXqDrjCKZ770dpQMAXLzmyTX3NHd4/sooygpU9xJZLdZbU6fcW8BPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yiMukXWa; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yiMukXWa" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43988056dc3so610642f8f.3 for ; Thu, 26 Feb 2026 01:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772097862; x=1772702662; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=keY+cW4zUhb09S8chrogSqv2NyrIPeQHbnvEbaTc8a4=; b=yiMukXWa5xxvSJMp+V2N6CVxjR4+TIefOlKk3KgE6sJn1BcavO36MNjx9Ul/V0uULH 9XE+5SAhXJeDnLpWyrSZioBX70AlbcTO+biJkCcOOIULiBdNnMU9wO91SM2Gm9hLqrbe NYTKp3G25YnfBBIONnnAzyLs7VHhnpXd1xNBCEPY+osPaWS8xR1fUIm6gxch7mbjfo5w 3L8R1mQMhV28ApSxgLfd/z8QUJz0HtcIiI5Hr1CfVdmlaaA/xjVi1E+pNyDTKLpva9KU LC2K3KsKMSbCE2zJRoz7vWFRAkGkOVKxyioG7PHb9qMLR9PuMNgn4ylYOjlNyd2ubvXE uOjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772097862; x=1772702662; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=keY+cW4zUhb09S8chrogSqv2NyrIPeQHbnvEbaTc8a4=; b=M7qSYkHSqcplaxK76tMXFY/LWBYInksmTjMYDzpoxqL9xMWL31XogMm268X1TajM3K k/wcT5y5W+exdVgFhYC1nZ6oNExGP2bciJR2PXva0eclU2riR4iwg21JPyQPtbI+Yk31 DvOGX3KCPtzvRSOQfUcZBh3y53Ok1ChfiFjUm6b5yXFP6kFZXUk0m3unL4KFduyzPztC vvcrpnOFXy89jyDFuLOJGgj47DgzHIBq9QPXmwvM6Ur6ZjnVEnUmpiaUUKDG806kgmnR 3OZGA1ondIIifelXnaWmk3lTDeEyEs5nS4VzJUEJwkXQjwmgBk2jwtm36/4Q0ErIDA6K HjAQ== X-Forwarded-Encrypted: i=1; AJvYcCXFz7gPG1C5ifRpd4KBU3rKcoxf8Sn3Dv13ONyRBRkRnFKzaIO9mgxqQmRFyLZ47UWVBi0y6j+DxNxEITs=@vger.kernel.org X-Gm-Message-State: AOJu0YxvewWm1H5Q+1yxEAfSZtMGSAMaHqKBM/966QZ7UOUvQaYB1Gq4 fjSqmXhzchegjRlHTZvyaxNR3Jv2xA9Bank0/HXmwbeo1IZTm60Zdn/rnSzRenurOiQ= X-Gm-Gg: ATEYQzwJw53Rn2MhRuyupn9S8le/26N8g+rHHOJeBByQAhgQWWqZCPurTXpHujDw0+N FpukSSZtZujkrTMO3MSHL60LjgUSNfpI1gO0mkbVcpe8uh7hOawjedp/TghzYiNPIplABENnGSR QesaEx7r2LIRfa5dagxS3z4Gn8nAN3siG7UHZ9w7GxyF+pRa2AWlANrTuqKIbkCQcjiVzfIjw/C xK9js13f0jl0K3ysjaOXEERBH11+ieuZk4V60u/zY6FeYpsKT08BMxgkHJblfElv3XqPLBYXq2b aeOh7R0DjuJUx/Gg6EWBAe6Vk7EttfK8m39sPu2+2+o/jvzoS0ILE/DB3KDU+ftaLqWQR58FVPL P2E808NPxbJV5Toq1e3u4mNXotTVVuFtAV1+EDqIHQUggyzSgrtkLkg6O8JBzeoKUWxfxHJWei2 +syQADVT58ffYqjTPXER1VvxPwps23 X-Received: by 2002:a5d:5f50:0:b0:436:216:98d8 with SMTP id ffacd0b85a97d-43997ed6f02mr2704213f8f.12.1772097861652; Thu, 26 Feb 2026 01:24:21 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43990c38516sm9854266f8f.30.2026.02.26.01.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 01:24:21 -0800 (PST) Date: Thu, 26 Feb 2026 12:24:18 +0300 From: Dan Carpenter To: Mariyam Shahid Cc: Greg KH , ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Replace comparison to false with ! Message-ID: References: <20260223170708.9627-1-mariyam.shahid135@gmail.com> <2026022410-upswing-gurgle-532d@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 26, 2026 at 02:13:49PM +0500, Mariyam Shahid wrote: > On Tue, Feb 24, 2026 at 11:11 PM Greg KH wrote: > > > > On Mon, Feb 23, 2026 at 10:07:07PM +0500, Mariyam Shahid wrote: > > > Replace comparisons to false with their logical negation > > > to fix checkpatch warnings. > > > > > > Signed-off-by: Mariyam Shahid > > > --- > > > drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c > > > index ebe73abab892..0192543cdec0 100644 > > > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c > > > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c > > > @@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) > > > > > > rtw_ht_use_default_setting(padapter); > > > > > > - if (pmlmepriv->htpriv.sgi_20m == false) > > > + if (!pmlmepriv->htpriv.sgi_20m) > > > pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20)); > > > > > > - if (pmlmepriv->htpriv.sgi_40m == false) > > > + if (!pmlmepriv->htpriv.sgi_40m) > > > pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40)); > > > > > > if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX)) > > > -- > > > 2.43.0 > > > > > > > This doesn't apply to my tree as someone else sent this change before > > you and I applied it, sorry. > > > > thanks, > > > > greg k-h > > Hi Greg, > > Understood, thanks for letting me know. > > Could you advise which tree I should be basing my staging patches on > to avoid conflicts like this? I had been using the staging-next tree, > but it seems changes accepted there aren't always reflected when > someone else sends a similar patch first. > > Should I be checking linux-next before submitting to make sure a fix > hasn't already been applied or queued elsewhere? Work against staging-next. The other patch was probably sitting on the mailing list when you sent yours. It's not a big deal. regards, dan carpenter