From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7536A28C006 for ; Thu, 26 Feb 2026 14:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772115350; cv=none; b=jYMptLUyZ83y7VMpext0FrRW1YcGhprLj823/XIuqbV/HQW0QZ8XoBC+OrKUoOajlUgSEYhmgIB10YfQjXmSy/55DZqwEDkSwgFGA79dGIwUSw4fpJTIPxiFXiFG1GsFfi3kWNImu5cY/0581VqK38trnrD6AGTnT4P2XzTiL0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772115350; c=relaxed/simple; bh=wewAWdVy26NTuoODuywZxXrcf+iJudc8CGVvVaWrPZo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ATs81VxOxzeEilXu8PEwlOEbwyrvnTseELaXXhRdyS76vB3AjYqTAFjGbzMZNH/Y3dcG/wS6BICWF+zxDp/YNVyAIsM4fZgZIexkVLkktljeUW7ReE5xqjGlcqHKM93MNxFX3BfiBpmUUxMkZBlfAqnzkgVWSBkyPoSsxSy/KVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name; spf=pass smtp.mailfrom=chrisdown.name; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b=Z8FX2Hcd; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chrisdown.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="Z8FX2Hcd" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-8272c559597so897190b3a.1 for ; Thu, 26 Feb 2026 06:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1772115349; x=1772720149; darn=vger.kernel.org; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9s+UpFhge3zc0ML4d1eIWQzLbCji6+36HhEypvv/XJA=; b=Z8FX2HcdFb8O5WXMrm9D8ZG4iwgR2ZbGw6fvll4P5XeiUXIr8rLvtm73qj93m7N9bJ EBQ5O9JrKNYY38FH15jbXlLtkc6bwb68cWqIOYzcQg9qRUtH6GLnwv+GOCdGiFbOPPtZ CDEzqRSrZarQ7ZlNyYteqwfbAXDmx8T2NE2ss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772115349; x=1772720149; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9s+UpFhge3zc0ML4d1eIWQzLbCji6+36HhEypvv/XJA=; b=hq99AOMAGHfq6U5DaBWAl8+j2kBlOSg8/UnUCoSGJ4TsKTxl1x9p9uXm+YLogZ893Z +8E6vIiSPbI5pJTqD4Sd8Buv48Xf4EQI49WLc0zKnS5c/MlXcjgIi7f6jGv7fNfURDuk /rwQEc2UOa5tATAiReBlzdX6c6eZpwUwAld1V7eGqvgfNMLq68s/3jpHUfFzZxjNdrNM GmTHEhReLKvJGVfRMc2L8E3ZHrwu98hFOmmkqV3kbYF0h/QhvIXpQW/kXvBW993xCM6P gX+n2VuFCx6uin8dlauN2XWnFjC/+fN5O7w8DLd3AglB8up1OHp3XIFRftaQvtt0gr5P 8suA== X-Forwarded-Encrypted: i=1; AJvYcCXe9ZiGb/jx6BWajZt+rnqueGYnfHsBNVQ7CYw5lwyQ6ZWSHUZV03aqDip5B3kwe5BqboRX5k8tcLmL7Q8=@vger.kernel.org X-Gm-Message-State: AOJu0YxTEP0dZwK7bU7G3dLqBwMjzOL6rNYh0+ROUHvK2+h8P32BkKja y8RkbWeFxlJMa3dYslqEQbmvhk1UDlhmsQBHkzi/EXr7yiQtnaT+klniiQOxwBkTfK4= X-Gm-Gg: ATEYQzzGv/XVrO0ySl4UYKdELLBvvUFInfM5ggxI2ZM/jTjODgKf5lbK/0mhZPf2AfF 9rTsLcX6pq1G0Oc5AtkdII4wMQVakZLyJOe4U508G+VG2KxxClUcjB87ykwq1Yt4jB8NA85RUsV yR8BIrXD9eTkwpQXrpvJBBMyqrSMWN4g3NLTDyll6Allf+VkC/x/nfsXfcxqCtrIk8Y+Krlji32 ubKDBFzncTBPE+PmfdHD/y8qyMhIdma0/6V8QYGzqH54kIG+krFKR9MBU72ixWdi56aGZsqdGNy ouNOq3tJxjE5nMbq6FTkDymmkkFKvIK1cqRl4pAfoMpxJGszl5QNM0Uskg9Qgrkzq0H80xRbApi g9dY65t+EPTNEhJ7z+Tw+2nuVQxKJM/YuTIyXXEMUrBi2OssJLVEH5L8rAp5ObKfq4kt1U+Vn1Q 9e4cqSRnLDcNh+qrodZg== X-Received: by 2002:a05:6a20:9395:b0:394:58eb:48fa with SMTP id adf61e73a8af0-395b47aa1b8mr2354656637.6.1772115348571; Thu, 26 Feb 2026 06:15:48 -0800 (PST) Received: from localhost ([154.47.23.70]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c70fa82cf64sm2301093a12.25.2026.02.26.06.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 06:15:48 -0800 (PST) Date: Thu, 26 Feb 2026 22:15:31 +0800 From: Chris Down To: Andrew Morton Cc: David Hildenbrand , Matthew Wilcox , kernel-team@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 1/3] mm/huge_memory: Fix use of NULL folio in move_pages_huge_pmd() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/2.2.15 (2b349c5e) (2025-10-02) move_pages_huge_pmd() handles UFFDIO_MOVE for both normal THPs and huge zero pages. For the huge zero page path, src_folio is explicitly set to NULL, and is used as a sentinel to skip folio operations like lock and rmap. In the huge zero page branch, src_folio is NULL, so folio_mk_pmd(NULL, pgprot) passes NULL through folio_pfn() and page_to_pfn(). With SPARSEMEM_VMEMMAP this silently produces a bogus PFN, installing a PMD pointing to non-existent physical memory. On other memory models it is a NULL dereference. Use page_folio(src_page) to obtain the valid huge zero folio from the page, which was obtained from pmd_page() and remains valid throughout. Fixes: e3981db444a0 ("mm: add folio_mk_pmd()") Cc: stable@vger.kernel.org Signed-off-by: Chris Down --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 44ff8a648afd..fed57951a7cd 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2794,7 +2794,7 @@ int move_pages_huge_pmd(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, pm _dst_pmd = pmd_mkwrite(pmd_mkdirty(_dst_pmd), dst_vma); } else { src_pmdval = pmdp_huge_clear_flush(src_vma, src_addr, src_pmd); - _dst_pmd = folio_mk_pmd(src_folio, dst_vma->vm_page_prot); + _dst_pmd = folio_mk_pmd(page_folio(src_page), dst_vma->vm_page_prot); } set_pmd_at(mm, dst_addr, dst_pmd, _dst_pmd); -- 2.51.2