From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v1 2/3] lib: math: polynomial: Don't use 'proxy' headers
Date: Fri, 27 Feb 2026 18:18:34 +0200 [thread overview]
Message-ID: <aaHD2hxmKkW3MYyy@ashevche-desk.local> (raw)
In-Reply-To: <aaHCrscQCInxa3ii@google.com>
On Sat, Feb 28, 2026 at 12:13:34AM +0800, Kuan-Wei Chiu wrote:
> On Fri, Feb 27, 2026 at 08:47:59AM +0100, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
...
> > -#include <linux/kernel.h>
> > +#include <linux/export.h>
> > #include <linux/module.h>
#include <linux/math.h>
> > #include <linux/polynomial.h>
>
> Since polynomial.c uses mult_frac(), perhaps we should also add an
> explicit #include <linux/math.h>?
Good point! I missed it somehow. Andrew, do you want a new version or can you
amend that in this patch?
Thanks for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-27 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:47 [PATCH v1 0/3] lib: polynomial: Move to math/ and clean up Andy Shevchenko
2026-02-27 7:47 ` [PATCH v1 1/3] lib: polynomial: Move to math/ subfolder Andy Shevchenko
2026-02-27 7:47 ` [PATCH v1 2/3] lib: math: polynomial: Don't use 'proxy' headers Andy Shevchenko
2026-02-27 16:13 ` Kuan-Wei Chiu
2026-02-27 16:18 ` Andy Shevchenko [this message]
2026-02-27 7:48 ` [PATCH v1 3/3] lib: math: polynomial: Remove link to non-exist file and fix spelling Andy Shevchenko
2026-02-27 21:18 ` Randy Dunlap
2026-02-27 16:27 ` [PATCH v1 0/3] lib: polynomial: Move to math/ and clean up Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaHD2hxmKkW3MYyy@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®