From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E631346A00 for ; Fri, 27 Feb 2026 16:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772210400; cv=none; b=SI43Vi7XCKvi8o15K2FX7yx0r/+TjtJjGvTqHKKkMQHLn8mHaIYVQKUSiY54jVFdVM3ayrPsXUOwedoD6n04vvSQx7hlxWscRhnyzTm1QubVbl6lwVR+44YjOCko2UClJEoWdZw1cOXLlUjIwAbrYE+Wp7iz0d3Z2/S3zkFUV04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772210400; c=relaxed/simple; bh=40us3EAYr0jd9t4cPeE3LbJbTaSrK/1lJhji66JgsL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RHX4kVP4bTMghsqC1Ai1TNqjmnBxUcaHCmDGv/6TjPqM5wRnrZoc7mTC/bzPee999/XUM+0Mhe/tMHks0I2XVvWYlLQ5fJLYxX60PYyq1+U9IoT/NAuDkcZhAK1t20zAYD/PI6yrPmA2GfE5lW3p8CqKZdNFcYo0ryBSl1KGbCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IXPFOtJa; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IXPFOtJa" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b886fc047d5so378145866b.3 for ; Fri, 27 Feb 2026 08:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772210397; x=1772815197; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/TU8pJDzZHIXOYpriXH+I1hchhH6j+5Eu0uZI5ch9jU=; b=IXPFOtJaOJwT7F8KOZ3Ro96Q8/GxZO4Vn6UOaMhGt2q6TvnqpxyImmqGWnVex6t69P az+mgteCKH3AqAaHXbg3vZO8d/S6cbWRGBEoaxLo3iaFC9K0KMNC5YbxGbrBmBNQuZN/ ylH1pY2Hvo0vjGgmzMcWyFYW2cBGZ0CmKUkSjpfA6NCb9Pa1g23Lf/94yhsNKMrc824F hTrK25kgsNGumQ5QU60q3VjWasJk2zXTkaYRPd1+P+hHKNfkVDLB6esIFrD1HFwBWpum gPDW/BHaB4E8ziHBImXrhaHLJ8xivKtXFTsIzhZu+0x1480Jl+wWu4bUgKfLmGIeAd5e Gumw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772210397; x=1772815197; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/TU8pJDzZHIXOYpriXH+I1hchhH6j+5Eu0uZI5ch9jU=; b=uD6g58bZV52kdZuTaZyfBiT5nZjknBs4cMxWtykknVvy+XiEBMt/M+47fbNdiAAFnn SzMVkKIf9jlU/ien+Ycjb+hzeWQC/EW5gwY8q65L7u4AGBOBB6vDMDIEv4S9TLupT9Kj nN3FZlDEJbYab/8SvRMEPxp2NSEqAl5LrMBInAhLvlviVsis/Z81vm0o0/9a6wMBpRuB jB0p7Mi0ObMnrWl92qpaJJhBETRQpxzA8X0WRLwThb4t1uyK98DVzP7od6hcK7FQK0HO qR2q7CZcjZsjHfCw5rnWxgHf1KlqXfpvb1K5uQ2hzqFN3kM4RJmB1Hiu/bMQzGqqZLdA Fm6g== X-Forwarded-Encrypted: i=1; AJvYcCVbaF68dDmC0QhNM5+drYWjQE+igYVmOj+Galc4AfhZ2orrCdeYH7hsy0d4BN9DJ0XcFrq43FS8Ucrx6LA=@vger.kernel.org X-Gm-Message-State: AOJu0YywP5/+0zcOdPCM4ctUmwuvkp++YYNavcTwpuYJ97Ws14FnkhE+ qeUtr4E9hUVPP+NMIHelqlwmn4Cfb1nEuaatJSelQcHrHlWrWWlWsIwC/31/PGLWqtI= X-Gm-Gg: ATEYQzwZK0Bnw2P1Tqxm6bEx6pWz1EW/5Ftp89lquYRS7Q/CoSHNl4amBaDFkRPHVoU bPOa54/ox3UVKAa/HYdVKRxUxnt7IM1NIsODSL2Dus5/jWuFY71jIumDNjJ+c5yYnXgHcXlOiKV XdMKd2JBIQ0cyoATGY1fsmSROp0/yVjTRDTXxtcC/156W93ec1Ox0tE3w6Kw3WU2nRNfddcPgNz XIBSu+kTeadc0YQKEpkQIIYY4Spfn8mEY8MggmML4woPRzUXWZsiQrpHy9pK11mSf4/zdpYNBD4 j1930tbNp76rxEgx76CbwqnmZAo73WcAW4N1KebONSx5mHZJDbld0o9GlvD6t0tSAC6Zvjp6xXu drGbKN23B0kwzRw2UdswwBaNC+n9rPZyaNMZozkG2K9MQ2EIvt0GiVN6Pq2wazJo33hIMCSCaB9 qsce15NPvP10p2FceqTxt/sLHsguxv5oFLXCaH2mc= X-Received: by 2002:a17:907:2702:b0:b87:2780:1b1e with SMTP id a640c23a62f3a-b9376547e0emr175598366b.41.1772210397387; Fri, 27 Feb 2026 08:39:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ae6132asm164299566b.32.2026.02.27.08.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 08:39:57 -0800 (PST) Date: Fri, 27 Feb 2026 19:39:53 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: "Jose A. Perez de Azpillaga" , Greg Kroah-Hartman , Minu Jin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: replace msleep() with fsleep() in rtw_cmd.c Message-ID: References: <20260226010536.179729-1-azpijr@gmail.com> <20260227084623.209913-1-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 27, 2026 at 09:18:24AM -0600, Ethan Tidmore wrote: > On Fri Feb 27, 2026 at 2:46 AM CST, Jose A. Perez de Azpillaga wrote: > > Replace msleep() with fsleep() in rtw_cmd.c to improve delay > > precision and follow modern kernel practices. > > > > Specifically, this fixes a checkpatch warning for the 10ms delay > > in _rtw_free_evt_priv() and updates the 100ms polling loops in > > rtw_chk_hi_queue_hdl() and rtw_free_cmd_priv() for consistency. > > > > Signed-off-by: Jose A. Perez de Azpillaga > > --- > > v2: changed to USEC_PER_MSEC instead of magic numbers > > --- > ^^^ > Remove this. > Having an extra --- cut off line doesn't matter. The other thing that you sometimes see is an extra blank line before the --- cut off line and that's fine too. regards, dan carpenter