mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: David Carlier <devnexen@gmail.com>
Cc: David Vernet <void@manifault.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched_ext: add unlikely() hints in do_enqueue_task() hot path
Date: Fri, 27 Feb 2026 07:30:00 -1000	[thread overview]
Message-ID: <aaHUmL2Q6fnhM6j2@slm.duckdns.org> (raw)
In-Reply-To: <20260226224425.8819-1-devnexen@gmail.com>

Hello,

On Thu, Feb 26, 2026 at 10:44:25PM +0000, David Carlier wrote:
> @@ -1360,10 +1360,10 @@ static void do_enqueue_task(struct rq *rq, struct task_struct *p, u64 enq_flags,
>  	 * is offline and are just running the hotplug path. Don't bother the
>  	 * BPF scheduler.
>  	 */
> -	if (!scx_rq_online(rq))
> +	if (unlikely(!scx_rq_online(rq)))
>  		goto local;
>  
> -	if (scx_rq_bypassing(rq)) {
> +	if (unlikely(scx_rq_bypassing(rq))) {
>  		__scx_add_event(sch, SCX_EV_BYPASS_DISPATCH, 1);
>  		goto bypass;

both scx_rq_online() and scx_rq_bypassing() have the same likely/unlikely()
annotations built into them.

Thanks.

-- 
tejun

  reply	other threads:[~2026-02-27 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 22:44 David Carlier
2026-02-27 17:30 ` Tejun Heo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-26 17:50 David Carlier
2026-02-26 22:08 ` Tejun Heo
2026-02-27 17:40   ` David CARLIER

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaHUmL2Q6fnhM6j2@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=devnexen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome