From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ethan Lam <ethanlxkernel@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org,
andy@kernel.org, hverkuil@kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: media: atomisp: fix block comment style
Date: Sat, 28 Feb 2026 01:54:09 +0200 [thread overview]
Message-ID: <aaIuocYuOMc-yOin@kekkonen.localdomain> (raw)
In-Reply-To: <20260210113557.71677-1-ethanlxkernel@gmail.com>
Hi Ethan,
On Tue, Feb 10, 2026 at 07:35:57PM +0800, Ethan Lam wrote:
> Fixed all block comment style warnings by checkpatch.pl.
> Kept original indentation in comments (requested by Andy Shevchenko)
This can still be improved.
Please see section "Describe your changes" in
Documentation/process/submitting-patches.rst . In particular:
Describe your changes in imperative mood, e.g. "make xyzzy do
frotz" instead of "[This patch] makes xyzzy do frotz" or "[I]
changed xyzzy to do frotz", as if you are giving orders to the
codebase to change its behaviour.
No need to mention original indentation is kept as it is correct.
Is atomisp_cmd.c the only file in the atomisp driver with checkpatch.pl
comment warnings?
>
> Signed-off-by: Ethan Lam <ethanlxkernel@gmail.com>
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2026-02-27 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 11:35 Ethan Lam
2026-02-27 23:54 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaIuocYuOMc-yOin@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andy@kernel.org \
--cc=ethanlxkernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®