mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: junan <junan76@163.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, sakari.ailus@linux.intel.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace NULL thread handler with a dummy function.
Date: Sat, 28 Feb 2026 12:15:51 +0200	[thread overview]
Message-ID: <aaLAVwiUZs_i8U3q@ashevche-desk.local> (raw)
In-Reply-To: <20260228023643.12000-4-junan76@163.com>

On Sat, Feb 28, 2026 at 10:36:46AM +0800, junan wrote:
> Hi,
> 
> This is a similar problem as [1]:

> [1] https://lore.kernel.org/linux-iio/20260227071409.aEG-iBFD@linutronix.de/T/#m15ab81856b42f72169fe51bd87fa399b5147441f
> 

Make it a Link tag.

> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
> 
> There are two iio devices on my machine:

IIO

> ```
> junan@fedora:~$ ls /sys/bus/iio/devices/
> iio:device0  trigger0
> junan@fedora:~$ cat /sys/bus/iio/devices/*/name
> als
> als-dev0
> ```
> 
> The function calling chain is as following:
> 
> hid_als_probe(hid-sensor-als.c)
> 	=> hid_sensor_setup_trigger(hid-sensor-trigger.c)
> 		=> iio_triggered_buffer_setup_ext(industrialio-triggered-buffer.c)
> 
> `iio_triggered_buffer_setup_ext` is called with a NULL thread handler, and the flag is set to `IRQF_ONESHOT` inside it.

> I am not sure which flag to change, so I replace the NULL pointer with a
> dummy function or can we just change the flag?

Besides you used way too long lines, the last sentence (question) has to be
located in the comment block...

> Signed-off-by: junan <junan76@163.com>
> ---

...somewhere here.

And answering to it I think it's band-aid and wrong approach.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-02-28 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28  2:36 junan
2026-02-28 10:15 ` Andy Shevchenko [this message]
2026-02-28 11:21   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaLAVwiUZs_i8U3q@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=junan76@163.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®