From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Gow <david@davidgow.net>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
Rae Moar <raemoar63@gmail.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kunit: tool: Terminate kernel under test on SIGINT
Date: Sat, 28 Feb 2026 12:37:30 +0200 [thread overview]
Message-ID: <aaLFalGTilMjWyJH@ashevche-desk.local> (raw)
In-Reply-To: <20260228100727.208896-1-david@davidgow.net>
On Sat, Feb 28, 2026 at 06:07:22PM +0800, David Gow wrote:
> kunit.py will attempt to catch SIGINT / ^C in order to ensure the TTY isn't
> messed up, but never actually attempts to terminate the running kernel (be
> it UML or QEMU). This can lead to a bit of frustration if the kernel has
> crashed or hung.
>
> Terminate the kernel process in the signal handler, if it's running. This
> requires plumbing through the process handle in a few more places (and
> having some checks to see if the kernel is still running in places where it
> may have already been killed).
I killed my branch with those experiments already. But it's really appreciated
to see this going to the right direction.
> Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
In any case, god bless `git reflog`, I got it still from there and hence
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Tested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
(Have to applied the other mentioned patch first)
Now
^CERROR:root:Build interruption occurred. Cleaning console.
[11:36:29] [ERROR] Test: <missing>: Could not find any KTAP output. Did any KUnit tests run?
[11:36:29] ============================================================
[11:36:29] Testing complete. Ran 0 tests: errors: 1
[11:36:29] Elapsed time: 33.615s total, 0.001s configuring, 5.122s building, 28.492s running
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-28 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 10:07 David Gow
2026-02-28 10:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaLFalGTilMjWyJH@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=brendan.higgins@linux.dev \
--cc=david@davidgow.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=raemoar63@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®