From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B4E38757E for ; Mon, 2 Mar 2026 08:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440956; cv=none; b=bfnYanglnbSy/m2JalHbfJGTppwIt8oN5qCrfyKZmK/OishCpjjr/ZsNOG7YcTsKLJivDBJVxxRL6Z9WclHwSE+3Tm43qyNB/KNcijoktZt/bqiay5IMFv+sg7WWjcti6ZKod0vwmMwb9ah6aRd2zleka3rMIwYvwP4cg3b4/Do= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772440956; c=relaxed/simple; bh=ioXHuHf5x8kilTZvc0/LkC3Lf+ZlVpDUaLVfD874aak=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O3bJwNa3jMeSGaLIZkTmC4YnWzfbsCoANIXzBMVFRVeJdeyh8mK8M3n0CCFarANx/YxwRFzX9zkk1P2zeYtXEtdSKfA4XDfg9yeQ1I3USlfqvOYlu1bcgT/ulBzV1UpmYK7C3bwx+Sxali6dsvD5V9dUQ1W4VjQBCVpRaDgEPw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Iz497exg; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Iz497exg" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48336a6e932so25801775e9.3 for ; Mon, 02 Mar 2026 00:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772440953; x=1773045753; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bQpkpONAoiB21faTuam742HCl3Sr2eZ199nE2z/ULBc=; b=Iz497exgF5T1y/wng7NfDkzkD4dCs3X99WhJdHudftTQkqUj4itSn2xNkBLgin7Xl/ MPsTS5/TeU2Yrp5a2JPYJDbD8Vn320cv3I2A1SOqfDDjkx05H+THPPOFsxQlZ7+3QsGd qqvFXGRCePOaSs9vWrcw5zXkpS7Pszz42RTidJcVALVV6SVubs+AQTK9eIS0ORUECOk4 3pGiz0v4EMEtUtsV49nvBI/dAhXQpx6nyxAgmeiEC+E7If9Qx9ELdt6JrhQCdpImgCbN 0OVER/r7tagS5IutUdmoHnB5wkDaTyuhplv1LJJ1yqKrs3DRaT3lPtZz+w4K77enBeFV S3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772440953; x=1773045753; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bQpkpONAoiB21faTuam742HCl3Sr2eZ199nE2z/ULBc=; b=DgXIGcKI3fxG7CCW4M+zw4gbaM5IPcOFTpFwmqFc+0kz0UTIwuUk+451T/EK5Yfaj8 6FO/QxaXtuUSD9iVYzuWPIPyP+hgXd2V3E9RdwD9W+sZ2ajU/8p4PK6mnvlalGlxNiiE JD0l6Ywh+T8g2Mto+9yKhFGXp2FJvndcmBpT5HeBzvt1um20KjuCh5F/UE458pG+avT9 cPD1tQEoeqYBcWBtsFoXz3QuTZrhQ3mGQSRtnVhGgP4hY3J1J5GZJBb13Vmo0pF0xDRU evpL9zJkBIcGvXI5o2fIgnChxL48NzFKKmjwdoS7oYee7H8tdccFK/cddhx0XGZiMDcL 4N1w== X-Forwarded-Encrypted: i=1; AJvYcCXrLSYTovD5WOAfybZR3Qm1OigdAFElujaopcqy3IUX+V3lA+2vmOwIThtTLF0zYo1sC1LKrz/+9cct4Yk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1I/TbWPHRU1nCL0rrFaq8JLkp2l2RECbh/B2xEQy5zfJOG3nO BK5fVp4942i+XcICqC4s4zP1iJ5aW+HrEpf8aFo19D77LMEXTzz+GLQ2Vvd0L95RQfzOlg+9Vme HtQxx X-Gm-Gg: ATEYQzx+jpNz2lKREZcKszaSQroqa3N9auW/LbBLMtO+bAbT/7WyCmKy67Ulsbxbyi2 VGs0cRB/ip5WkO9LmciNCZhjEm59HJkKd2YBnS87Lp+NakHKpC5MS4Wu+rLWi2U38l0vs6HWRQo 9YogYErGJ3PNX3wep0ML7vYWMQ7xKx+gw6PdsFHaM3dToIaavEVUsh+8Aqol2DqI8B3aQLpvE8z v/ASo5PkYYW649851S3TOy8MmidWuyFc++Gq684E1el6hatpUI2Ua90wWd4zEpK591D3oEFupbV HoyB4YlUAHOVw2y2kvdq9cmXiPe7U/zRohGnFASMFVdI1ZSJ+7ZBK65B1o5ds+OqDT1gv55pR8h vW2Q6WgZ0zrwXoACl6xmlqG11mB4LbqGvebiSG0wzM1Br+rdPvrZMSVXsh3VvYvrRmUC4tD/rwH ohGpPX/CIQCGjRlV4ygh5bRoQw7sj7 X-Received: by 2002:a05:600c:8b01:b0:477:9b4a:a82 with SMTP id 5b1f17b1804b1-483c9beb38emr216751065e9.35.1772440952833; Mon, 02 Mar 2026 00:42:32 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfcd0818sm123136905e9.26.2026.03.02.00.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 00:42:32 -0800 (PST) Date: Mon, 2 Mar 2026 11:42:28 +0300 From: Dan Carpenter To: Josh Law Cc: Greg Kroah-Hartman , Ovidiu Panait , Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH v2 01/10] staging: axis-fifo: fix alignment and line length in wait_event_interruptible Message-ID: References: <20260301214815.2628942-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301214815.2628942-1-objecting@objecting.org> On Sun, Mar 01, 2026 at 09:48:06PM +0000, Josh Law wrote: > From: Josh Law > > Signed-off-by: Josh Law > --- > drivers/staging/axis-fifo/axis-fifo.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index aa90b27197cf..aac2c58ef9b3 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > mutex_lock(&fifo->write_lock); > > ret = wait_event_interruptible(fifo->write_queue, > - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write); > + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= > + words_to_write); > if (ret) > goto end_unlock; > } Btw, Greg already NAKed this patch from someone else. https://lore.kernel.org/all/2026022711-showoff-bakery-8235@gregkh/ regards, dan carpenter > -- > 2.43.0 >