From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Felix Gu <ustc.gu@gmail.com>
Cc: "Francesco Dolcini" <francesco@dolcini.it>,
"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1119: Replace IRQF_ONESHOT with IRQF_NO_THREAD
Date: Mon, 2 Mar 2026 18:42:05 +0200 [thread overview]
Message-ID: <aaW93QGdN25mqFUA@ashevche-desk.local> (raw)
In-Reply-To: <20260303-ti-ads1119-v1-1-71b54880edf3@gmail.com>
On Tue, Mar 03, 2026 at 12:00:04AM +0800, Felix Gu wrote:
> Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
>
> Since there is no threaded handler, replace devm_request_threaded_irq
> with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD.
...
> if (ret)
> return dev_err_probe(dev, ret,
> "Failed to allocate irq\n");
Also consider dropping this duplicate message as the callee does it already.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-02 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 16:00 Felix Gu
2026-03-02 16:15 ` David Lechner
2026-03-02 20:00 ` Jonathan Cameron
2026-03-02 16:42 ` Andy Shevchenko [this message]
2026-03-02 16:42 ` Andy Shevchenko
2026-03-02 16:52 ` Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaW93QGdN25mqFUA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®