From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E41C407598 for ; Mon, 2 Mar 2026 14:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460958; cv=none; b=MUzi1UlsESArnizOE49l77+F9Q+7l2j6TY0TMbTL40Prid9winm8lZkWs3SSxjBx7RyQOr9xf8ah/H72vZkJZcADkY4SYm5ao9PjWG6ag/KZ6puJ3KvwOAl1mzKw5NDxFjwK9w8eZVfD2tbPmFDhKR+4i3XFKR1PFEf4KbAJaQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460958; c=relaxed/simple; bh=7ZLOBw+V/Ytjc97Wt5/Nmpbf+IdKeEYCzCRPqnZy4JU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A4R78dy95pI+wqSCq2Q9hRyCTulfFPW+mE7jRuww8nqqFR1boiqXcfR2hJfHg5+QfqoJY5QSXQncqd5dqd9YJnu5u+rc+pF52gzcbVPggkp3ghS+JuS60Pt3ncAxR6UgkOli9MwTQuyV60qcBWMsLJYtAlkHEJvJGBUuK+7hWqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OvVZpyhc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WwYce+Qx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OvVZpyhc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WwYce+Qx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772460956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3dNL6Ecogn7179PIU+RK7iPFZtmAH+GeUTZmsoq0sw=; b=OvVZpyhcAkjyepikMAfc4y2my7kfH77/YBrBziGqgQ2dmqLHZ87SZ5xH7xH7P4EZ0qUBkr Ye8wwxFHFHfKyxp0GIZ/27IVLl9Lrs9cmZydMYVWldXoOqLRc0WDLd5hYK2AHirk47/qyh j56hhywZ7Ctrg0vbGe0UTOvWehf3EsA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-wMnXbwFMN3GNVWOFvMVyIw-1; Mon, 02 Mar 2026 09:15:55 -0500 X-MC-Unique: wMnXbwFMN3GNVWOFvMVyIw-1 X-Mimecast-MFC-AGG-ID: wMnXbwFMN3GNVWOFvMVyIw_1772460954 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837b7903f3so55888095e9.2 for ; Mon, 02 Mar 2026 06:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772460954; x=1773065754; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H3dNL6Ecogn7179PIU+RK7iPFZtmAH+GeUTZmsoq0sw=; b=WwYce+Qx7qpeonb3X0nzDKweE3kTnJmFJb94YOd9XGU6hRDHntwyJM8d1LnbkV6jTn lTGG4VlMswoIkHX3EWWv+SAg8gtXmI8ZYxLwsEuhvF19o6YwBLf1ShNEyPgxNsiXcO11 J6hd7wztBaDEnxegmWMQ7aIM6qndDsKtVnU6n3tZD0HpWKFosHQesTlNduRN7XTNKUf4 jJw6I5wO177Tp4fKeY3M/HrC345bwgGpQ/E+A3aqrErPWPLz6TKUl942fFZ7N/4/e/dM vIt/53Eq1Aqh9Ujzsv1Xa4Xyqi7nXWG5P3vEtO5OIkCx65M2zeA6s88YZGPh0gD30on1 tbiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772460954; x=1773065754; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3dNL6Ecogn7179PIU+RK7iPFZtmAH+GeUTZmsoq0sw=; b=XYs7XLDuIegQplyxXoT++ebqnWzeOou98csZzRVNQeQ/zkiwkDNAPe9cR8sxRd5D7v RpKYTWQxj1WTs+K22eJyKBm+dG0gwxQfTAW+Q2AND8RnYCv4rh7ViynpHf1d+1czAQxF XBXycETb4FmS51ZotfJeW78o6s1HnfD1EAA6C/h7XSBIkkvh5O5p6m3pRFQnsjT9Ade7 Ismv5n2UArnMisihiq8z/1nV7298trU4080jlcuYcy1Wwpdc1cgs5l29TvjwAubQizh8 lUHDdJbTm00ENlrPsG57+PiAcSC7qxgZf2YKltwkQc5lfLYu34FYSp/08Xk5T3wmHFOn vIxg== X-Gm-Message-State: AOJu0Yzxn8o+VhU74oUrTYJkLjJJKx+euTfbfjzwv4jX7bh1rUt7gCUK DJeYV/FtTMK9ol2R3q2pTFJUJ0NTDszhN4jOH04+mx3d4SWfgptTyBaiHn5fuE9AgEIBzW6KWh/ mW5MNnQPOxNW3SgAiITwycESik9LhTRX9etsGxkgOlSRwse3ZkmR/rDY9aVikQMqaFg== X-Gm-Gg: ATEYQzxVZ9J3APm+Q2OW6QweepbkKHTOyEI+3XNYIS9XqlGcwfHQZIi0MbIJulsTXpv D29+kB/jljum/+Bayxve+ti/sTKtSsZlwErjjEcXZmrFXrT1bDt+GhDSm5DBlbftyIRpF8xJOqF ZMfPKM1of0M4rwB+6kX+dv9KJlnn0/oJ3eOhOdkCRXhsHV6B7S3lt4op4/CPx182RdhKmaZ3dBG uEZ5W6P9xQmKxBl0CgHX9p1nDvtvnAbAxji5PWT7XY4ExGhuVbFVZVZBfl82RxVLjFmpt6/B03+ CW29mK3hHZyjd+d6lCmVgqTOTvAEgUS69y138eglXbN/HLTxPA7YNc3RxIMdfIgZYQmPhFqdTJV UlEONBv4tXHpcrQ5e7RskAbCX5Mi9woFGb6njlxB2OTMhYPaiEbY= X-Received: by 2002:a05:600c:4f50:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-483c9bb8ef7mr229822885e9.7.1772460954006; Mon, 02 Mar 2026 06:15:54 -0800 (PST) X-Received: by 2002:a05:600c:4f50:b0:477:6d96:b3e5 with SMTP id 5b1f17b1804b1-483c9bb8ef7mr229822075e9.7.1772460953490; Mon, 02 Mar 2026 06:15:53 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.73.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfba9a5esm285799125e9.4.2026.03.02.06.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 06:15:52 -0800 (PST) Date: Mon, 2 Mar 2026 15:15:50 +0100 From: Juri Lelli To: Gabriele Monaco Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Masami Hiramatsu , Ingo Molnar , Peter Zijlstra , linux-trace-kernel@vger.kernel.org, Phil Auld , Tomas Glozar , Clark Williams , John Kacur Subject: Re: [PATCH v6 12/16] sched: Add deadline tracepoints Message-ID: References: <20260225095122.80683-1-gmonaco@redhat.com> <20260225095122.80683-13-gmonaco@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225095122.80683-13-gmonaco@redhat.com> Hello, On 25/02/26 10:51, Gabriele Monaco wrote: > Add the following tracepoints: > > * sched_dl_throttle(dl_se, cpu, type): > Called when a deadline entity is throttled > * sched_dl_replenish(dl_se, cpu, type): > Called when a deadline entity's runtime is replenished > * sched_dl_update(dl_se, cpu, type): > Called when a deadline entity updates without throttle or replenish > * sched_dl_server_start(dl_se, cpu, type): > Called when a deadline server is started > * sched_dl_server_stop(dl_se, cpu, type): > Called when a deadline server is stopped > > Those tracepoints can be useful to validate the deadline scheduler with > RV and are not exported to tracefs. > > Reviewed-by: Phil Auld > Signed-off-by: Gabriele Monaco > --- > > Notes: > V6: > * Add dl_se type to differentiate between fair and ext servers > * Add event to track dl_update_curr not firing other events > V3: > * Rename dl argument to dl_se in tracepoints > > include/trace/events/sched.h | 26 ++++++++++++++++++++++++++ > kernel/sched/core.c | 4 ++++ > kernel/sched/deadline.c | 25 ++++++++++++++++++++++++- > 3 files changed, 54 insertions(+), 1 deletion(-) > > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index 5844147ec5fd..944d65750a64 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -904,6 +904,32 @@ DECLARE_TRACE(sched_dequeue, > TP_PROTO(struct task_struct *tsk, int cpu), > TP_ARGS(tsk, cpu)); > > +#define DL_OTHER 0 > +#define DL_TASK 1 > +#define DL_SERVER_FAIR 2 > +#define DL_SERVER_EXT 3 > + > +DECLARE_TRACE(sched_dl_throttle, > + TP_PROTO(struct sched_dl_entity *dl_se, int cpu, uint8_t type), > + TP_ARGS(dl_se, cpu, type)); > + > +DECLARE_TRACE(sched_dl_replenish, > + TP_PROTO(struct sched_dl_entity *dl_se, int cpu, uint8_t type), > + TP_ARGS(dl_se, cpu, type)); > + > +/* Call to update_curr_dl_se not involving throttle or replenish */ > +DECLARE_TRACE(sched_dl_update, > + TP_PROTO(struct sched_dl_entity *dl_se, int cpu, uint8_t type), > + TP_ARGS(dl_se, cpu, type)); > + > +DECLARE_TRACE(sched_dl_server_start, > + TP_PROTO(struct sched_dl_entity *dl_se, int cpu, uint8_t type), > + TP_ARGS(dl_se, cpu, type)); > + > +DECLARE_TRACE(sched_dl_server_stop, > + TP_PROTO(struct sched_dl_entity *dl_se, int cpu, uint8_t type), > + TP_ARGS(dl_se, cpu, type)); > + > #endif /* _TRACE_SCHED_H */ > > /* This part must be outside protection */ > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 4ca79ff58fca..b5bb2eb112bf 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -124,6 +124,10 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_enqueue_tp); > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dequeue_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_throttle_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_replenish_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_start_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dl_server_stop_tp); Don't we need to export sched_dl_update_tp as well? > DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); ... > @@ -1532,7 +1551,8 @@ static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se, s64 > > if (!is_leftmost(dl_se, &rq->dl)) > resched_curr(rq); > - } > + } else > + trace_sched_dl_update_tp(dl_se, cpu_of(rq), dl_get_type(dl_se, rq)); This wants braces even if it's a single statement. > > /* > * The dl_server does not account for real-time workload because it Thanks, Juri