From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DB1B3E5581 for ; Mon, 2 Mar 2026 14:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461465; cv=none; b=YkEqqqc/2PuQxaJC5JskHPBeYmAGaQMvBKtOImEMC5fEuUU+kOlG8lojvZGstOt1V1TU4Lq6viHZLXiSwvqH8ipBSWDZdse9qA2UuhCX0GnEfPz6SjMqwR94hh9wYFzhUFMoS9Dp0WQUiHUgNCaE/awBeMBEowOpzCRo8As9BvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461465; c=relaxed/simple; bh=4jfQvlciuMjy/CGMW0lPybxsFeoSnX+mXDnzu6Hwbo4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pCdzvF+cmZqA7l+rMQa1d6lRdahgN/2WSlo39VzSM3gAVX8lhQTinalad7d7IEjDmNCyqq1q60QfDiB4bKqEVxwKfCoto1b12ws4C/30dDmc7i0ItAZoAtgh0a6RhVsCnU+CkdyCrK21hqtnqv/DS5G1GQDpXZsDcbUGI+kt8D4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mVodOTIX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FgzB2rU1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mVodOTIX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FgzB2rU1" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62285X4L662196 for ; Mon, 2 Mar 2026 14:24:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=PwqDGUZPNmd33w7jgDewuxkJ lTOdaUeW/d4uXiakUEc=; b=mVodOTIXEWD90WlEVZOWOk3uljMCs6H3BvJat6HV fOeljIwFQBsMIVOypR4WB90zODsSotFDnFtcxt370fiau9jb2+3Yyy2tHzJsLYao 13sYkwM3piWjg2PGH4j0SG1op17+6Kc/EraRumhzsl9OHOudJ4ZYxEkI2oNWkAay RP3hd6FgaEVo3MWfS8xG5uVbwk0wA7f1i61qJ7tU53uDEmkzBUFuXbrQm75N3K/e bDi74S9Pi9/17Ix6D2zQ1qiaFRWBDeyXDz2KxY2MmULSxqvNQW0hlfpVdORuend8 nhI37zvHYzRAHKDa4zbm6W35PhUmJpf5zZdnhSZiW+XdiQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn6r2sbex-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 14:24:22 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae53ec06b0so32364845ad.0 for ; Mon, 02 Mar 2026 06:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772461462; x=1773066262; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PwqDGUZPNmd33w7jgDewuxkJlTOdaUeW/d4uXiakUEc=; b=FgzB2rU1GJzSYqJEYihTHJrNP4dI0WrN/Kj7bVjdCBi36nbppggfawCZH93YpvjnzC UioHnrnDEE0LEQtXGkf/jsJeQoHeJnkuwiJ8GG2b2XfqeZr4TCgPwcnQhyaqoG1B7lPW p/P+789oDIiZePJChtI1cG0wRCafM5BNvKmvJHhMXu/ZcDWJxSUGzXcoKo7dPHcGXluW /rKXQFqi0sZzsxDrt+NFInh9QhPz0dRjYNLh6iKhV8mAlnb+0MZevixtGkMozFM+gT/z /R6fyNdjon0rzF80MXRsGotRyBu3mNlMtwbZ4bNhqedQT5HTskN54aG6I+CqMowAsXVm GPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772461462; x=1773066262; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PwqDGUZPNmd33w7jgDewuxkJlTOdaUeW/d4uXiakUEc=; b=Faa8RUbNA4UnkPrfxXeugZcAxNPQn0UhF/M4exr8YgzmKYYq6LnI5MwmmGz6vFvVkN R1Zo6dkUzCzTYhEVcIjcicrYlrGqxq7B4HzCUSc58vGwGh+aHpliBmDJlRu5qsJ4kNdG ArVXNSF6QuLHJzQVXOk744Qnq7/dPscLd1I9hhaj6vdABbPSYSeU+7QybFHbbd+MqJJL 7gzxWxe9Bl8i2pzitqWxsUwm6+J4qrmTw+Pj+5s/MYKUH2gTcjJ1nkuYtOmF/WcslEtc M+WbMOO9t/XYOt51MEPMBaZsQ5xNUqZhmkng9PZHH0zZAb/wJwGsVWCPOqw/mmLfEuPI yN2A== X-Forwarded-Encrypted: i=1; AJvYcCUrbRINOgPhwmzd51PinMsMP7m4VqXKmlJzK1QGtAx1Www1pl38qu5OuR9s+a4l/2nRK4Sr3GZLZLFv/g0=@vger.kernel.org X-Gm-Message-State: AOJu0YyRGvB1CJMQkzi/5JZSqia+ueU1lUFDWp526j09XytFl8YgVak9 iOnl6e4KygMHpFr0aJgL0wZBzarYx7TV/ijTXKU1Hf3zEXxdprPoXpJ00uP6TqXD50sT8ah4Yzg d/89SUqwfLOgHh+KbSRvFU9KgQPlKcA4dGDNRsOjPskhs7kj99rM98VrrSiH2JC8Qrm8= X-Gm-Gg: ATEYQzx58SdzqhiKGHS/RgWzId068A5xgWJGsnRy51hHNxlmqfLewgvtVsAtgobU/55 9npLMp6N7ExS7wqgJPcwO0QIE0W2sVnwAhgMAiiawFV86B+NnRP7THr+c5s/OPBI4phHcCSwQLD hNIZv+Q+W798JL0mCHqxBQlXQpRvoxwJYYc+qBbFeKqPnV9SujwNgFxWK/Dj9hvEE17f4NiybID UDTSUmVxrkA95tMHCsZ3tsul9M2XJXTUPnjP21QzE5YdRrVn7OLqQrIuum1UWrJp4B8p2N5irtg dMoC9WHMPMEFW4GcPUC2bmN3Mo/Ip/XMu7aiiRMaziRewX7zLVUkNlXlosjbMg+h4/O8G2IC9e7 gtARHklUpd0OjHnLg9yMdwKJIPIfPgTsuUH4cCiKvlfePLAl2kLcQzFrW X-Received: by 2002:a17:903:1a30:b0:2ae:5104:5721 with SMTP id d9443c01a7336-2ae510458bemr28735435ad.6.1772461461557; Mon, 02 Mar 2026 06:24:21 -0800 (PST) X-Received: by 2002:a17:903:1a30:b0:2ae:5104:5721 with SMTP id d9443c01a7336-2ae510458bemr28735175ad.6.1772461461050; Mon, 02 Mar 2026 06:24:21 -0800 (PST) Received: from hu-mchunara-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5c20d3sm201423135ad.25.2026.03.02.06.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 06:24:20 -0800 (PST) Date: Mon, 2 Mar 2026 19:54:14 +0530 From: Monish Chunara To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mani@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sarthak.garg@oss.qualcomm.com, pradeep.pragallapati@oss.qualcomm.com, nitin.rawat@oss.qualcomm.com Subject: Re: [PATCH 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay Message-ID: References: <20260227105055.2364348-1-monish.chunara@oss.qualcomm.com> <20260227105055.2364348-3-monish.chunara@oss.qualcomm.com> <2ra2apfephjl2au6wel25gbxoxyvohf2ysq4yzaufp3xb7mtoi@g5p6asbk2fqe> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ra2apfephjl2au6wel25gbxoxyvohf2ysq4yzaufp3xb7mtoi@g5p6asbk2fqe> X-Proofpoint-GUID: MtP9kkyY1LjxHgMq-7BqUffimyWl7h9O X-Proofpoint-ORIG-GUID: MtP9kkyY1LjxHgMq-7BqUffimyWl7h9O X-Authority-Analysis: v=2.4 cv=Hpp72kTS c=1 sm=1 tr=0 ts=69a59d96 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=37xXzHZQKsG2Q0yfkbAA:9 a=CjuIK1q_8ugA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDEyMCBTYWx0ZWRfXwZ52nrr1oYSz odVLg+3/owOW/NfP7x0fOw54+iZ8jL9wvmiXMBqxbnkaBVeTqt59M/ZrANJZXfCynuytiCzJdyy UnvFGv07C0G7O2tqla9SgWEVxwrwRw+h/UfeKbRy4I6l6jQfde+O5xNbBn0/jHGVmVB9ibWwpjH 1AC636+RdfIgqFqXsWmmwEUOhNlYcUU0cRvDsvekRvOdVgr6RsVIuNjX/TETiWouxnlUjZnLT6k O+8FRbvCvsByFWD51K5UN/pX5+EwhoT5RymflKuY416Rvno0qKKnhSI2/3SePB+vX7KbWzmmhKh x6aieRhcO2YkoX4S9cyMD0QkhxS6KGuqrduXT8ciuvk6KbtzGEYw7yS8ynHQO7lV7rYiY+P/H/8 nVsrihp4LRlBPGzpfOnQxC2rTj8Mnawpij5wjdVbYTMymwfdhZUEQhCV8u+hLwxlc5j4nwl/wtc 6jsQZyaw+ef0dta4/sQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-03-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020120 On Fri, Feb 27, 2026 at 10:03:10PM +0200, Dmitry Baryshkov wrote: > On Fri, Feb 27, 2026 at 04:20:54PM +0530, Monish Chunara wrote: > > The monaco EVK board supports either eMMC or SD-card, but only one > > can be active at a time. > > > > Enable the SD Host Controller Interface (SDHCI) on the monaco EVK board > > to support SD Card for storage via a device tree overlay. This allows > > eMMC support to be enabled through a separate overlay when required. > > > > Signed-off-by: Monish Chunara > > --- > > arch/arm64/boot/dts/qcom/Makefile | 4 ++ > > .../boot/dts/qcom/monaco-evk-sd-card.dtso | 72 +++++++++++++++++++ > > 2 files changed, 76 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 317af937d038..c86242a1631d 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -46,6 +46,10 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo > > dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb > > dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb > > + > > +monaco-evk-sd-card-dtbs := monaco-evk.dtb monaco-evk-sd-card.dtbo > > +dtb-$(CONFIG_ARCH_QCOM) += monaco-evk-sd-card.dtb > > + > > dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb > > dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb > > dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb > > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso > > new file mode 100644 > > index 000000000000..a0bc5c47d40b > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/monaco-evk-sd-card.dtso > > @@ -0,0 +1,72 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +#include > > + > > +/ { > > + vmmc_sdc: regulator-dummy { > > No dummy regulators, please. ACK, these will be renamed as per the schematic. Since these are direct supplies on hardware, used fixed-regulator configuration. > > > + compatible = "regulator-fixed"; > > + > > + regulator-name = "vmmc_sdc"; > > + regulator-min-microvolt = <2950000>; > > + regulator-max-microvolt = <2950000>; > > + }; > > + > > + vreg_sdc: regulator-sdc { > > + compatible = "regulator-gpio"; > > + > > + regulator-name = "vreg_sdc"; > > + regulator-type = "voltage"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <2950000>; > > + > > + gpios = <&expander1 7 GPIO_ACTIVE_HIGH>; > > + states = <1800000 1>, <2950000 0>; > > + > > + startup-delay-us = <100>; > > + }; > > +}; > > + > > +&sdhc_1 { > > + vmmc-supply = <&vmmc_sdc>; > > + vqmmc-supply = <&vreg_sdc>; > > + > > + pinctrl-0 = <&sdc1_state_on>, <&sd_cd>; > > + pinctrl-1 = <&sdc1_state_off>, <&sd_cd>; > > + pinctrl-names = "default", "sleep"; > > + > > + cap-sd-highspeed; > > + no-1-8-v; > > + > > + bus-width = <4>; > > + cd-gpios = <&tlmm 11 GPIO_ACTIVE_LOW>; > > + no-mmc; > > + no-sdio; > > + > > + status = "okay"; > > +}; > > + > > +&sdhc1_opp_table { > > Why? Is it specific to the device or to the chip? In the latter case, > please define a separate table in the monaco.dtsi and switch to it here. > As per the previous review, it was suggested to use an existing table. But yes, this is specific to the Host controller and the corresponding voltage corners on the chip and can be defined as a separate entity for SD card use-case. > > + opp-100000000 { > > + opp-hz = /bits/ 64 <100000000>; > > + required-opps = <&rpmhpd_opp_low_svs>; > > + }; > > + > > + opp-202000000 { > > + opp-hz = /bits/ 64 <202000000>; > > + required-opps = <&rpmhpd_opp_svs_l1>; > > + }; > > +}; > > + > > +&tlmm { > > + sd_cd: sd-cd-state { > > + pins = "gpio11"; > > + function = "gpio"; > > + bias-pull-up; > > + }; > > +}; > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry Regards, Monish