From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23A2E3CCA1A; Mon, 2 Mar 2026 14:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461986; cv=fail; b=k0iBmeYypth+rdPDVH+2RYFlLpMYcfVnf46fq0r6nUPsiULSwAEme/SybGpyxdSDaiocUivJOXOJDXjcIf4knSKwXQCwqD/s0XxZqaSq5SRVjcmVBnhbLyXaHM4fyYwg4ep3INr9YGicVra7SjwXRH93XojEHENbCe9tlELyBn4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772461986; c=relaxed/simple; bh=5GRX8mvwRZdhgVjw7ovNwN0FEHm8mgNMxOzST9oOafE=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=ehf4RZOr0Xk83gJO388m0X0dI8RviOlcQVkj+L7rb1wVaY+gJeYkDsNh7PhxLPM4g89yEORO9NL+WG2Pb8gpnFYUINm/78oGMP8mzofBq0sB4GOI6XvBK4IGLRw1U6rgfH9ukqt4HLftYa9XW7zGB1c37cxx0vh5A3ckxTYzPz8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g4tTNSOd; arc=fail smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g4tTNSOd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772461984; x=1803997984; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=5GRX8mvwRZdhgVjw7ovNwN0FEHm8mgNMxOzST9oOafE=; b=g4tTNSOdu6VAJfbVTExojVE51LvWvj/CjFyc5Cob15eVF4LVK0Hztsek Wo+j3qUpHzLKaFaz+dkhpE5Rh0Vj+GOtnsXIA0Jf1aR9o2cXnhP5/786s gI/4uaKRGriVs3MJnoiyTel/R6EJ/5QQ9L0vkgLVh99zr5PQ4J1hhsndC FseiQTWVsnp3E56z364XUvDpcUl8JMvT6Uc4Scf3YH6Sv1okfT2X3BFi6 QXtQVlmbRq0wNpfohgKoq4zxX9qsa39TqfpQb8uYBhDkpy9Vy0JgYv3I3 0QmeQvBJVv1x/XZQjOHyb/JTlv1LTDy8BhWhTKRByhUDOTs6FxyBeCHHV Q==; X-CSE-ConnectionGUID: AeXrf1CiRVOyQZMrb6jhLg== X-CSE-MsgGUID: cAD4Tzg0S4yg8lqo5woPFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11717"; a="83804036" X-IronPort-AV: E=Sophos;i="6.21,320,1763452800"; d="scan'208";a="83804036" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 06:33:03 -0800 X-CSE-ConnectionGUID: bw9EL8VVQZSiBhjelZTJCA== X-CSE-MsgGUID: m/WqfIisRym7tt5NWeFvmQ== X-ExtLoop1: 1 Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 06:33:01 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 2 Mar 2026 06:33:01 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 2 Mar 2026 06:33:01 -0800 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.31) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 2 Mar 2026 06:33:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M1BM67pV/DrfIRUzVBbZbD9RYh08XqNxdiNQxAuHKPLzscpP15ABSwDzh60jVWHz7kiRShyIHD0zTJMX6ZpStYvavjGzvMlC8/PzGEXdYRFooD6F7QYAn9eF50jv/ofPCZE+p2ZpYoFTEDanAJzEmy+V9fMjSCiQoStnFy5vOvkBFzq8Y/6xDn9l20E3FaU6tQbesd2rUSqVXyTKy999WfbyoDhJqOQPc7BQ1b+5vf2AndhG/eJ+fQ6JVsvJLFXB/XRx4pvooDZInYgtLmjS29SC+cdNffp0xy2vPeJVbYjDVLdpqlffWcn093Ki9zuvV/ORrUqSxzf3LFm3uw3xww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEejsCu/uSg1DzSpOJEFAyaZ9HJmNpYdzBFBrpNaVDc=; b=qykhG1PR/njVeEv149Mh8yQRariDIYYeNFFikVHZn/fyWURHe+vvWrIScbxOfXCJpWt0bswwJrdcDgj7adfkVrjJnKxTfUKbP9OJOyFrcdIgN9gRF+jHFafW9Zz9fI7JxkLvkMaaoxTWIBQrSdm8S52OaDG9gzMYK+a5gyOdpcJPCplB2uIitqo3l4avmYFAUzjO2Tsi6Jw6xZLUnj+uTtF3DOhhao0Iv1JAY2XFJ5y+j1WgBC/3NPWFTLu3lHqB4C5cmYSqLl8giMrCc3DclmYT689L3MzVbdGHkjtxSztZYGfpLZSUT1OcBoyZF4oS49sca1c42HtUQKuqtqbkfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SN7PR11MB7540.namprd11.prod.outlook.com (2603:10b6:806:340::7) by SA3PR11MB9461.namprd11.prod.outlook.com (2603:10b6:806:47f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.13; Mon, 2 Mar 2026 14:32:58 +0000 Received: from SN7PR11MB7540.namprd11.prod.outlook.com ([fe80::2edd:5c6d:169c:389b]) by SN7PR11MB7540.namprd11.prod.outlook.com ([fe80::2edd:5c6d:169c:389b%6]) with mapi id 15.20.9654.015; Mon, 2 Mar 2026 14:32:58 +0000 Date: Mon, 2 Mar 2026 15:32:43 +0100 From: Larysa Zaremba To: Maciej Fijalkowski CC: , Claudiu Manoil , "Vladimir Oltean" , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , "Andrii Nakryiko" , Martin KaFai Lau , "Eduard Zingerman" , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Simon Horman , Shuah Khan , Alexander Lobakin , "Bastien Curutchet (eBPF Foundation)" , Tushar Vyavahare , Jason Xing , Ricardo =?iso-8859-1?Q?B=2E_Marli=E8re?= , Eelco Chaudron , Lorenzo Bianconi , "Toke Hoiland-Jorgensen" , , , , , , Aleksandr Loktionov , Dragos Tatulea Subject: Re: [PATCH bpf v3 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz Message-ID: References: <20260217132450.1936200-1-larysa.zaremba@intel.com> <20260217132450.1936200-5-larysa.zaremba@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: VI1PR07CA0257.eurprd07.prod.outlook.com (2603:10a6:803:b4::24) To SN7PR11MB7540.namprd11.prod.outlook.com (2603:10b6:806:340::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB7540:EE_|SA3PR11MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: ef098764-7190-45bb-e91c-08de78689952 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: kxY9G7Lod25ZnJFES61FE7muJIIufcE0jLBhuBr8zJeko2niIYbNKsTFSVJk0k/TLqB5ksVnVosNvP66dDD9RgKbETz27IAc9PPwY0ycqwRPSPlcyu3p0Fy1N/fQnLTRlWWc9zeJw6oy+MhVlPDmKFCph+eFZezxV+lugDQ6l36mrc/xbky/b9a75Gk953jW4FaszvfHbaFGTESn1wwZ1VrgFbPcGJODgx+7hDVbMwpciESm8eAKntrHn34K7Ll0ejvhIhf6TWzoOwNHZbO6LzkMPsGRRmqKupTaxl1aFf7iGsWarJQjNuCUXIfoj33HWlwTeSypGajTTdC0S0MWcVxqQCsfmILDZPw6+wNcxYcIG72vH8nVKNsFqvm90+nOC2XhTpOgbia8TpktQB+hJVFFVk9HlVARMuiuOV5Cj5zoZ0efMTWbUrV9a27C5MuJx6x8F4vSFYRuMRenKVD6YwVnw8jOjRKoJyl1uhrI/9ecGmz4B/oTsMgyJngVjsgmuzy8BwjAnX8apCz4qtnDEAYea9MkZ6G19OyQBRXsMwXn+fWs3tpX0ZfEP3fHVZiLcFWQlFAoQleWmipsrOLqWL1GPHqEopokk3wGwkiV12p/hH2folrD1aEsaKpLKWrRYqttpOTNoeBOMy2XZPvArB0pqJwpPAArSz3E/2jmUakvXgkd0BdbufRrWgbkdh7S6FKQwSIXp/pEF5G41B0eqw980SEAzVKLZgeI8YnViiU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB7540.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u4kwKH8GH2EDBJSNyqlkIXYX7AKl3LhIQAvLxsMM94HxhwljOXc/JtzH5VQJ?= =?us-ascii?Q?d4wThbExqZHzifo2uu5X2UZTEp9Mq0dmUihUjlXtw2bzk4LIpel5XJQskNP5?= =?us-ascii?Q?1HtBm1xtSD5T9FmpQtmNeoyzSPqJj0EQHNTGK9nEhba3ilR7ihdRZQ4IXjiK?= =?us-ascii?Q?wiMrk4T1MiTY9S1GPbjp49jJqjx5NLBqcxzvGq/v+ZE1t7C0pntyN0AJI2z6?= =?us-ascii?Q?kpZeKyMJIM7xtt821ZOsfWx2ibWE2hVX/wHd2eOq8FxjO/OxTJZH4X1cBb2j?= =?us-ascii?Q?wQWYvWnh2mCLFzbSLjtn9IkbSQ2QtlUxARibnI/VVrAcZk4lkGaG1giaAPQz?= =?us-ascii?Q?R+LsNu1z1/gBwpb+NRnC7VJb5qp0W+XLPQrzv+Mjhp3qgRs8NOgJD8EEdRxK?= =?us-ascii?Q?wJ3srjm3jrHJpMzMKpzWotBVPCXB8dUCgMqIcyZ2yuKWVjCEfMXKd0aCnm9q?= =?us-ascii?Q?4Kb9RxWaLc98esvHttirH+SEaG5QRJpFBDUsf0pTYSviAkpUA27WJWwekGWE?= =?us-ascii?Q?2ot3I2Y+9xB3sLK6qvgmtx8NBdd3TwehFRuqaMl9ysM+XXrtjZ1tzrvoQ91Q?= =?us-ascii?Q?p2mej05lJBSecAj1604vp/at/fA+Kcdrw77Q0gD6rbaz4i77+f4EgrZI7ozj?= =?us-ascii?Q?Su9SS+YeCrSXp7DuWoYVOP6NxPP/DtBOMsVoUGBjFslLbhLH7aKCl/7kEGhN?= =?us-ascii?Q?FZfCf7Il1+DtfH20pYuHfzewi5WAgGVA/MtFZ8MPOm086BL5vQnU5YmWirn7?= =?us-ascii?Q?+EhoR5YYNgo7wvACe1zQSsJ+/JoidvFQL6J1ukg/T+6BZt2S1CYF5OikxvSr?= =?us-ascii?Q?9o5XqT7T8HQyK2/zQ5Xo+CRtMOG8jlHmst+UpzuFvMoFH/0p7VzGQTv9v+r5?= =?us-ascii?Q?f5Je8wwxUcPoezUwu1djWMeok/PaFZ4X0bjys8tb1EppKQhwfCUUqBZyrmlq?= =?us-ascii?Q?wKEi0ffbCVfYqNDYP/DmXNzWys7iryZA2K36V0ueUy0YItk2/dM5ybBTbpfo?= =?us-ascii?Q?jriqc74lR6uJJF8xgphMyynSoG3aYzQrrMt7PZTWbB5jSRrl17hMQcyreeRM?= =?us-ascii?Q?6MNlT3+Tk25WayKq1xgBdawCk7tqmBt4lIyRcOreyWUOPxaqap/i6OUD0rc3?= =?us-ascii?Q?bW3SvnqPTF/jt5bXEpVNxIb4Q02Nxy9rEG76W810rhIgELY7MfeNwbe2HDau?= =?us-ascii?Q?ldzEmkL1Vcf8cFzLSgAExOSJEE/F6Ir/WyWRdQVF9wOX+qKC4LfGQVSYOaDt?= =?us-ascii?Q?OaYnLKAjT5lQ4Q06jExmczjod1mjH7i/Y1JpCxUPShMFK+6qYqMKVROC0Sxv?= =?us-ascii?Q?o5Uc7MKcAJKgZti2sTPrXTmAEUpv91FJb4l7eZ7rUtIv0POyuc5w4dB+Ff8r?= =?us-ascii?Q?waAqjIBiiQRVzLU0MadaYm6PvuJVu5ziRqxMWN9oymGcUgTvTAsZwhM+mOtK?= =?us-ascii?Q?KOUJkKhVZbZCclvr39puhSB1XDBxF1Cp7D71s4XZlvBwzhYaqqbv1VrNH3MF?= =?us-ascii?Q?LXgdKKhZqQnsGqhnPWhB0c9iECY+WpyvIvLBgd71y/4fpWSKidHAy/sSABTf?= =?us-ascii?Q?4KFeNDIv0b22Ye3hRMvCN0Cskyr8GS+utDuDFIia1fF0O6xGFP94vf5+0mYD?= =?us-ascii?Q?UyG26N8xIi7kfkXHoEMWUeQPRTDbmK/jp24Wg/pVuUr8ZrNKfYbZTngxoZIP?= =?us-ascii?Q?xTuaWUpXYgN6X+ewQz4GLeN7n/uLwP00+kGxNdjLK1FaBc1138NCdVZBzMJt?= =?us-ascii?Q?g49kRWJPz2VLrvG54LFfEPGVb3W0WfVmuXrIguJXGqv1Mk6qpCrIdox6Ft7m?= X-MS-Exchange-AntiSpam-MessageData-1: CqSAvD2BPELR/Fm0t/WCBOrHiuh4bSU5KeI= X-MS-Exchange-CrossTenant-Network-Message-Id: ef098764-7190-45bb-e91c-08de78689952 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2026 14:32:58.0289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IWkZvP/fJ1tKaQaghNiv3uAzPZMkeEqdoGJArTMTvl85sDGg5/BA5ajsYwhM3jk7Jj/xfeMKQHNlOcbCAJWj+/TcHxN3hHySehdzI0tC63E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB9461 X-OriginatorOrg: intel.com On Fri, Feb 27, 2026 at 12:22:41PM +0100, Maciej Fijalkowski wrote: > On Tue, Feb 17, 2026 at 02:24:42PM +0100, Larysa Zaremba wrote: > > The only user of frag_size field in XDP RxQ info is > > bpf_xdp_frags_increase_tail(). It clearly expects whole buff size instead > > of DMA write size. Different assumptions in ice driver configuration lead > > to negative tailroom. > > > > This allows to trigger kernel panic, when using > > XDP_ADJUST_TAIL_GROW_MULTI_BUFF xskxceiver test and changing packet size to > > 6912 and the requested offset to a huge value, e.g. > > XSK_UMEM__MAX_FRAME_SIZE * 100. > > > > Due to other quirks of the ZC configuration in ice, panic is not observed > > in ZC mode, but tailroom growing still fails when it should not. > > > > Use fill queue buffer truesize instead of DMA write size in XDP RxQ info. > > Fix ZC mode too by using the new helper. > > > > Fixes: 2fba7dc5157b ("ice: Add support for XDP multi-buffer on Rx side") > > Reviewed-by: Aleksandr Loktionov > > Signed-off-by: Larysa Zaremba > > --- > > drivers/net/ethernet/intel/ice/ice_base.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c > > index 511d803cf0a4..27ab899a4052 100644 > > --- a/drivers/net/ethernet/intel/ice/ice_base.c > > +++ b/drivers/net/ethernet/intel/ice/ice_base.c > > @@ -659,7 +659,6 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) > > { > > struct device *dev = ice_pf_to_dev(ring->vsi->back); > > u32 num_bufs = ICE_DESC_UNUSED(ring); > > - u32 rx_buf_len; > > int err; > > > > if (ring->vsi->type == ICE_VSI_PF || ring->vsi->type == ICE_VSI_SF) { > > @@ -669,12 +668,12 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) > > return err; > > > > if (ring->xsk_pool) { > > - rx_buf_len = > > - xsk_pool_get_rx_frame_size(ring->xsk_pool); > > ice_setup_rx_ctx() consumes ring->rx_buf_len. This can't come from > page_pool when you have configured xsk_pool on a given rxq. I believe we > need a setting: > > ring->rx_buf_len = > xsk_pool_get_rx_frame_size(ring->xsk_pool); > Yes, but doing this via xsk_pool_get_rx_frame_size() as it is now will introduce a regression, due to lack of tailroom, so I decided not to touch this logic for now, as you indend to improve xsk_pool_get_rx_frame_size() for mbuf soon. > > + u32 frag_size = > > + xsk_pool_get_rx_frag_step(ring->xsk_pool); > > err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev, > > ring->q_index, > > ring->q_vector->napi.napi_id, > > - rx_buf_len); > > + frag_size); > > if (err) > > return err; > > err = xdp_rxq_info_reg_mem_model(&ring->xdp_rxq, > > @@ -694,7 +693,7 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring) > > err = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev, > > ring->q_index, > > ring->q_vector->napi.napi_id, > > - ring->rx_buf_len); > > + ring->truesize); > > if (err) > > goto err_destroy_fq; > > > > -- > > 2.52.0 > >