From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82C7A401488 for ; Mon, 2 Mar 2026 14:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772463081; cv=none; b=jiTSRbIEnWjlFEFqrcOJtmBnU7G+4sOCoeAM7QIYqbeYweWpTd1tRYFbdAA6Q9wleDmC1PTZFEYz9CNOuykyw4g2a8BT5p/t0AN8JZGo02z2ycILmWhg1S2btkT937I2LKlL8zbyJfQbBpf122sAGr9QfUo5cjS1Xyp/e+7xERo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772463081; c=relaxed/simple; bh=LMM5e/z6JriOEulp011E8XTlG6bWRkSQTYmDGlf9mQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c27vFRJauYzlDFTQ+CkUPBYWtDVgbzOzHhnPoYxdsbWwmPhJsB8wTVQrfktINEblcD1UB2hlnaoecsTq+u/lhmG0VW2v0rCx3f1STbmdOuydLXoIWLHNjfRvNv9PONNlWoWdNNXzog6MlEOYuwu3R6pfyo/ERNzhGHKKRYR2c2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 939C71477; Mon, 2 Mar 2026 06:51:12 -0800 (PST) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9FF23F694; Mon, 2 Mar 2026 06:51:17 -0800 (PST) Date: Mon, 2 Mar 2026 14:51:14 +0000 From: Mark Rutland To: Josh Law Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH 4/4] arm64: kernel: Fix style in io.c macro Message-ID: References: <20260301003407.2493781-1-objecting@objecting.org> <20260301003407.2493781-4-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260301003407.2493781-4-objecting@objecting.org> On Sun, Mar 01, 2026 at 12:34:07AM +0000, Josh Law wrote: > Signed-off-by: Josh Law > --- > arch/arm64/kernel/io.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/io.c b/arch/arm64/kernel/io.c > index fe86ada23c7d..ce27fa5d2e37 100644 > --- a/arch/arm64/kernel/io.c > +++ b/arch/arm64/kernel/io.c > @@ -17,10 +17,10 @@ > #define memcpy_toio_aligned(to, from, count, bits) \ > ({ \ > volatile u##bits __iomem *_to = to; \ > - const u##bits *_from = from; \ > + const u##bits * _from = from; \ > size_t _count = count; \ > - const u##bits *_end_from = _from + ALIGN_DOWN(_count, 8); \ > - \ > + const u##bits * _end_from = _from + ALIGN_DOWN(_count, 8);\ > +\ There is no style violation here. There's no need to add a space between '*' and the variable name. Mark. > for (; _from < _end_from; _from += 8, _to += 8) \ > __const_memcpy_toio_aligned##bits(_to, _from, 8); \ > if ((_count % 8) >= 4) { \ > -- > 2.43.0 > >