From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71904219F1
	for <linux-kernel@vger.kernel.org>; Mon,  2 Mar 2026 15:53:26 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1772466806; cv=none; b=pj2q3PwhIqTlBUcd4D/QR+TKLE9TID7Z4BvZIDLqzlt4mMimyCguNXwhbxUtmN75iS0hnuS1Oe9BLffuT4vbkBwLRm5JT0SRTtNdq7vEclX+6rBSolDCabWGFrgn0zbgp05gr7+9BFPWln/QZxYcwLXlV/GZ2GDNi6eQxas5uWQ=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1772466806; c=relaxed/simple;
	bh=3lki4m9ACKTljBn/+/7u9CsGZfEzbpHbNhJXjkcTkjk=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=sQmzqDAwZahHS8Hxv9dz1UHCQYlTRcmG1a+dH1fJzfklvD9ATtiWVV6iyY8p7nh5lHvbCscliTL8SlQvDS8GY74391rqdHvMc5uOQypYc+vI/KVDKVpe2XM0aSQycL8I1+ASgW9j4F5W/LzWPer9R81hj9nErnU4D04GUcQkChY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BcUfmaeP; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BcUfmaeP"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6324DC4AF09;
	Mon,  2 Mar 2026 15:53:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1772466806;
	bh=3lki4m9ACKTljBn/+/7u9CsGZfEzbpHbNhJXjkcTkjk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=BcUfmaePhUuQIb2wan2ORwktOm/ZgZJ7adnrXIJRgycKCLR5oBeSvgIl+EdBUN9Sr
	 8o0mOfDJe18L+dCP+ZkJqriPU/YPu+zQNAUFgUL9DAXNEmhxMVXWwCO//OyqN5hFge
	 PSd3hWgDxvzZNoYuweubq4uI1ohATzcXQarPuyoTmpM20YNlMkrOWBFNUrNrVhh4u2
	 xqyra5voehnCKfmA8m5O6B2213BSSdVgmSsPgnAG4p7NuYQ0o5/H0fIyg3XDRBRYeB
	 jDvMXikNBc953EiOQHLn1ZrSSFadZDwrZEOMVKfVmE9N05ufwXQefpD7ofO6bEgWqf
	 jnF5Y7lApuvdg==
Date: Mon, 2 Mar 2026 08:53:22 -0700
From: Keith Busch <kbusch@kernel.org>
To: Sungwoo Kim <iam@sung-woo.kim>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Mike Christie <michael.christie@oracle.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Hannes Reinecke <hare@suse.de>, Chao Shi <cshi008@fiu.edu>,
	Weidong Zhu <weizhu@fiu.edu>, Dave Tian <daveti@purdue.edu>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme: fix memory allocation in nvme_pr_read_keys()
Message-ID: <aaWycq3ZLraaG2Ny@kbusch-mbp>
References: <20260228001927.382810-3-iam@sung-woo.kim>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260228001927.382810-3-iam@sung-woo.kim>

On Fri, Feb 27, 2026 at 07:19:28PM -0500, Sungwoo Kim wrote:
> nvme_pr_read_keys() takes num_keys from userspace and uses it to
> calculate the allocation size for rse via struct_size(). The upper
> limit is PR_KEYS_MAX (64K).
> 
> A malicious or buggy userspace can pass a large num_keys value that
> results in a 4MB allocation attempt at most, causing a warning in
> the page allocator when the order exceeds MAX_PAGE_ORDER.

Thanks, applied to nvme-7.0.