From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8792264A65 for ; Mon, 2 Mar 2026 17:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471882; cv=none; b=KCTJaniQ7dElqRhITKeFkk1R8lnT8ZV+srR5rUpFubhdonxLKvAYp2Y7s4gfVp+fJf6g/yV+jN6f8qob73EVNeKdMmkdvG/sYmj9ZyTnNZHQ0x7B5RHVvJuOKO7+S0RCfxhU69KH95C9we6AgioT7duYkb8c4L9ifXXjo7Gm8XQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772471882; c=relaxed/simple; bh=D12lC4csJQFYfaVnrXcBeKcl/WifRKhBxfOY/S1dNPA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ql/ItqlU8QJXzK+giqyX4IkCmEVD1zCfRYlzV8l9TszJfKZbr1hilG/4ABKPLFItyO2WaXmh2qLvfzNUP8se4UK6MQ7lZnjOESeRFkP5PDR6DaGnb2S1ZlqIGUnDZSnk/aX04Tc0coJZS2ZKjkmb+tSqh+XbtF7XSgcrg7hOvG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=jNbSy3kb; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="jNbSy3kb" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-506aa685d62so27099611cf.0 for ; Mon, 02 Mar 2026 09:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1772471878; x=1773076678; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=km3KT83x/z2meRdGO0nHs+kZ8jQBopdFLi43GSOrfRU=; b=jNbSy3kbcsa6T70m7fFMHnZagApkEZxl0DGxtb3Y2aWKIyT8CZOC/+5vwQktcBeCIO hSHEFubJyc7JikRub/0xSSgmduscL1lipSFUzYEKb9EienHZglI3icVv82W9tw2/GwWM xanu/94zHNtzOyN6O9pZDNBpe4FfmtQfdQQnBrSVkcAkOij4Ssg1cQ6jqLgbVbrfPcBw HTQz+hZYWcTt8spHuzIOdZhL/5H6K76l4DKraufxLnD7IQCDA+8DZkfDctPyd6V7eSxF pR9mm/H/9RU/mIPkvwuzWJEdGAdCkpLk5Obzkf94LdUi02L6oSxuQ5wZl35Sm7wuREYs HZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772471878; x=1773076678; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=km3KT83x/z2meRdGO0nHs+kZ8jQBopdFLi43GSOrfRU=; b=mylw8dacrGGX8A8mSo0ksZgmUGnYjaWGY8Zq817Mm8AU5L0XML3B63GRKO7ZJHw6Kl osx8fizuAd7X/q5+vll+CfwKiGzcLwD/fGI7txO2S+bkLqgtaUtiM3dz42UN5YLnklyW qmFEqtviM9jjO476V0ybMjyPN0zVAKryuE6XvEqvpFHg2T5aXc4XPyAzfGem1g93kFMW EZIFav631qMoeOzMChzxRclyooH/JzukTccG+uIV7OeqI9uOq1q2gqHhRJfdkISZGb3S rmPNI1YSAUn/qkSFfgKRaYcjNLuPf4mr0bZtVfFXEFiMcMBzGmez2tKjwTIdklA6ivhV QsWA== X-Forwarded-Encrypted: i=1; AJvYcCWduq/dx4bBMZYSjtpviOBf3JE8cA8wh7GwIAdNLlWcmI43zDetfGXU9iMKVS2/Jt1pOvGVkXffHXoLXgM=@vger.kernel.org X-Gm-Message-State: AOJu0YzZL1usODvtGjF2FmOQYxKE94700aVgluItY9J7mVueHP6oIy9U /DtC2kkd014f/RbmuenNCkQ6hArUSYeTsFULMRgCk6klDeXilLHsp7okIJwgrVgLaTc= X-Gm-Gg: ATEYQzzPaUtw1FH05ZJSNwkK3g9OwTPm6XTT6FLd69FxMlXrE6icLItu4r2PfSR6FvO APeelhcSAh8FyyhdT+DuXRjLD2j5265wGGmX6seOgJ/0+cMI4Pmx+/R2ZJnhsc3bPKp3Ca//eoi 7t1AW5LtnmZEIipRQObuxZnBdjYRiNWEncKXlsPRq/BfPNoMF4OKNdU8ZvcVT3PbQW8uBhLWTvF 6bIGal8gJ53aYvYHrAdT0o4PilO+oaP9JRRqVpBPcPYKsdmQWcPsfYFaq19/VQULcvB7gsaKmb1 3SP9pM+penJddSBsx4wvO/p7xw5/edrdZD9IHQvvfU4ZuFsZe8rcuDnNRsPq6O7bnv6zgDdj3r9 +JO7ereWa7T6jdUb8vShIaphKzwY8pou1wtMbSwnwylFw3aFlwVDdNdC3wUksWY8a1LLbdC8RTp vl++EV3FDOxUc60j6tMl76pg== X-Received: by 2002:a05:622a:288:b0:4ee:3ece:a652 with SMTP id d75a77b69052e-5075296b572mr152534691cf.42.1772471878480; Mon, 02 Mar 2026 09:17:58 -0800 (PST) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50744ad8f8bsm113862031cf.27.2026.03.02.09.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 09:17:57 -0800 (PST) Date: Mon, 2 Mar 2026 12:17:56 -0500 From: Johannes Weiner To: Vlastimil Babka Cc: Andrew Morton , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , Mel Gorman , Matthew Wilcox , "David Hildenbrand (Arm)" , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH 2/3] mm/page_alloc: remove IRQ saving/restoring from pcp locking Message-ID: References: <20260227-b4-pcp-locking-cleanup-v1-0-f7e22e603447@kernel.org> <20260227-b4-pcp-locking-cleanup-v1-2-f7e22e603447@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227-b4-pcp-locking-cleanup-v1-2-f7e22e603447@kernel.org> On Fri, Feb 27, 2026 at 06:07:59PM +0100, Vlastimil Babka wrote: > Effectively revert commit 038a102535eb ("mm/page_alloc: prevent pcp > corruption with SMP=n"). The original problem is now avoided by > pcp_spin_trylock() always failing on CONFIG_SMP=n, so we do not need to > disable IRQs anymore. > > It's not a complete revert, because keeping the pcp_spin_(un)lock() > wrappers is useful. Rename them from _maybe_irqsave/restore to _nopin. > The difference from pcp_spin_trylock()/pcp_spin_unlock() is that the > _nopin variants don't perform pcpu_task_pin/unpin(). > > Signed-off-by: Vlastimil Babka (SUSE) Acked-by: Johannes Weiner