From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F348306D3F for ; Mon, 2 Mar 2026 19:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772479345; cv=none; b=FX4LTvUQoiWzmKAaWSOwtmUXR81q0vHQJM+sHBxwnWf9XL0k+3qThaZsY0ISRSxmyxI+qI3V6jo9WkUhH9xPVg2ZAFXv/al3+ufwfod70bA1g/ldxWlJmW5rNRehLksXiVC5XvJL3MgF+UoAuI2oSuAoUiJJ/E8Y/KKbtVfHiqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772479345; c=relaxed/simple; bh=n++HPq9GSK1d6NCmmziQ9R+W8g/qI9ryHS3y+IARRPQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BC/uXSNPVKLAfNl0YMZCRZD9aJCeUoPYLHIROupZD2dVedCT/rFPRsi8qC3oiDTQDIW6Xc2Hr0nDXq4U+nHBNcs1Dn3NM6KVYEe+jsMtfqhXDgB85N3yWn6BBueUjxHa4Ftzn4krCV1lgu5iPc44o3KJMSklfZVO6eunONT0E38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=EZBvXZcX; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EZBvXZcX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=45JV1FbUhPNRK5yswRM7EqKvKlI72dsQnxRCf/XH0b4=; b=EZBvXZcXktuQEKBGZo4Y3KHqOE sD8V1fo61T0BQ5d7LaqY1UbOP5TAlfC3FZadaKwlckt7m0THlPPO8R0mg3ohC03nme4LR/gSti2Fd cCfU04MR0yW0hlF28Mx4+czsTNjEHfbvpNWG2qJoqiGIARAOQkzTWTb7o+k4b1tG9042Ocb+rgSUQ gP/91jaSUoAtM/1BjqTiC7kzu3WJ3jcYNYzBZ/CgA2VmGdn3/grfN0glXE6S25qGdO36+3TYbvAIK gb+1udmIv6hF8ARXb/7QAr4lJnE1EZ9HeF5KN39uXXGhVdDjUMqLIaxQFHOA39iTWMfF8TYEDpnh3 479QazCQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vx8qQ-00000009y7O-3LOX; Mon, 02 Mar 2026 19:22:18 +0000 Date: Mon, 2 Mar 2026 19:22:18 +0000 From: Matthew Wilcox To: Alexey Suchkov Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexey Suchkov Subject: Re: [PATCH] mm: initialize 'seq' in gup_fast to remove -Wmaybe-uninitialized warning Message-ID: References: <20260302191237.34375-1-dywoq.contact@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302191237.34375-1-dywoq.contact@gmail.com> On Mon, Mar 02, 2026 at 10:12:37PM +0300, Alexey Suchkov wrote: > The local variable 'seq' in gup_fast (mm/gup.c) was declared > without initialization, which can trigger: I was going to look at your patch to see why it's wrong, but it contains so much gratuitous reformatting that I gave up. NAK.