From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0373126D0 for ; Tue, 3 Mar 2026 06:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772518215; cv=none; b=bGSIkliFdP5AEJcyLLvA8TWWjnDB5IlSXbYMmUBTjWhgTWynYWQsdJFXUF6uOpEkFnE8l0zeVfwUJaOPhlQF/vNevNo5pLLG/xwPyRo99Pnq4VEsJirxNk9d3gOR+nYtlmAEG9F4BolKL7maDyMcD7ZxgalHVnpaaw/yL17EThQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772518215; c=relaxed/simple; bh=SBUlTQM/k/oaoq9AFG5lgGcmckMWOpkInZrP64wFkWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QMTCUoZdwwcT24Gvu1YPc46i/PcWoOFz6brMTHsz5yTKTS8T2wxE+/6kCvRM9jStEHUiIMvro7G5EWFMDbOZ0t3WQs63UV7QP1QRR0NiUMRqbFX9E2kaVx/t/RjVvt74+LRLFooJN6w1v5SdT4bbXdVkY6b/s2GnKg1dk9BvFGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SwVOpKXF; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SwVOpKXF" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48375f1defeso39046245e9.0 for ; Mon, 02 Mar 2026 22:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772518212; x=1773123012; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=agdeMP/mPPxcor187RCcOiWV/lnGJfdYFzdOQY3zhOM=; b=SwVOpKXFRiaWznrO4wNJ6J12M/HIBmR6lN2xAArMwcZBz3dxYHhOVhWx2KYYPq4AI8 vTnPqEQ1MkmIjnyPzACMYTIRVrWsXCqqBme7ECvq6fhsxkyny4uYF2OuYYaj8KxEs/Pc ZJXvx1fw8lReMKpBNKaD9djTU2LgpeC0KKM58kcPHljNWOrvv7Idzv8qYHxQhYP8ngOB KzZM87sJ+1OlJyuVte/rOPUDlU/QnU8UXLhPAnRVTVpwfxoxQ5VRVLTXHH0TOPXgIKUc 3aBDQxIL/i3Eg+cDxbNKF6fSLoHPe41r+pG1lMOm2GNtnVh3xERpcDu/9PP6Tm0J7c82 1Odw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772518212; x=1773123012; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agdeMP/mPPxcor187RCcOiWV/lnGJfdYFzdOQY3zhOM=; b=lIQpeTHrluSd+yqhwBY7XBgz80jLZeL95TaVZb5EWzLojtcrpPyD7oOXbPgFi4TkfE Bg8GyAMlNeslUHK2jpH2fsy15vfI0kcQqdv4tIDyyfm+/Lf4xAkYidXDJogKMvgQtwqX FgTF936kexGbNEjhj1oolrwZLYptNv+Kwgblzmrwb/yvpe3wvIZR3R4eGJGzGUy4wF7T 2zVBvywWQDfY9ZxSZ+osiBnJUDNthgPhAkxfZ4kjXGz7OIF2Ssbcqob3Y+piIaIcTUPS K/ITodnTLkpaT00spChhCpVT9tQ9gRiJ5hXysEkMUJnZN52iD5OG9S4r6ZzDMc0XQlER Vqgw== X-Forwarded-Encrypted: i=1; AJvYcCWT1Aeqrw2hQduIAy30t8/8wZtWMpgZMqiXTjfcg+N+Eanvr+9q7vYIxRnKQEvfLjuTT/1ZjtTeffUyUtM=@vger.kernel.org X-Gm-Message-State: AOJu0YwgAbsAfxrjqp5kqs5UvIrFqI/OBBq8G3OZrgUcBh8nwUCxd9c0 uxQ7BNfZxlNQ2WoBqWn5jUkQK4O/11/3eQXSNAXDYEA3eCSVPaOpbwTMaVEBEGESC78= X-Gm-Gg: ATEYQzzUMdCLMpwORUrjFpW3ON4MabWij//5njVRx1SHSIcqT1ifkTxSu/8BTadiJMM U86ktGVV4jH+UmRliorCmVEO/KGXC0OOANFK6LmV2Gqy/GAxNTlzG49U74rnNxsgT/SOD6XDark 5bIekJ4Hx1qGav7cfWxYKAnai5VruVbKAkQxUe47LnSGFLQZU2qsJ5xM8fXcnfk6pdgAfMQRiJB E5U8tgcun148hx1f3bVH2AbpwynHzfHlkGaiw9PzfNt1AGem0YTTKBWB5bDpqB0TGsvJR/eAotr Q8Q7RRWe1mrHn9bUZ9VNg3fTyBpudOv58mKYQLmbrgBZgoqB9+tQSv7tm6YyTNr6PvEq2LVttZK laZTGYaiamNN+PQQDUg1CZJqcrfVXOjKe9Zr2hXpyaOqOx3LuroJ0hDyaVTCBEh7sopvM1iUxgH Vvlh+pRHCuvrgDxUidfgQUBzZFsoqs X-Received: by 2002:a05:600c:a4a:b0:477:5b0a:e616 with SMTP id 5b1f17b1804b1-483c9bb7c31mr260224545e9.5.1772518212456; Mon, 02 Mar 2026 22:10:12 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b84023sm330050875e9.12.2026.03.02.22.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 22:10:12 -0800 (PST) Date: Tue, 3 Mar 2026 09:10:09 +0300 From: Dan Carpenter To: Josh Law Cc: Greg Kroah-Hartman , Ovidiu Panait , Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: Re: [PATCH v2 05/10] staging: axis-fifo: improve IRQ handler Message-ID: References: <20260301214815.2628942-1-objecting@objecting.org> <20260301214815.2628942-5-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Mar 02, 2026 at 03:55:36PM +0000, Josh Law wrote: > 2 Mar 2026 08:14:53 Dan Carpenter : > > > On Sun, Mar 01, 2026 at 09:48:10PM +0000, Josh Law wrote: > >> From: Josh Law > >> > >> Return IRQ_NONE when no interrupts were triggered to avoid spurious > >> interrupt storms, and only clear the active interrupts instead of > >> blindly clearing all interrupts by writing 'intr' to the ISR instead of > >> XLLF_INT_CLEAR_ALL. > >> > > > > Is this something you actually experienced in real life?  The commit > > message needs to be clearer about that. > > > > regards, > > dan carpenter > > Hello Dan, It's just code optimizations, making it cleaner, etc, I > also ran all of these latest V2 commits through check patch, to make > sure they are compliant, I own this device so I hope I can be the > maintainer of it one day, I'm learning this Linux system day by day, > so I am sorry I have to annoy a professional linaro dev like you haha > I don't mind reviewing patches. The cleanups are easy to review. In this case it's a behavior change and so I would want a clearer picture the motivation and of how well these have been tested for that. regards, dan carpenter