From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F5113A4F2A for ; Tue, 10 Mar 2026 09:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134725; cv=none; b=oDQTgxgVijJwInnzmk6V9LTQae7Htg9BsumU8Vp+amdWyANd1UJtMqHv+4RLYCgSP6ky9XtDaBcXvwMCPGV+Rc6ssxHIFDLaTEhyYbJK8Dequtz09CNcwxYLWfayri+Gji9bbsmzajKojZUGJjDEKDOUynYef2PBm7cFrBMSrCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773134725; c=relaxed/simple; bh=zgeuqfwH1RMXDtuXkgPogtnnY6LRwXDN+uCdc5XzBxE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zz1VvRAO6228+xAXBDqFr4F+ToUDyoHT9Yi5eGNQmcQ2KGfN+76vJQyy/DjDdiMS5sGuHf5/6B5ge/7C3jS4WhQOdiDttEe27QzQwDcfxifwLaJGoBvdSoqV9gh4DGd9yeonsygo/OPUcPc/64WYNqDYXQZiFGiYCp7mlim8BK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nWwwgL0K; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nWwwgL0K" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso11430665e9.0 for ; Tue, 10 Mar 2026 02:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773134723; x=1773739523; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pURy18WRph5P6M8o2xJ9EbetJ9xY8Ah782hTM5xM1b8=; b=nWwwgL0KDqSQ0EBy4Nq0GhNafl90R2W2Op3ajUVHctHzs5JHm+V1/L+cDGC5YwkRug 4CtJTux3tsFPVOHI9aJz8uc7TWw13yVHqySdwBEX5co6Tntnv4A5KFA9xDaWJE41iAn5 PEX5pJnmLOgCbrhA/GBFcYoE1TgjoPyoaQXoUoGP4+EI97i2C3gA/Jdpj1G0gh1mOm60 8CjzhTNq1J7NXp2jj7Kmfhhjwz43hFpRdgKKKbvTkWI81gwiNvSppUe3IbQSgxuq4QHC lptoTQGpjsmFXujWQPLAwJ735788AZu0rR5opGEB4LZ6MotN/YudqPk5K5hlOR0sYgWt y5hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773134723; x=1773739523; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pURy18WRph5P6M8o2xJ9EbetJ9xY8Ah782hTM5xM1b8=; b=vdXf4pBj3lVfnuMlnDLh1OKiQdhEhjn7jqHvCdW90QFLBNjLROGVgV3EPDk2EoFegA O8jUazxr3EC7bmJIrbJTVuz3V7s8YO4yGevxm9Kl0ln0cjMoKXcd5iiAeQzIhdI0uXO7 PJ1ieR8lqVAOV7Xj3CrKCuWRwcLBVB5XNmymca5D9B74Jg0AiHoOQDjFuauJozdGrdA0 ymWxWnwZ7l4omLxirE8SmRddbEQBLoNarOoVagOw0O8NQOky9BtNNB2o5qDEssrJUvlx 8NS1KKK4DWaqxF11v7UIpeg0oP48vQhnlJJ1xvbC5s93QAjGlsToLzPfZAeprpRpuZ6+ DBxw== X-Forwarded-Encrypted: i=1; AJvYcCUtRjkPkUm4CEZNE7wQXljrpWDE8hv0q0UNYIlEpN+yu9yyA6ooGWSsX4nkx4dKnDGNwiI72LPL6YF6XsA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo3XkkBtFeofeHQEKa4lS9YnP4eXYySzAYgWT7rCTzOQESdxwB h687L2GxHfCIVHMg4cnte2qpKvDjnPa8PMumk2OdL2ZqD1QRneQuczbfCzjgRql1E78= X-Gm-Gg: ATEYQzzS1IQoYepcLe+isP0cgoRZjUpfc5mnNsSx8Xq7omQOo//61kSd6n8Ek43Su6x kZxuC/u8/shUkLDXapulRn+G9Ux2G3Hcw8juv5llreqZh0r/67MrMHp0YpLffcWEUm5MdXGRsWX h1t7VYSpc7a5EKlzlLWp7dDXK3avL1UtQWAqY5HihvmxWVSt1QulxOY/NOswgmnckpB8R00XE4R bmDGD4lEd8l2tcME+qPJ+Mn8E9b+mzexpkTkJBrTQSAgVpvxptOcVAoNuiiCUj0J6NSrF8VZIoo spg2nT/3ZcOijrGHYWfqNCeBngihZ9KKt+4IKxgUUDtZ5iVbC1UtxktsM19UG0n5VyVnsD0O7T3 Iw1Eq3rCa35GogiA1QDYw6i09L8YHawKla2wFoSK9UNIM5BGn7/E/Zgw/jcY/7ZWS1H1AKEkZqU bf6i377nqKzMmrym2eg/JKiO6k/Nfv X-Received: by 2002:a05:600c:1382:b0:485:3423:727d with SMTP id 5b1f17b1804b1-48534237536mr151744995e9.26.1773134722526; Tue, 10 Mar 2026 02:25:22 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541a7f1f5sm108748215e9.4.2026.03.10.02.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 02:25:22 -0700 (PDT) Date: Tue, 10 Mar 2026 12:25:18 +0300 From: Dan Carpenter To: Gustavo Arantes Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: convert mutex_lock/unlock to guard and scoped_guard in rtw_pwrctrl.c Message-ID: References: <20260310084806.34265-1-dev.gustavoa@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310084806.34265-1-dev.gustavoa@gmail.com> On Tue, Mar 10, 2026 at 05:48:06AM -0300, Gustavo Arantes wrote: > Replace simple mutex_lock()/mutex_unlock() pairs with guard(mutex)() and > scoped_guard(mutex, ...) in rtw_pwrctrl.c, simplifying the locking by > using cleanup.h guard API which automatically releases the mutex when the > variable goes out of scope, reducing risks of missing unlocks on error > paths. > > Signed-off-by: Gustavo Arantes > --- We're only doing these conversions for new code or when we're fixing bugs. regards, dan carpenter