From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A711D7E4B for ; Mon, 6 Jan 2025 09:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736154615; cv=none; b=R+lgsgbl7Xlu1osenf2iiA5BUYhertId11xUfRRrKHa86WECp9/hK58IBgrURMMZtI2RxhTDFLchMJtIKs37+UJbzg6w8HC23Nc16AfZmXyuXaklK+mneAtMX8ApmkrBWlcN0rkh5ec8v4Ipuu5SiiS8HZGFnXqVPeKlm1Fodzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736154615; c=relaxed/simple; bh=IqQSZ4DIsbSb4L2V8YQ2RZyiVYA0wVhx3b1J6GY4zdw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hJUZA8fPdwlqDxZ39a5UHPs0ARHP6WrEB7ULM/unjZYVDWhfy8Fg9oG0P6BDowSYjc1g9w42nkPChTAEJyzcu8iNgH/PIWPpyJRWPO8/LrHnqe4plYvf/H/DjOKyUCfu49BYKBwU5QeMtBDclqXUWO8+efTYtjOkB2S7hSSAiMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ueZdYo0s; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ueZdYo0s" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3862a921123so9525120f8f.3 for ; Mon, 06 Jan 2025 01:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736154612; x=1736759412; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kDNEsUfow91uTBH4QnhATUdWKOFKIni6Sk4yAbrFDmE=; b=ueZdYo0sg4GhPtsXbmD/qwclGeWhG3blbxBPilYH62am2ErlsdvbxcXWJFJVz6uj4b WXKLKXesl2+om0YJo4nqWb/23/0codepi63woP0zwGRV59TKCRlJW5x4LzuhyqmMRa2d WQvJhU0NY0jZU100nR6Th+4na6HO10I7MIr+RP5QeQM4aIS0y9kx1RmILoE5rY+Vv2Z3 BbvO6meMKjtz29J5TIrzbGVT+Ib6ridoKWPz1lLk4wPM7PAdXgQIvz6j/+J+4aP3TL78 aJZqrpH5mZLVhBT2QRVMHc+Le9lla1GyoelcVDLy2Ki4xDd1Sea45elzj6sgO5E5FYuk IViA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736154612; x=1736759412; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kDNEsUfow91uTBH4QnhATUdWKOFKIni6Sk4yAbrFDmE=; b=B07E38gmTLMfWZNlTiF2DetNwuNSmhltoMwXxBi/AzUzwCBa7unObLNWMq4t07bR9L FO+UuSbktu8qZ09MfluBjtFZfT3PmTodaiI0OGQxMDEhMlwl+6Jkj/mIXwnaryyUhTgT oyWpc500npGSPN0sCVCwN0gsz70ZrBv3YcSuyEKBQ5crlW6s9aIDTOnzNEoyXcmzOV/R ewdambSTeTM4bcLw9+qkeFhPDiotsJ8APlnh7fYPmWdDleHsm8BySxIVNa3+vC6iHeT9 O135B2iuyKBnPMf8z/aviWscypbcBNWVoEX2Yp95Pq3fG9HMaH1IZi2SQI3mjbv8T00O w9QQ== X-Forwarded-Encrypted: i=1; AJvYcCUOY0pC4TOI4MyOprFwwz8DhreO8BRjk6cOGLnAf/QotTGVz4xfKMUTgRRhsz2jHNNfeKnfYJITjJ6z834=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6XCPHndDYh1fm4dz9AjvEVKt2iPrW8aK7SxYLO57mx75apxxQ Ej6Y0P3anf09uokexV2/3pix0izqF4StO/pc/Ofq1vZtr7QJai0ORKMJCWCRjcI= X-Gm-Gg: ASbGnctAIvVymu6lGgAA0QWI7Z4GTxwrszsJGm4G1x8F2oDH1WYsLNS33V1IP7z6Zyx dQVrYBSTUqdktB8VhoThyZ5xiBcTlRrOUe9thuQKimZmrcAjYOp2qCoHEInr+6P/+1rEYIBwdXL aX+kg3fCSm7f23hQdafOzgFsmB97qYlV/KSogVFwzRfxjz1qcWBcgyQ2FZnb9x9BqnIfgKBudDA 4xNy1JKu3ykLhrrFCGkp/zwopueYgWrT/ZmdjzPW0aJ+EsXhveUkwyuhJydV//3 X-Google-Smtp-Source: AGHT+IHf0Kjy2F3wCk6C6D+WwXbOXA3J5Z7TYC7UuHxWyQDK+Pm2Zk/Zqy6o60oRO45YkwwQY81zIQ== X-Received: by 2002:a05:6000:4024:b0:385:f349:fffb with SMTP id ffacd0b85a97d-38a223f5d8cmr44100326f8f.45.1736154612545; Mon, 06 Jan 2025 01:10:12 -0800 (PST) Received: from [192.168.0.14] ([188.26.61.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8288b8sm46989269f8f.11.2025.01.06.01.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 01:10:12 -0800 (PST) Message-ID: Date: Mon, 6 Jan 2025 09:10:10 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] dt-bindings: soc: samsung: usi: replace USI_V2 in constants with USI_MODE To: Krzysztof Kozlowski , Ivaylo Ivanov , Rob Herring , Conor Dooley , Alim Akhtar , Sam Protsenko , Peter Griffin Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250105160346.418829-1-ivo.ivanov.ivanov1@gmail.com> <20250105160346.418829-2-ivo.ivanov.ivanov1@gmail.com> <56e13a29-c087-4fe3-abf5-ebbad28ddfdb@kernel.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <56e13a29-c087-4fe3-abf5-ebbad28ddfdb@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/6/25 8:50 AM, Krzysztof Kozlowski wrote: > On 06/01/2025 08:41, Ivaylo Ivanov wrote: >> On 1/6/25 09:36, Tudor Ambarus wrote: >>> Hiya, >>> >>> On 1/5/25 4:03 PM, Ivaylo Ivanov wrote: >>>> +#define USI_MODE_NONE 0 >>>> +#define USI_MODE_UART 1 >>>> +#define USI_MODE_SPI 2 >>>> +#define USI_MODE_I2C 3 >>> USI_CONFIG register refers to the protocol selection with USI_I2C, >>> USI_SPI, USI_UART. How about getting rid of the MODE from the name? >> >> I thought about that too but I believe that mentioning that these constants >> are for mode selection in their name is generally a good practice. Let me know >> if dropping _MODE is really needed. no strong requirement. > I am fine with both, MODE feels a bit more descriptive indicating how > the USI should be configured. Fine by me to keep MODE in the name. Cheers, ta