mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"
Date: Mon, 22 Mar 2021 15:09:19 -0400	[thread overview]
Message-ID: <aaa16b38-6de3-7faf-e4d3-31a7b726d4a2@oracle.com> (raw)
In-Reply-To: <20210317110401.46322-3-roger.pau@citrix.com>


On 3/17/21 7:04 AM, Roger Pau Monne wrote:
>  
>  	/*
> -	 * Clamp the amount of extra memory to a XEN_EXTRA_MEM_RATIO
> -	 * factor the base size.
> +	 * Clamp the amount of extra memory to a EXTRA_MEM_RATIO
> +	 * factor the base size.  On non-highmem systems, the base
> +	 * size is the full initial memory allocation; on highmem it
> +	 * is limited to the max size of lowmem, so that it doesn't
> +	 * get completely filled.
>  	 *
>  	 * Make sure we have no memory above max_pages, as this area
>  	 * isn't handled by the p2m management.
> +	 *
> +	 * In principle there could be a problem in lowmem systems if
> +	 * the initial memory is also very large with respect to
> +	 * lowmem, but we won't try to deal with that here.
>  	 */


This comment looks out-of-date in light of deprecated support for 32-bit PV. So I think we don't need to revert this part (except for the macro name).


-boris


  reply	other threads:[~2021-03-22 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 11:03 [PATCH 0/2] xen/x86: alternative fix for XSA-369 Roger Pau Monne
2021-03-17 11:04 ` [PATCH 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Roger Pau Monne
2021-03-17 11:04 ` [PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" Roger Pau Monne
2021-03-22 19:09   ` Boris Ostrovsky [this message]
2021-03-23  6:43   ` Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaa16b38-6de3-7faf-e4d3-31a7b726d4a2@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®