mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Abdun Nihaal <abdun.nihaal@gmail.com>, linux-wireless@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Kalle Valo <kalle.valo@nokia.com>, Kalle Valo <kvalo@kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	Luciano Coelho <luciano.coelho@nokia.com>,
	Luciano Coelho <luciano.coelho@intel.com>,
	Vidhya Govindan <vidhya.govindan@nokia.com>,
	Vidhya Govindan <vidhya.govindan@vvdntech.in>
Subject: Re: [PATCH] Fix memory leak in wl1251_tx_work
Date: Sun, 30 Mar 2025 13:04:17 +0200	[thread overview]
Message-ID: <aaa4ce64-db4a-49b7-8725-4514c0a52e0b@web.de> (raw)
In-Reply-To: <20250330093556.22417-1-abdun.nihaal@gmail.com>

> The skb dequeued from tx_queue is lost when wl1251_ps_elp_wakeup fails
> with a -ETIMEDOUT error. Fix that by queueing the skb back to tx_queue.

* Please reconsider the distribution of email addresses over recipient lists
  once more.

* A corresponding subsystem specification can usually be helpful here.
  https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/drivers/net/wireless/ti/wl1251/tx.c?h=next-20250328

* Would you like to append parentheses to any function names?


Regards,
Markus

      reply	other threads:[~2025-03-30 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-30  9:35 Abdun Nihaal
2025-03-30 11:04 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaa4ce64-db4a-49b7-8725-4514c0a52e0b@web.de \
    --to=markus.elfring@web.de \
    --cc=abdun.nihaal@gmail.com \
    --cc=kalle.valo@nokia.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=luciano.coelho@intel.com \
    --cc=luciano.coelho@nokia.com \
    --cc=vidhya.govindan@nokia.com \
    --cc=vidhya.govindan@vvdntech.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®