From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967115AbcCQQuy (ORCPT ); Thu, 17 Mar 2016 12:50:54 -0400 Received: from mta01.ornl.gov ([128.219.177.14]:28436 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031178AbcCQQuv convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 12:50:51 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.24,350,1454994000"; d="scan'208";a="123961110" From: "Simmons, James A." To: "'Arnd Bergmann'" , Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman CC: "devel@driverdev.osuosl.org" , James Simmons , "linux-kernel@vger.kernel.org" , Andrew Morton , "lustre-devel@lists.lustre.org" Subject: RE: [PATCH] staging: lustre: really make lustre dependent on LNet Thread-Topic: [PATCH] staging: lustre: really make lustre dependent on LNet Thread-Index: AQHRfkQ3r1amTFivr0muJttF4M3cQJ9d3QDA Date: Thu, 17 Mar 2016 16:50:48 +0000 Message-ID: References: <1457995886-1592279-1-git-send-email-arnd@arndb.de> In-Reply-To: <1457995886-1592279-1-git-send-email-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >A patch intended to add a dependency on LNET for lustre didn't >actually do that and instead allowed configurations that contain >lustre with lnet but without IPv4 support that subsequently >fail to link: > >warning: (LUSTRE_FS) selects LNET which has unmet direct dependencies (STAGING && INET && m && MODULES) >ERROR: "kernel_sendmsg" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! >ERROR: "sock_create_lite" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! >ERROR: "sock_release" [drivers/staging/lustre/lnet/lnet/lnet.ko] undefined! >ERROR: "release_sock" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! >ERROR: "kernel_sendmsg" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! >ERROR: "tcp_sendpage" [drivers/staging/lustre/lnet/klnds/socklnd/ksocklnd.ko] undefined! > >This adds the one-line change that was evidently missing from the >commit, doing what was intended there to have a correct set of dependencies. > >Signed-off-by: Arnd Bergmann >Fixes: b08bb6bb5af5 ("staging: lustre: make lustre dependent on LNet") Thanks for fixing that. I was surprised that select didn't manage the configuration automatically. Acked-by: James Simmons >--- > drivers/staging/lustre/lustre/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig >index a09b51ce8265..8ac7cd4d6fdb 100644 >--- a/drivers/staging/lustre/lustre/Kconfig >+++ b/drivers/staging/lustre/lustre/Kconfig >@@ -1,7 +1,7 @@ > config LUSTRE_FS > tristate "Lustre file system client support" > depends on m && !MIPS && !XTENSA && !SUPERH >- select LNET >+ depends on LNET > select CRYPTO > select CRYPTO_CRC32 > select CRYPTO_CRC32_PCLMUL if X86 >-- >2.7.0