From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DE829B79B for ; Thu, 19 Feb 2026 18:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771526066; cv=none; b=Wg688Ru/sldfbdLWt9zmYS9NBAQ/CvvQH2VO2fhDRmOxdVkrBcwoD+kH69nGu0cgXfiHW9uDCKV4yLlgJb7Q+DxKmLX0GylSr5RTcCwbfqoyrtREUDtnAFaLqHFVa/UAZZFB3PZBSAaKS9x86Cy2UJvjLAvrXXCfyOI4Ew105sk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771526066; c=relaxed/simple; bh=/cXUjcOd+kErNrPTjiVVBCTZgVs0OvwULbj3tOroGFY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=J8pxB4tSxLS6d1CIOflvR3qWRn8U4UjyYax99sY9GOBFtXCvSFnKIy55eAkv4ze2kmuON96sd8DVW5nQJ9cLen3s/kwpyoeWpYf4OUEprh0due/ALXpSNXzpXihfx8ufMC1VWuW4AhQPUoRyJo61TKXyFH2EkQrTPkvJyRs3dEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FyqMoGmq; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FyqMoGmq" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4836f363ad2so13163955e9.1 for ; Thu, 19 Feb 2026 10:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771526063; x=1772130863; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=74L1/9kucXFOpe5XBjlmRi+rxlXmcUL+KeATsrwiiYk=; b=FyqMoGmqmolqcj7t/fDeCYX9kOsyDXe8HW+Sxz+gu7bIrmUFQvqBVV6U94RjxUTYiC EIfIj3QrIH6DyctbeIc+6SQxkJiljvB1B0XISs1iAH8gmSgXscH5IqSl82FNPr7OMfdE 5YSQRYpx1DiYWayWGI/eqJP4b+LI7ybffUNqjT63uQ5v2onxtpluFYKKqPiebJQx2Xcp swydWyHQdR6+8vpX1CJ3YjzW1aSPH8jwl6bdsgjS2qe/9yFQXtzhZl8RNZjEjE0megg2 yTBUkdGgVCb/Mgn0lJDoOITysNwshejNn6/GTiwphnzcK6rS1Ht39P9v2m0iSG01op/0 07Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771526063; x=1772130863; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=74L1/9kucXFOpe5XBjlmRi+rxlXmcUL+KeATsrwiiYk=; b=iI3z1Cbyjv2lPbR6lrIbOEcxo2s/91YK/U1z/tEo6gM79VWFABC/b/I83JYvqVw2fn z+udFbdVNJnnZ3b7CGjZWva9KU5nMgbWxdcaCsvpqA7+G1eKrgJYet0oh0ILQd93TNW4 XFthDU0L3jhEl9DYLUDDD/i0HbDtFDBm3ItiKZr1Jtm8824VWEcQVufQpYFhIYqwtozV Xwp1/ytTWLxKWppm+mfky0VBmrth8DLMlUou6u05MASPtRC/TbVJXipNin+xDkgWbVJG caJu05jgfmVn5xybhf5mz8aKEaa9XKvGfYKrH99BuWvynKhkbXNMnt3R+Vb0dGD3+ZWr FDPA== X-Forwarded-Encrypted: i=1; AJvYcCUG/PuWhPD2CDulmlD2ScTv1rPy69BIYdWAAVtT6OOZiDmcYQZLIPSY5uEAd4rmQ1KhRtheKarBap5gk+U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5ocT3ht1iBt/3NdDOk6M0LBQS6Shsyry+ZclCYqv65zCwNZ64 ekKIETobbZheIkSoQOv/dzGOXnW4X+U3tKuLpuz8v/zRtX+QBmODuY5yc45m5IuemeQ= X-Gm-Gg: AZuq6aL9GUM+ydvhfY+nDr6bM3dbwU9IUh7ALXIOh+HDzJ6ZpeZ5kKDLJ7MgXN3XL2w zhKLhZ6hpnKEHJZ1ZGn+9XBUjtheDdtvZtyXyXzTT9GrC1510GsJ0HNDR3NV+1hg5IACPDXsvXD 1irb/lQd7qHgPj+YhpVB1Xu8jSXHyKvje4rIC2+GTnmZ6t+Mr6IKyDTgIc/MmseDHyO7929AWn6 GYOUrri+jxAW8KwLR6iy2JUf1CIHUCH8ghai01YL5QZpyWerplTVIcwuTQgxO8tesphOn8hiAvZ 3x8DFnHNYuewmjV6AYNTHhVgveD/9aF48fcwHHhYy5+FRaedgGQuaMJBPzfeCNVaNNhPEokC2bt T/kwa/0Nnph5XeS3cqbw850Sw7CO2VfM9nyfmvCXMsgpX1MBwH+Fc4Gv3Qo8dGhC/Yk4vINA24D 88MJeIhv8ncGUkHlZp2iP+cqiY7K6cVWFZ08mEHd/WK0iJuP2wch2cKnsX1HCgyw== X-Received: by 2002:a05:6000:2002:b0:436:3563:49a6 with SMTP id ffacd0b85a97d-4379791b730mr38159124f8f.43.1771526061845; Thu, 19 Feb 2026 10:34:21 -0800 (PST) Received: from ?IPv6:2804:5078:822:3100:58f2:fc97:371f:2? ([2804:5078:822:3100:58f2:fc97:371f:2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a74918sm50419054f8f.17.2026.02.19.10.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 10:34:21 -0800 (PST) Message-ID: Subject: Re: [PATCH 1/8] printk: Rename struct console_cmdline to preferred_console From: Marcos Paulo de Souza To: Petr Mladek , John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Chris Down , linux-kernel@vger.kernel.org Date: Thu, 19 Feb 2026 15:34:17 -0300 In-Reply-To: <20260206165002.496724-2-pmladek@suse.com> References: <20260206165002.496724-1-pmladek@suse.com> <20260206165002.496724-2-pmladek@suse.com> Autocrypt: addr=mpdesouza@suse.com; prefer-encrypt=mutual; keydata=mDMEZ/0YqhYJKwYBBAHaRw8BAQdA4JZz0FED+JD5eKlhkNyjDrp6lAGmgR3LPTduPYGPT Km0Kk1hcmNvcyBQYXVsbyBkZSBTb3V6YSA8bXBkZXNvdXphQHN1c2UuY29tPoiTBBMWCgA7FiEE2g gC66iLbhUsCBoBemssEuRpLLUFAmf9GKoCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk QemssEuRpLLWGxwD/S1I0bjp462FlKb81DikrOfWbeJ0FOJP44eRzmn20HmEBALBZIMrfIH2dJ5eM GO8seNG8sYiP6JfRjl7Hyqca6YsE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-02-06 at 17:49 +0100, Petr Mladek wrote: > The structure 'console_cmdline' was originally intended to store > details > about consoles defined on the kernel command line. However, its usage > has since expanded; it now stores information for consoles preferred > via SPCR, device tree, or by particular platforms, e.g. XEN. >=20 > The current naming is misleading as it implies the configuration only > originates from the command line. >=20 > Rename the structure and associated artifacts to better reflect their > current purpose, for example: >=20 > =C2=A0 - struct console_cmdline c -> struct preferred_console pc > =C2=A0 - console_cmdline[]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -> p= referred_consoles[] > =C2=A0 - console_cmdline.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -> c= onsole_register.h > =C2=A0 - c =C2=A0=C2=A0=C2=A0=C2=A0 -> pc >=20 > Additionally, renaming the header file to console_register.h would > eventually allow to decouple console registration logic from > the monolithic printk.c. >=20 > Finally, renaming the local variable from "c" to "pc" helps to > distinguish > it from struct console variables. Note that "c" is used for struct > console > in some code, for example see vt_console_device() function > definition. >=20 > Signed-off-by: Petr Mladek The renaming is very welcome, since it was indeed confusing to distinguish between console_cmdline, struct console and whatnot. Acked-by: Marcos Paulo de Souza