mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sui Jingfeng <15330273260@189.cn>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Christian Koenig <christian.koenig@amd.com>,
	linaro-mm-sig@lists.linaro.org, Li Yi <liyi@loongson.cn>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	nathan@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller
Date: Mon, 24 Apr 2023 22:07:35 +0800	[thread overview]
Message-ID: <aaad7121-538b-e2ad-8334-2682a120ed9b@189.cn> (raw)
In-Reply-To: <CACvgo53h+X26wngVmxpn3oVb9kbJezTHx61p3rZDR7sw1AQrWQ@mail.gmail.com>

Hi,

On 2023/4/4 22:10, Emil Velikov wrote:
>> --- /dev/null
>> +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c
>> +void lsdc_debugfs_init(struct drm_minor *minor)
>> +{
>> +#ifdef CONFIG_DEBUG_FS
>> +       drm_debugfs_create_files(lsdc_debugfs_list,
>> +                                ARRAY_SIZE(lsdc_debugfs_list),
>> +                                minor->debugfs_root,
>> +                                minor);
>> +#endif
>> +}
> Should probably build the file when debugfs is enabled and provide
> no-op stub in the header. See nouveau for an example.
>
>
It seem that the drm core already done this for us, are we really need 
those #ifdef guard anymore?

I remove all of the  #ifdef CONFIG_DEBUG_FS in my program and disable 
the debugfs option in menuconfig

my driver compile without any error.


      parent reply	other threads:[~2023-04-24 14:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 17:13 [PATCH v10 0/2] " Sui Jingfeng
2023-04-03 17:13 ` [PATCH v10 1/2] MAINTAINERS: add maintainers for DRM LOONGSON driver Sui Jingfeng
2023-04-03 17:13 ` [PATCH v10 2/2] drm: add kms driver for loongson display controller Sui Jingfeng
2023-04-04 14:10   ` Emil Velikov
2023-04-05 16:40     ` Sui Jingfeng
2023-04-05 16:55       ` Sui Jingfeng
2023-04-11  3:33     ` Sui Jingfeng
2023-04-11  5:39     ` Sui Jingfeng
2023-04-11  8:18     ` Sui Jingfeng
2023-04-11  8:49     ` Sui Jingfeng
2023-04-11 10:21     ` Sui Jingfeng
2023-04-11 10:44     ` Sui Jingfeng
2023-04-11 12:15     ` Sui Jingfeng
2023-04-24 14:07     ` Sui Jingfeng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaad7121-538b-e2ad-8334-2682a120ed9b@189.cn \
    --to=15330273260@189.cn \
    --cc=airlied@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=liyi@loongson.cn \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nathan@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®