mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haris Iqbal <haris.iqbal@linux.dev>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Keith Busch <kbusch@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Subject: Re: [v2 for-next 2/3] block: allow error injection rules to delay bios
Date: Fri, 18 Sep 2026 16:34:50 +0200	[thread overview]
Message-ID: <aaaee8c5-3a81-4aff-ae02-6084aad9bbe8@linux.dev> (raw)
In-Reply-To: <20260918142222.GA19288@lst.de>



On 9/18/26 16:22, Christoph Hellwig wrote:
> On Tue, Sep 15, 2026 at 11:24:47PM +0200, Haris Iqbal wrote:
>> We can do that, but that's only half of the feature, and the weaker half
>> IMHO. Only delay with a successful completion covers a more useful scenario
>> for testing in the upper layers.
>>
>> I am thinking about how else we can do this, but did not find a nice
>> approach.
>>
>> Maybe we can #ifdef the new flag on CONFIG_BLK_ERROR_INJECTION?
> 
> At least I'm not worried about the well-predicted flag, but about
> using up the very limited flag space.  But if this is so important
> we'll somehow have to live with it.  I'll take another closer look
> to see if I can come up with a better idea.

Thanks.

I can send a clean v3, with the flag, the changes to 
submit_bio_noacct_nocheck() removed, and the corrections according to 
your comments. I also found the Documentation changes in this version 
were big and explanatory, which I have shortened for v3.


  reply	other threads:[~2026-09-18 14:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30  1:19 [v2 for-next 0/3] block: delay support for error injection Md Haris Iqbal
2026-08-30  1:20 ` [v2 for-next 1/3] block: reject unknown status tags in error injection rules Md Haris Iqbal
2026-09-02 13:58   ` Christoph Hellwig
2026-09-02 19:48     ` Haris Iqbal
2026-08-30  1:20 ` [v2 for-next 2/3] block: allow error injection rules to delay bios Md Haris Iqbal
2026-09-15  9:11   ` Christoph Hellwig
2026-09-15 21:24     ` Haris Iqbal
2026-09-15 21:29       ` Haris Iqbal
2026-09-18 14:22       ` Christoph Hellwig
2026-09-18 14:34         ` Haris Iqbal [this message]
2026-08-30  1:20 ` [v2 for-next 3/3] Documentation: block: document error injection delays Md Haris Iqbal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaaee8c5-3a81-4aff-ae02-6084aad9bbe8@linux.dev \
    --to=haris.iqbal@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®