From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3ED3845A8 for ; Tue, 3 Mar 2026 08:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772527967; cv=none; b=MVhaCFmGabUl0PrBDvcNrq/1jc38jHVpAXXyn6tfbMmLD2zMrNdH2vz9Vifqivb7n32k9j4r0BvhTbC5/sS68OmmCOJd0LEy4gNQMxGzz1lI5If85bwUUSlMjiSyMJdW4CVQbb4w30SBwq93taWhrVQ+HypYDbYP0jh94AEVWUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772527967; c=relaxed/simple; bh=NHydjAt4Cze7NsxZrmEKQXTvB1FSPhoQ8O+U5sJeXiU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ULb5xZkkBCjKHdgm9vIpeg4HB9A1b5jVvYZUwwbnC3E/ccUZgYBkI1cCVjvtdFEr5OQCf16UN7SBjhQtTEt4UTBShwFsG9aU4rw8Np4obpsJTYs0OpypTx7uboq2Z3me48Z4CuQetxQp95KGM5GaWGOrdd4kyyDzsvp4apqkRdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m8LCE5/G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eyGlLgtG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m8LCE5/G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eyGlLgtG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6237U5xg2048984 for ; Tue, 3 Mar 2026 08:52:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=YNCoDF0Cx477EaFoLRXf9AP4 5l0gNVgmAcjZgp84zKw=; b=m8LCE5/GG26H7daYOSgbqY8Xg4ZNKzApJqvYus6K SdQMGPTDn5gNm/wBRQKC3x9wD9ZrYTDIDJFWA9iK1r5vHasFbIS9dYc9+LqN7Nx1 kUHGHzp3AaFc+C3DQJuxvftRVKKz7+8UnR3sJlRyXv/510mKsSihs/k3RzbQG9ER Bo/rTLuUWmKs3i2rjIHmPmw8CbT6iiyqlVXMq3fXTkNd4KcA2YDYqIAN9PS8VQ7q NCJT7OQT7lIuMPOWHe9bkJ1raNCq8FSxRq91AWiA7t17uDOcmYqRVFgNg4i7mkQq Mb1OwaTxGfvhD0zBjEegsk/B02RZO05M1dwqQhOEIir8Bg== Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cncmfuc51-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 08:52:44 +0000 (GMT) Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-462a9191720so57125317b6e.0 for ; Tue, 03 Mar 2026 00:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772527964; x=1773132764; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YNCoDF0Cx477EaFoLRXf9AP45l0gNVgmAcjZgp84zKw=; b=eyGlLgtGHntS1JX8qoi3tqpJDSEIloP87UItpu7TyUHET23VOP60E+MJJWyO+NK6c5 zanqVP0fB3TrAEgsS7xsYb/4RWfw/6MtuLLW3s2EbE7PYTiZ8qajAU1x/oUHR4bvWSOI 0MYn8rUAr6J5gVxZ/5JpJA0dQVd2bKnNZYIg36ngFZfjO/Ubu5TiGHG4et4TXQs7DlVx 6uXthykXZsvHYbSj/yknwL8oQvcklugWjnQrU0Sd3edY1Wtx/h7Uxy7o+912qy0muuBS Y0YLGsgrPW7/8I5WUEA2i+u2CI5liHvrLv4JotlR2zKve5TDfePN3YW8jCkh78GaJ7rO BrOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772527964; x=1773132764; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YNCoDF0Cx477EaFoLRXf9AP45l0gNVgmAcjZgp84zKw=; b=cv9cEfVaYYnL3pXPqG/vYcuYdJDoAbISGb8cUSMrYYOrrgK5Ahv99QaEUirnYNdyDe 09WNpI8EAbwbfVMdZDg9fkrJgrCpvTxLzqGPrI2JNp4dd7nen/PO+QNQmX/ryU0BI47X nDLuDTeLVeC4OXBSulO2/GUAyy0YEhM0YqvTw9l3DHP+48hiulT5a8lxcGFbzGV8mIXA nNVQjkamXcpnbBm7IIyexERcVVe6fDxVAu70a9o1lQXgXHeAD6IPQmljYn+TZ6BCljeq iT1kzvbHvL8RO1NVeX+xjq8wfoczBpJRp2w36XTi4RoxWJB4vWWyOMDZ+uuoT7P0DlqS aDVA== X-Forwarded-Encrypted: i=1; AJvYcCVruJeaZWMff2JickskCoe/2K99rz85LHgnh435/0GkFbu2M8pdsUtIjYqinDAmhHngsGsaKF4fg1DX93s=@vger.kernel.org X-Gm-Message-State: AOJu0YzI68Rp8yatek8CKPfeYY+y1Yjd9kpyGveni54WRvu2CUlE1JvN VA4M8EhqyqA9BrBpe4zWp2FHrgwhNBsoraOEhK35Q8P/ZhEF9zpjex73JMqWGoEstdgEig0q+Xb z9NQl9ixTsWtVXav9AhkwRfK+x2aMpbBmMHHfqH547Y61r7UKH07TnxDn2vxSQqBL/T4= X-Gm-Gg: ATEYQzxSGhJf/l4NbtQ+kK/zwRY8+dHKGIzrhcToxZQk0UmUlk7zNRecdaSGVpKO0QC /wyDNP3hbpL+ezsXFLsK2/Wu8sqn4KieLxadLH6uVUEge7AEjZN4R7nOBmu5E0T0uAD9AF/0lRf ZTLE3soFasQ/ZIuydVS8srfIlB85lapsqXvoPTHbjzxZdCwYoszQM9Pi46LIpFbp5BE5YZ31dsw qiZOrgiut6STMvjI90RPgNW3SSIEuGQF0JSH3Y+SBonL828IhqjQCwqsh2kT2RrkxrHwQI55Y8J 7hm2BSuZ2El84yZ8hfon9tONM2c15MxN/8xDtiYSBoE1ksauMlLXZup33xiNeq80Gil5JIwIPei UNsTlXG7PHxrWA8zmSZgOP7taSfcb50hYqXFuO3+nR/FEU54ghFwIltSyyVBgHdcA09540PhNlp JKIGM3 X-Received: by 2002:a05:6808:c412:b0:45e:e174:d07e with SMTP id 5614622812f47-464bec22949mr7968586b6e.3.1772527963993; Tue, 03 Mar 2026 00:52:43 -0800 (PST) X-Received: by 2002:a05:6808:c412:b0:45e:e174:d07e with SMTP id 5614622812f47-464bec22949mr7968567b6e.3.1772527963596; Tue, 03 Mar 2026 00:52:43 -0800 (PST) Received: from hu-ysakshit-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5614622812f47-464bb59be78sm9432983b6e.13.2026.03.03.00.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 00:52:43 -0800 (PST) Date: Tue, 3 Mar 2026 00:52:40 -0800 From: Yuvraj Sakshith To: "David Hildenbrand (Arm)" Cc: akpm@linux-foundation.org, mst@redhat.com, jasowang@redhat.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, linux-mm@kvack.org, virtualization@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com Subject: Re: [PATCH v2 1/4] mm/page_reporting: add PAGE_REPORTING_ORDER_UNSPECIFIED Message-ID: References: <20260302111757.2191056-1-yuvraj.sakshith@oss.qualcomm.com> <20260302111757.2191056-2-yuvraj.sakshith@oss.qualcomm.com> <2f14572e-e02b-4bc5-abd2-7814c24f7905@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f14572e-e02b-4bc5-abd2-7814c24f7905@kernel.org> X-Authority-Analysis: v=2.4 cv=Br+QAIX5 c=1 sm=1 tr=0 ts=69a6a15c cx=c_pps a=AKZTfHrQPB8q3CcvmcIuDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=oZke_92Gw2P4qifsOy8A:9 a=CjuIK1q_8ugA:10 a=pF_qn-MSjDawc0seGVz6:22 X-Proofpoint-ORIG-GUID: 3XSx1DGdwBb5TkuG08KLjlK1pY1jgcDI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDA2NSBTYWx0ZWRfXy55jEvcjvz7t +QWsyGsv5XDqjzgQY+byyHKoJ1apAI7HSr82yRAFGBjjP65yCa/CXoB4+XFblfXNnMycIEd8rJO Fedqy+eJPArcbQ3xciR0Y9XVdIOGgGYnqvK/Zs4Z2UooQz6Gh5B0yQmHrJQVSEFBcDsRfRHv4yQ 3hHr3mfBGDTog0OTxqzI5ZepSQg+JeYYBNOkOsyTgQvCsCtjhbWmbMzpwKg+WbcnjvtybQHx8sU yUUJQhMiAEaoL40tHmLBeAE4cRmQsAaO2PFIjyhBaQlp0HWCTxYMsqH1CIdkIAQerndo+k9imMY slW/Pss2vuLydpFffl0Mcp68RQbZMzlEBP4WBrY2qkGFMQ6Iw4iiYMPrzD8Qux0f1cE87Tzt+Je K7wKIMcCSQ6a8zM3sHi2hiv0Wy+1DIgMLL9dBb1cemeMPTYbycl8BHzurEC8e1+uVr5nECluEWw lKmomR4riJEf+Ybi7Ag== X-Proofpoint-GUID: 3XSx1DGdwBb5TkuG08KLjlK1pY1jgcDI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030065 On Mon, Mar 02, 2026 at 03:57:50PM +0100, David Hildenbrand (Arm) wrote: > > /* Initialize to an unsupported value */ > > -unsigned int page_reporting_order = -1; > > +unsigned int page_reporting_order = PAGE_REPORTING_ORDER_UNSPECIFIED; > > > > static int page_order_update_notify(const char *val, const struct kernel_param *kp) > > { > > @@ -25,12 +25,7 @@ static int page_order_update_notify(const char *val, const struct kernel_param * > > > > static const struct kernel_param_ops page_reporting_param_ops = { > > .set = &page_order_update_notify, > > - /* > > - * For the get op, use param_get_int instead of param_get_uint. > > - * This is to make sure that when unset the initialized value of > > - * -1 is shown correctly > > - */ > > - .get = ¶m_get_int, > > + .get = ¶m_get_uint, > > }; > > I think the change to page_reporting_order (and param_get_int) should > come after patch #4. > > Otherwise, you temporarily change the semantics of > page_reporting_param_ops() etc. > > So you should perform the page_reporting_order changes either in patch > #4 or in a new patch #5. > > Apart from that LGTM. > > -- > Cheers, > > David Sounds good. Ill add a #5. Thanks, Yuvraj