From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ACF51CEE8D for ; Wed, 22 Jan 2025 08:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737535941; cv=none; b=NDboXP4WxuYUm4oHUYFg+5w+T9fCfNJOF48b0oT9V2Bx6DluJ3Qc1ITIKJnjGdla9QR3AjtZAA2UcD4A4LRZHpX+uXRexDootx1upumBY8jb5K3Xogu3K9nNV3hVlohc4vf3SOe49+PSXuHrEsgi/efnLPoIvUAgt6h/1V6L984= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737535941; c=relaxed/simple; bh=/KbMg03ysJ36TK2+nSz8IAZZK9CJPyTsUDRYN0Hy9ng=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pcpt9m8hNmb8QEpjg3EGNBfMmm7UfkV7rhLPErMgFjFsWol6vIseXWN1dxWuM8+2yixFuDedopW5xkOOZtJZnNGBlBg8dMWKcvcvMDLJ2rPf27J1UFNiRbZw62L3yzuI0Gb7pnLVYU5GtJ9BpKW2jIPWn3E+yiNgdNXFnCcS5p4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W6VYXu90; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W6VYXu90" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737535937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T8NqnrUPLUm+goHNuMH/eLtMvgOwuaABMCWI8ou8J54=; b=W6VYXu90M4QUM84i+QGPxeq2Y+fJyjoEv4v4d6q5JMaYc4YRkoaI387222MvphavKUA/bf BeHJoZ+1DjcNegVRtr0EujHrVM9RUgCdesciVhtYJZEFKva47GNZJ7k7y5xoZtgIi3PwFk IlpuV7GNps0ypo8URk5jtyiqd3vCqzE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-dtQ1k78cMbaezYtsJpa3lA-1; Wed, 22 Jan 2025 03:52:15 -0500 X-MC-Unique: dtQ1k78cMbaezYtsJpa3lA-1 X-Mimecast-MFC-AGG-ID: dtQ1k78cMbaezYtsJpa3lA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-436379713baso32432975e9.2 for ; Wed, 22 Jan 2025 00:52:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737535934; x=1738140734; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T8NqnrUPLUm+goHNuMH/eLtMvgOwuaABMCWI8ou8J54=; b=QV+0FToxFluBeR8nE9ZbfbULTTxxqfNlsdzIAUbBPn4wanYxh0HfOjLt0F0nTXRjrn HoHQtpJ9nqb2p5u3SwnSWFGyqSCVZd7lvs2PZADYcLMAgINBNynma4jJI6josD5dVJ3O oTgM0N+7IrKMeieBc9+KwlRyyz+YB4Ln3UUP+d5ycZWLR2emVqy71C14Fyxxf2pzqjXm 3EP3dz8Hv/g1gjyWpkXmhtY+RM6TypeV7LyFGmbpDVzrLWVb1p//C0kBe/8brI5hyNON W0XfWQmo6ebjBPTP3IHWo5Ij4zG7O94oFUeGTlC/xPeO8FVWkXcaLwI6Ps7HWvTibNHp 9AtQ== X-Forwarded-Encrypted: i=1; AJvYcCUJS9EfOWjJx1CYGBbttb9VpWVChm19eS/3cuMF4Ig8cpoyis4GreyTTRQ19MvlHcx+Wrh0YBbY6MWe17c=@vger.kernel.org X-Gm-Message-State: AOJu0YxitlOCXXyoFmd/SjenPblsUsrbPG55wFOalE5RXiIJBWobFRxV XoCoepTBU793VVj+EN/V1wWOt+xyuK2D4bfJjkX3VL+Ffn2KLKLXsqtRvJMGHlk/8x4U3HXA7Si dyDBt514qxFKHWGDd+cqxydT70D3234Px3K0sJXFMmIru9c03r2VvFvMur0lnfw== X-Gm-Gg: ASbGncvC5CBq9YTACrogvqFsQxIAxRaRt3yMtSGqmShyZFuHLANHm4T3yR4FVJKwF31 wN5HLKkjZmg+LkGZ3Ec3ErUhfspRlHT49aFgT604s8oKvjiGcKUkAZbM2hVF/04cAj/jyOOp76N oBmcquJO1MD0wDdwy2TUFnxGNnX9oEjIulIjDhzxtuWOOLpnd6hliMremd9PjDyHdtuXaG8PUNk sdwd9OCUAabVdcmFjrSy1kHCQbBWz7iTI64pDpDwfR+ytBCzMIwtCp7oni99YHF4ag9TA0tppqa nMpH/+vKJjcCuX3WdSvysSc= X-Received: by 2002:a05:600c:28c:b0:436:5fc9:309d with SMTP id 5b1f17b1804b1-4389ec8a8d0mr183676365e9.30.1737535934475; Wed, 22 Jan 2025 00:52:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEHgmgSAWarMTclmRJpAcXIze3fslpel4hBc3+lztR/nus1RCwGGhtzOZmNifCsOYhd4sbZKA== X-Received: by 2002:a05:600c:28c:b0:436:5fc9:309d with SMTP id 5b1f17b1804b1-4389ec8a8d0mr183676135e9.30.1737535934123; Wed, 22 Jan 2025 00:52:14 -0800 (PST) Received: from [192.168.3.141] (p4ff2353b.dip0.t-ipconnect.de. [79.242.53.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b318c176sm16487075e9.3.2025.01.22.00.52.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 00:52:13 -0800 (PST) Message-ID: Date: Wed, 22 Jan 2025 09:52:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: page_isolation: avoid call folio_hstate() without hugetlb_lock To: Liu Shixin , Andrew Morton , Kefeng Wang , Muchun Song , Zi Yan , Johannes Weiner , "Kirill A . Shutemov" , Nanyong Sun Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250122061151.578768-1-liushixin2@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250122061151.578768-1-liushixin2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22.01.25 07:11, Liu Shixin wrote: > I found a NULL pointer dereference as followed: > > BUG: kernel NULL pointer dereference, address: 0000000000000028 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 0 P4D 0 > Oops: Oops: 0000 [#1] SMP PTI > CPU: 5 UID: 0 PID: 5964 Comm: sh Kdump: loaded Not tainted 6.13.0-dirty #20 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1. > RIP: 0010:has_unmovable_pages+0x184/0x360 > ... > Call Trace: > > set_migratetype_isolate+0xd1/0x180 > start_isolate_page_range+0xd2/0x170 > alloc_contig_range_noprof+0x101/0x660 > alloc_contig_pages_noprof+0x238/0x290 > alloc_gigantic_folio.isra.0+0xb6/0x1f0 > only_alloc_fresh_hugetlb_folio.isra.0+0xf/0x60 > alloc_pool_huge_folio+0x80/0xf0 > set_max_huge_pages+0x211/0x490 > __nr_hugepages_store_common+0x5f/0xe0 > nr_hugepages_store+0x77/0x80 > kernfs_fop_write_iter+0x118/0x200 > vfs_write+0x23c/0x3f0 > ksys_write+0x62/0xe0 > do_syscall_64+0x5b/0x170 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > As has_unmovable_pages() call folio_hstate() without hugetlb_lock, there > is a race to free the HugeTLB page between PageHuge() and folio_hstate(). > There is no need to add hugetlb_lock here as the HugeTLB page can be freed > in lot of places. So it's enough to unfold folio_hstate() and add a check > to avoid NULL pointer dereference for hugepage_migration_supported(). > > Fixes: 464c7ffbcb16 ("mm/hugetlb: filter out hugetlb pages if HUGEPAGE migration is not supported.") > Signed-off-by: Liu Shixin > --- > mm/page_isolation.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 7e04047977cf..2a38f429defb 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -83,7 +83,14 @@ static struct page *has_unmovable_pages(unsigned long start_pfn, unsigned long e > unsigned int skip_pages; > > if (PageHuge(page)) { > - if (!hugepage_migration_supported(folio_hstate(folio))) > + struct hstate *h; > + > + /* > + * The huge page may be freed so can not > + * use folio_hstate() directly. > + */ > + h = size_to_hstate(folio_size(folio)); > + if (h && !hugepage_migration_supported(h)) > return page; So in case we trigger the race as described, we assume the page is movable (just freed to the buddy). Makes sense to me. Acked-by: David Hildenbrand -- Cheers, David / dhildenb