Re: [PATCH v2 2/3] arm64: dts: qcom: sm8150: Move usb-role-switch property to common dtsi

[David Heidelberg <david@ixit.cz>]

You have to provide the commit message, even when the change seems to 
you self-explaining. Just one or two sentences explaining why.

David

On 04/11/2025 23:16, Piyush Raj Chouhan wrote:
> Signed-off-by: Piyush Raj Chouhan <pc1598@mainlining.org>
> ---
>   arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 1 -
>   arch/arm64/boot/dts/qcom/sm8150.dtsi    | 2 ++
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> index 0339a572f34d..29afee6160cd 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> @@ -693,7 +693,6 @@ &usb_2 {
>   
>   &usb_1_dwc3 {
>   	dr_mode = "otg";
> -	usb-role-switch;
>   };
>   
>   &usb_1_dwc3_hs {
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index acdba79612aa..cd05975dacd1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3661,6 +3661,8 @@ usb_1_dwc3: usb@a600000 {
>   				phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>;
>   				phy-names = "usb2-phy", "usb3-phy";
>   
> +				usb-role-switch;
> +
>   				ports {
>   					#address-cells = <1>;
>   					#size-cells = <0>;

-- 
David Heidelberg