From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752218AbcFVRnW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Jun 2016 13:43:22 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:32907 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751123AbcFVRnU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Jun 2016 13:43:20 -0400
Subject: Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm
 guest
To: Wanpeng Li <kernellwp@gmail.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Linux PM list <linux-pm@vger.kernel.org>,
        linux-acpi@vger.kernel.org, lkp@01.org, x86@kernel.org
References: <1466558908-3524-1-git-send-email-wanpeng.li@hotmail.com>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>, Len Brown <len.brown@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Zhang Rui <rui.zhang@intel.com>, Chen Yu <y.c.chen@intel.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        jacob.jun.pan@intel.com, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <aab33eba-e2d7-ff60-6a63-abee2a47cac8@redhat.com>
Date: Wed, 22 Jun 2016 19:43:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1466558908-3524-1-git-send-email-wanpeng.li@hotmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 22/06/2016 03:28, Wanpeng Li wrote:
>  
>  get_ratio:
> -	rdmsr(MSR_PLATFORM_INFO, lo, hi);
> -	ratio = (lo >> 8) & 0xff;
> +	if (!rdmsr_safe(MSR_PLATFORM_INFO, &lo, &hi))
> +		ratio = (lo >> 8) & 0xff;

This looks good, thanks.

Paolo