From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1462F3C3D for ; Tue, 30 Sep 2025 10:24:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759227867; cv=none; b=jf3ReIU/eZAawcP0OMWnch/ATCuJuE8jbW65ksWiltrMQXUjcDItnNOe0Q1Skmja6Sq5Iso44/Fu4fXy7WsRblmFvUis5uZvXwk1xzzw51TI2pUKXipbJVLXat2ltJlnsL+1vxiVPR86vNdrJuEBVQqxofmrenLJQxTnui3zLkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759227867; c=relaxed/simple; bh=/xO3z020SlrGnH1T1fxHsnuXvcuFN/F7C6gDnFLfAhY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O7U6x/opshOCaIw8/GsX4nW06jLHKMP6yAv0OVifg5l5oXPCZ/TDpe45Z5Nz9MTAclkxWYPyUvy+OzfDe0/d9na7fiMMpC+liHY8ya/TTuJsuer4LT03hpxMtKKNXDJ7ZIIBliMI+DL1kRyYKVELlcnbZTLzYyxEraKD6OKaEbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=nKIpd7xH; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="nKIpd7xH" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b3e9d633b78so498524666b.1 for ; Tue, 30 Sep 2025 03:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1759227863; x=1759832663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yku4GoZzp9LeWe3ADlx09HHrsnQ3oJo5nPkdtrMrKK0=; b=nKIpd7xH0CXPhYC2VZthyLijAwfxXiUFGgh3W/jjAWaRtzjJXsbPolvPjsWU1NvWW5 XJzHH5usUrlK9MxBaI+FWbY0E46BUUVQy9UslH17cchzoeR7/y5KLAtelVQj9TtjITBn kz2JCwmlAJe8hIS7jCsOzG1frpIxVyzWWU4m7fifMtV37z7PioMOyJDcpTtWAQNRC7o2 KjAZMdVPjDi/VjNvTycWYE6/JmQ2mlOgOOmkrf3yxi6+zbPd42pfkofbkque5U2CX2/k x2ypQYbl2pmaqrZ9WZrbtuUG20s9i7BQxYqlWiEQRq/2rbgPB1urPC4jcf1qw8wuLrPf G+DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759227863; x=1759832663; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yku4GoZzp9LeWe3ADlx09HHrsnQ3oJo5nPkdtrMrKK0=; b=lcM5x/opaCw2noicq3EG3ZoeFssueIOz3QrUZwfyvwwprYBiz27+joHmKypwVoFxqQ gAXll+AWFTqFVJJe5TDvgv5oiOKncUTkqDumLTCv2NpOcKGS2Y6xOy0ooVK5vb/CJAWN hGkw9WEzb7IZcrDQmYhM2XtkF6vqZsM/qBLQN4gl0xv6Mw/DtmEgoK7Iu2XG3nmisuGc Xro9AQ+OFAm30HlvFAJj4jcCFm6+pOt/lB7aWvRubDCRxP7GFxKlF9eetZl1XorU5O76 l6JPPc3zUuMQMvxIYHqhmjwRh6ORu07k9qrXqju3CgjGE1RW90fRSWUXVBzKXUi7tY6c wqMQ== X-Forwarded-Encrypted: i=1; AJvYcCXhVz7krOprZq5m/lqpm5Y85Fsg8gHNgNFSaoGqHd+2znPCbIGVSb6TafUpCdAsHun/XSx1BAPLJim3ME8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8zIqFHdLWIIkWk5HP2WCFVstW+7m4Pc4UBprEj0UWb679HKzy l4aFlmIzelADDUDlskznXl8fuiMGi82gH/0F2TY66CmIPBTEakGF0mC58fHnc8icj8U= X-Gm-Gg: ASbGncshKQWLHldnm1AWw5esqprfUhzb2ICiau/duJpTuGq53j9IhxtWUYT7/pWewVP gdBkH2YteEG+wMuDMcKZ4oAUjWiTwHO8j+89KH8DOYWnYlCcsI+GEpGZZmceA/IVOSLrsbZoLky BvBeFR2C0krWT697eRRvRfHs7hjQHzzsztlIEJ+jtjIeJHAwHJv8CUGHwrf/rqkZj0kx4eyQE48 mJZuFnKzs+gW4a82zUZLxy/S9RMt3RlEwRNGvqDlEU+yZwL3eqNDS2VIRXueme9IqPQ7ql6mB7L Top38ulZ1bJzTyWDRWAcnjLk8WgqR5pmCp8T10NojWwxYlsWaUn2jo0XaUqXOcB/aF+AqEZY7Of +1Rl2K/sLbLr3eLfLpk5yt96GcYRWT1rfqxXAHzqxXWk0gc5Z0rvJgVqnN2aNiR9Erw== X-Google-Smtp-Source: AGHT+IEwT6Q7OMLIIwGyLtVN5rHhdWH9GNscWF9k7Eai3fNlLMNA2xSp+0/7z8qMh2DHsvkbRP8yBg== X-Received: by 2002:a17:906:6a13:b0:b3d:d30b:39c0 with SMTP id a640c23a62f3a-b4138d54e8fmr374520766b.21.1759227863393; Tue, 30 Sep 2025 03:24:23 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.111]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b3ccb3234fesm494802366b.8.2025.09.30.03.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Sep 2025 03:24:22 -0700 (PDT) Message-ID: Date: Tue, 30 Sep 2025 13:24:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume To: Geert Uytterhoeven Cc: linus.walleij@linaro.org, biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org References: <20250912095308.3603704-1-claudiu.beznea.uj@bp.renesas.com> <2bd09757-cd66-4a2a-8801-0f62dc99b9c8@tuxon.dev> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Geert, On 9/30/25 13:20, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Tue, 30 Sept 2025 at 07:33, Claudiu Beznea wrote: >> On 9/29/25 15:10, Claudiu Beznea wrote: >>>> This conflicts with commit d57183d06851bae4 ("pinctrl: renesas: rzg2l: >>>> Drop unnecessary pin configurations"), which I have already queued >>>> in renesas-drivers/renesas-pinctrl-for-v6.19. Hence I am replacing >>>> the above hunk by: >>>> >>>> /* Switching to GPIO is not required if reset value is >>>> same as func */ >>>> reg = readb(pctrl->base + PMC(off)); >>>> - spin_lock_irqsave(&pctrl->lock, flags); >>>> + raw_spin_lock_irqsave(&pctrl->lock, flags); >>>> pfc = readl(pctrl->base + PFC(off)); >>>> if ((reg & BIT(pin)) && (((pfc >> (pin * 4)) & PFC_MASK) == func)) { >>>> - spin_unlock_irqrestore(&pctrl->lock, flags); >>>> + raw_spin_unlock_irqrestore(&pctrl->lock, flags); >>>> return; >>>> } >>>> >>>> while applying. >>> This is right. Thank you! I'm going to give it also a try (on actual HW) a >>> bit later. I'll let you know. >> >> Sorry for the delay, all looks good to me (checked on RZ/G3S). > > Given this is a fix which will be backported, I will reshuffle both > commits, so your fix is first, and the above no longer applies (here). That's OK for me. Thank you for handling it. Claudiu > > Gr{oetje,eeting}s, > > Geert >