From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B40553F23BD for ; Tue, 3 Mar 2026 11:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537508; cv=none; b=Z5o5qixAp49RUApPh2dGeNUz+LF+I3fiaN1fUvYwh8TCSbi4gO13o72ORKlC5OGnPaqKf/ckCL6XeamTSNPXH9s1W+QUuPWaMzCifizCg8NWvdFq1GJarqFjLhtadZGvIhCPBcwtqFvZgXdcHnfLjMUhTLrO/wluPGVz6QfXcEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772537508; c=relaxed/simple; bh=A+05Nj3krLHJC4IRSZHGNuDFtK3tWcfffAHZ9BgE+cA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nH8fjGJh2PwlklTygr7DbeCiJNzpAi672EwoNAumK3pjPeUoXhbMpXzrI2Ci4i8rIOXSpSHmdLSQ+9llyvd6kUji1e2RIHeFYlJMb9wKeMsvievImFRAN7Dm3EemQQzMoetjE+zhMovVaNh0Enl0yaTKwAjTC5DGbL/6E+8tBuY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=alJaucy/; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="alJaucy/" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-483bd7354efso73396335e9.2 for ; Tue, 03 Mar 2026 03:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772537503; x=1773142303; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8Xf7CcTvWKm0AxjepRjO4S6p746Cx/GbxsbLs1tX+zk=; b=alJaucy/GQuMXBZvEr94JMtH8cbSA+3H0coq1rAGuTpjADn7bckSsNQbStl0yfuujY KKB02A1dOeqNa+15CFktNWlJ4NQhtYG/JN5cB7io5jr8Lkctt47BslaPCtPEL8mrGSCT QFO/vIVNSCeDNcy4iLX+XEN5GgywJiSn7jWumR1tWYyw3wbwkJU52IZrpIWZ8nRfkP5v YheHFEfytPFn4f/D+hjh6xX9cx3fDnPRask4X5ER01nl8ZLx7qd6ezy8nxSCP+FeRWR+ mpDzSMn5bQNzRDd+nK6Np7Y8kQaePI6xohjYSeBsrN7UXO1fLiiVDQfYKEaxrWzUEPHp N9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772537503; x=1773142303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Xf7CcTvWKm0AxjepRjO4S6p746Cx/GbxsbLs1tX+zk=; b=dGOHyZp3EH/37qteV9aPMhgVXjEe3JfB+zqx5YSpdvFs3DNYXsJwjjiYdZPeNWs+yo yl7HwvJD1rmgy+VGzL+alsAIvkjauJMBb4Jek11nvBufCozjV8nqqM1zP9gQMcNLQVOa 3GfaYrkHTGZj5RUKn6OduzeN4AKL2zUbNWWKv2/R47wvxOo21FLQi5cP/AwgwMO+sOWf +LBuSyMhn7v72wpJ9cNDkZfALjC/9La32EnSHJMyflijpBNuo2Y2rSwyhmTRb1h+GkUj rSBDxYfHX1RfxB2pbqs/7MRwiNMSy/EfaE1QgPaDL21CiQFYcuvq7/X7Hxd92ZqcaOiU uo8Q== X-Forwarded-Encrypted: i=1; AJvYcCXR8pzLz3jpiDSuwdt9qeVdh7kUQHgTPwgR0ldhj64aE3tQbJy2Q52OW4VUVzed+VMgbRhYjfzoLtT5UK4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfr/MrolKMI0ytmMY1Ba8iZ+msrgrDzo9rCjFhvzhUzTBnXS1U lZELHd7mIB8Q8JwQEUt7EmECerR/VoOPYi9sHIEewjsbCiXZ/2jiY62xDrDO9FkmaS4= X-Gm-Gg: ATEYQzwnctA69ueM5kCZGVYTjmR2OiKA8bv9RH3cgCg3JuEZtUmgmi4X4ZZdzoaQOqI VbtZQhJHaAcrcqxahTEafrHfHHJGIirEl9lCGfCe2sYIt/5lao/H+d12rogWDNxL8IYaZx4HVwq g1qOfVF+OzmJlxsON6nsI2ymzCOFHxJ5L0pcNSgSKOlD1CEJaBmfEwuhRLiEtD+AJZp91zuj/9o g/yvz1tHW45sSaaIZu0wnph21ov72S1JL9mE++RZ+m3uakitr2Zhlyw0EsGmyT+eUaQ5xBxCKGb 0NL7vghEVQ4SbBw+1H4uwznJVHNZ8jBiukFrgn4hpPNem7RVpdI5k+EmuAy6+/FNqAQxd2vaeJ+ hSqE3IqYZghS0SCYNqC9iQ9Qnys4nK+cz++wnvZem10jB79s/bq2FCd/PSYbu+gs9+wiJjTlaXL e4NMTD5CQjuzlzsPSgGo8AF/4eByW8uHxH2lr/ X-Received: by 2002:a05:600c:8711:b0:47b:de05:aa28 with SMTP id 5b1f17b1804b1-483c9b9701amr320509715e9.2.1772537502910; Tue, 03 Mar 2026 03:31:42 -0800 (PST) Received: from localhost (109-81-20-148.rct.o2.cz. [109.81.20.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b3cc2e65sm18457589f8f.2.2026.03.03.03.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 03:31:42 -0800 (PST) Date: Tue, 3 Mar 2026 12:31:41 +0100 From: Michal Hocko To: Maninder Singh Cc: rientjes@google.com, shakeel.butt@linux.dev, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/oom_kill.c: simpilfy rcu call with guard(rcu) Message-ID: References: <20260303102600.105255-1-maninder1.s@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303102600.105255-1-maninder1.s@samsung.com> On Tue 03-03-26 15:56:00, Maninder Singh wrote: > guard(rcu)() simplifies code readability and there is > no need of extra goto labels. > > Thus replacing rcu_read_lock/unlock with guard(rcu)(). > > Signed-off-by: Maninder Singh Yes this simpliefies the code indeed Acked-by: Michal Hocko Thanks! > --- > mm/oom_kill.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 5c6c95c169ee..9e3e88c06ead 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -135,19 +135,16 @@ struct task_struct *find_lock_task_mm(struct task_struct *p) > { > struct task_struct *t; > > - rcu_read_lock(); > + guard(rcu)(); > > for_each_thread(p, t) { > task_lock(t); > if (likely(t->mm)) > - goto found; > + return t; > task_unlock(t); > } > - t = NULL; > -found: > - rcu_read_unlock(); > > - return t; > + return NULL; > } > > /* > -- > 2.34.1 -- Michal Hocko SUSE Labs