From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27F253C5DD0 for ; Fri, 13 Mar 2026 16:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419185; cv=none; b=QYmHBiG1Vus4JCIXrU8wb8WfawH091/LeITsg3KORdNMH43JRzT9q/1ntjq6CAgdgyXKO5fLA8BRk2zrW3KmHS++cvFgdWChJPTNFoxa3gzlx1LXiUbdVtWrbdBqxmBinkZ/qSisgmYTMJ2SeCDNBjb7xb/+HsJjcD/tAi5LKQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773419185; c=relaxed/simple; bh=xphBfWYWIwfcxjD6m69trtzT0zhuPOftlxEkUe47TK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jhYNsxL+2Ovl986ghJz4LRYgTvzxo62DK2mzkMxrjr3paKg4g4Xc5eQJqMIb4+p28KXDU3uk0qqkoRMq6RRnti6idcBXS1gOES3Wj9ojaMmDpAcXuh6hguc48yTICyK0N9RIvPwVh1jkTw+rLsEDaT0XGvBuTjzC5kbAyjHrdqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l+sIqAwY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l+sIqAwY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4852afd42ceso20799735e9.2 for ; Fri, 13 Mar 2026 09:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773419179; x=1774023979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Uh9FXu+Vcbr/JOV4pFTxbLbMmrJ246ksOjHkBZuDF4I=; b=l+sIqAwYzNKW7M01pWfaORPVXbHdp5P0dHEjGBKftBpC4Y79qVZz6lSPolsdEFE2nf KczdM+8nJa64eU0LpyGzGzpDCTi9jGhYtc5LXcdvUxDrhwm5C41mrzDWM9RkXHCfIUWn D9RML1VU1jAhEjF4J42qLufOEUbhX7vFOmjghgn3a5esANWFredRmNevNyiFneeUz+QX LywqyDuJKO3t3QRPogxr9n6PDHmRY7hUaR++mo1cqlmUfTZGfKLE0GnOT+wKi3PLs88r 2/XdhfC1Ij/3jWKWnai8QkiCRCMBawPu1G90feFNVuhjeI9qN1ZnoXoUELgaS2KGLVIM jFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773419179; x=1774023979; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uh9FXu+Vcbr/JOV4pFTxbLbMmrJ246ksOjHkBZuDF4I=; b=DK2Whwd8RwSZpGjZvEpel0x7frv8ay1+Vpy1wTxuT8obicarzJ4BEGqfG9v+HmHWaN 8dJzMVKw0DNHLiO7MltJLJ0vk8K/uJS99NaeN5/u1bAArBgr2g6SAClKQSSdOHHNU56R 7+f8FzhDCxmp9nUUWzxjqPGMJ5iY4RlGU/IoOFwtCf8h3a77yap5mo+l3Qvk+zhKC6Jv BGggih9U9fxxmoiXmMvTvebcn9iT6cAA4uQvEiidUYaoTD3DuuCqY6hxL/5gISkC8tTt NFY92fQJ2JVpKcXfMtSkjSFPTcpXFqYet17Q8UtU9lp52J5PmZsDmpWKD/qRxhP/QWBM WbCw== X-Forwarded-Encrypted: i=1; AJvYcCX9MlJMkhVCnCPotpVaRhdXB5kfNUDMcwZRgVdthC1ndgU17vSST2UnHbZYITy3CS3+wyfCqzeYE+mJiZE=@vger.kernel.org X-Gm-Message-State: AOJu0YyWh5dpI01FmhwtNGFiyK/Fgxq0/ceArpWg6/1wQW/D277RbBtR andMvCztlCOyyPcSjJsN2tktOAdx0PH/Bv7sjgpJIbJgn6f/IAXtl+FdUy7nt1aNfec= X-Gm-Gg: ATEYQzzwqOqTysJo4eatKFAY85zz5rAog/3otqCa3tkc2YNQRucyQ/Fz8HzZ/qv3DLl YRL2ojjcFmR0GoWeaZAjv5TPAn2nv6noVfI7Ovc0VTY/51Tc7h/dQIWVjAAW218MlN069j103KF R6Zj1zm9Ue6rHfF4f4krCMWV9KjNWRGRYuTsIvodS9Ala/w+/RKshulOJ9FqptKiSgmWDeP5Ttc Ms3iBhkiqj+1qtiTlUcRNL8hH0fzyLEtbrR+FufMi9wc4NvYKmVTyvVTjQ04/V+4w1OWW481hsk xZT8EAbe7H9KeAiLXb1uDGHyCzMSyJ8Kzk4lEov13xpfoDYhdbs6AAJmiaocGJ1zPp24mqDd6UV t7g3t/Oqe+s3ZpV7NvatmE2z4DF82vgU+TydCJhFlCv99A+3d/3D6kCBtTxar0rpJpNdiWA465J VJcac07NUrb8KOAEulKeBfF7sooK325KgHCqOU X-Received: by 2002:a05:600c:628c:b0:485:3aa1:a7f1 with SMTP id 5b1f17b1804b1-485566c6a59mr61329255e9.7.1773419179118; Fri, 13 Mar 2026 09:26:19 -0700 (PDT) Received: from [192.168.0.101] ([109.76.176.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b5e912fsm588826275e9.2.2026.03.13.09.26.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 09:26:18 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 16:26:16 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] Add driver for EC found on Qualcomm reference devices To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <132116be-2964-4b98-be2b-1baae5bfb58e@linaro.org> <19e8837b-d711-4d0e-ba9c-e9b2c8330969@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <19e8837b-d711-4d0e-ba9c-e9b2c8330969@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/03/2026 13:15, Anvesh Jain P wrote: >> [   27.311768] qcom-hamoa-ec 6-0076: Fan count: 0 Fan Type: 0 Thermistor >> Mask: 0 >> >> ? > Hey Bryan, > Thanks for trying out the patches. CRDs typically ship with > very old firmware, and updating them to the latest version > should allow the thermal information to be populated correctly. Sure but looking at this we still load happily even with all of these values set @ zero. Fan Count == 0 || Thermistor == 0 => error and probe() fail. --- bod