mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] media: i2c: imx412: Assert reset GPIO during probe
Date: Tue, 3 Mar 2026 15:33:03 +0200	[thread overview]
Message-ID: <aabjDzc9kR5N2gAP@kekkonen.localdomain> (raw)
In-Reply-To: <20260123-imx412-v7-1-e58303f2b76b@oss.qualcomm.com>

Hi Wenmeng,

On Fri, Jan 23, 2026 at 05:19:55PM +0800, Wenmeng Liu wrote:
> Assert the reset GPIO before first power up. This avoids a mismatch where
> the first power up (when the reset GPIO defaults deasserted) differs from
> subsequent cycles.
> 
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>

I'll add:

Fixes: 9214e86c0cc1 ("media: i2c: Add imx412 camera sensor driver")
Cc: stable@vger.kernel.org

> ---
>  drivers/media/i2c/imx412.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
> index b3826f80354703b17b416dc233854da3f5736e38..aa63dfc349181bf9c180ffd566b0317d05b410c1 100644
> --- a/drivers/media/i2c/imx412.c
> +++ b/drivers/media/i2c/imx412.c
> @@ -925,7 +925,7 @@ static int imx412_parse_hw_config(struct imx412 *imx412)
>  
>  	/* Request optional reset pin */
>  	imx412->reset_gpio = devm_gpiod_get_optional(imx412->dev, "reset",
> -						     GPIOD_OUT_LOW);
> +						     GPIOD_OUT_HIGH);
>  	if (IS_ERR(imx412->reset_gpio)) {
>  		dev_err(imx412->dev, "failed to get reset gpio %pe\n",
>  			imx412->reset_gpio);
> 

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-03-03 13:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  9:19 [PATCH v7 0/2] media: i2c: imx412: power on timing adjust Wenmeng Liu
2026-01-23  9:19 ` [PATCH v7 1/2] media: i2c: imx412: Assert reset GPIO during probe Wenmeng Liu
2026-03-03 13:33   ` Sakari Ailus [this message]
2026-01-23  9:19 ` [PATCH v7 2/2] media: i2c: imx412: Extend the power-on waiting time Wenmeng Liu
2026-02-27  5:34 ` [PATCH v7 0/2] media: i2c: imx412: power on timing adjust Wenmeng Liu
2026-02-27 22:01   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aabjDzc9kR5N2gAP@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=wenmeng.liu@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®