From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A11041363E for ; Tue, 9 Jun 2026 12:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007508; cv=none; b=uyFLdKQi7KXrh+GQP7X0RogGfHfP99DVRLhTKS22udgOf6r9w6lh47yM6jNpNqIfPkqug/KNiCwL0nNwXVVIQYe9ZoWa9njm7wFcCcUk5QnoyjeDbMM+pBj/htB3sjKVRP21QZDchzNliE3h0Fl0m+wRhAn+kN2IDauZDiFNloM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781007508; c=relaxed/simple; bh=XooUwXri4R+BoLa5L4foDmENTNjKE4+yhojS5sLja5U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bq97Ys77UdX2rNWLJXHUEUFhhMSEuWORBNggtG65upNJ1Vyhw4A9Xup+veNWACEhJwiaQegtz9bU2OmITvzSjkQTiyqQaaaacalQnBLTRSAmKQrCO99d7dtq07TEEfcj6zIYA+W59S0G5kCVzKbwHnNprI+FXirGmyaiZpnCSpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bwbr73QD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D133+TvG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bwbr73QD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D133+TvG" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659BnNRB2051771 for ; Tue, 9 Jun 2026 12:18:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1YFD4b+EciMSnNmzK0ZeRJeHEjtUncEVJ+8zDIPQSkM=; b=bwbr73QDVI2TdFV7 vsx/3Nm37xUjkUbU2Tpac9lM/lWR+Z7IVZEyDpJ/wQwq6V1q241I/Y0FHpPiJNcQ lpw8JMvtvC5L7k+szDr8Roho+wrN53yT1q8GeHsPLSO1QiW11w3OIbSU6d5UabzP mMQwkvdEPmy9nyfoC0AK55iPv20ipA7iVfRPzXHBAfpLNgtE1oJGy5SdMe6O46zg BGgNQLnVF5VsCKcfiQgzqX7svO1vHCPA3Dk7QzSXDbWMyZekssx1vdrlAJnIG0zE wPA7f8eEtWMhX7GKbNsD58bOF5PVe4x/0Yn9hRY+jLsddgu7oPzep7hfvd8VXdzU N0p0fw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epenr93ya-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 12:18:26 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51768e1d798so14037751cf.1 for ; Tue, 09 Jun 2026 05:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781007506; x=1781612306; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1YFD4b+EciMSnNmzK0ZeRJeHEjtUncEVJ+8zDIPQSkM=; b=D133+TvG2G85SezK9fksKNGo4EFwnvEKeOa5dDLWBZ4ktQtduGRwBxibuyf6zB5Gxq tMo1MpQJnfz3PqxNfBBlPBocQsqllwW8OXisqQcvrsWEEh8fNwQLdShVEjXRWk5GzJnJ Ldbg9WViKWpenV6JEqPhXdjl1dftIpEQhLj0go0COB7tSb9tH/R+2SwYP0H9olX5gK8/ WK7/FAdNHw2P7hkXvIiYrQy7/hdzS4GCYn9UXPUncMDIohlFOLx60Ost5/q9mRajevr2 ZrgRwTxEMX8kia/GL8sN55ewy5SJDF+fD3DIUzfdOfi207ZYcyF9G13Un2w7tfDRenYz MERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781007506; x=1781612306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1YFD4b+EciMSnNmzK0ZeRJeHEjtUncEVJ+8zDIPQSkM=; b=VOim99oMmkjau/Y4jJBMTChoXW1movt4ZSCsr61Hmnt8Q8olqcMLxyesf4vXaPyPjV heQthyKqDj8WsUr14H6B5kCUvevcav43OEpBmtP6lqjJBpw+4oKzO/kmewaCyM+vN86m UVEIJ0tNocX4Gbre3OK+pcoyhdAak5zozU8QDrbfY2vFyJwHkdoSNOoMO7ktfWtsmnQh I67dd1HO99y598JEoKI85CgXIZiNyTLXk46WSgGw6ovnK1zLoM5QECnN4bFgSaeUp4/L 0f36+Isl5NQhJ8tiBB84aF9ZRLeV5YeeYNot54oybKqQWgF178+2tNIlEys/GwRoiyE7 4s4A== X-Forwarded-Encrypted: i=1; AFNElJ9wPeReJgBfyHDOCBdfzllVAXnhR3wKGTGBwp9xjaL5uLvgMJ24hzQoSgH8Jp4y/nwAxDa1kT9kIYbrths=@vger.kernel.org X-Gm-Message-State: AOJu0YxqahLygjc39m3oJ+RGlnIZMN0rWBYS5zZ/Q8Qyn+ygBv2g2seG M0C7ZnG3qaOapOPOmpQFIHW2J9vHf1nUnsn/uDHkvdGsiXMndM1e/Gu5K9C4psPs6CaXTMmpG29 sYc3R5UcIH/P1i7VjwCPNjfBhWbTAn50p8ttmy8AlN+SBGW6ig7I7qf50nrKf4TqOEoc= X-Gm-Gg: Acq92OHRUi0xDlQCXzGn0qt+q/upjWbtHYig9hDck1DmFnswOUGRiYsgMVEi7cj6OE/ gD4KK+hnaATmR9h+hpaEzkCtMRQ3WVq6Fpd8wJIW7ifS80mEmvSZnZWe/V2kXh6XZj1LKHBIgJt KDkEplxh47J+x/XsAH0xaSW4kgxA6iayp3R1TndDQhK+F4/wGGe/aTVUbyeK1et5jlEoa4/W0jB uA5KA7YOzZpFxMpZ3CTch5yNs5fgg4yoTqN8f93qY+IyvbmK9gBQYOf5j2o4xS4B8JEujUV5sbp ulOOvreI5xOm/wllb5UeMj9a8Rycp5fsQV+MKF/OZz1UsTIv64CAFdgLkohllzcjHvL9cKpARpo CzIScBwytATmt87pkEwM+QwBgDjALV+TfDGf7zJuR5s7pM51/b/rThbrB X-Received: by 2002:a05:622a:40d:b0:517:6d82:9d7b with SMTP id d75a77b69052e-51795b3e4cbmr169910011cf.4.1781007505708; Tue, 09 Jun 2026 05:18:25 -0700 (PDT) X-Received: by 2002:a05:622a:40d:b0:517:6d82:9d7b with SMTP id d75a77b69052e-51795b3e4cbmr169907931cf.4.1781007502784; Tue, 09 Jun 2026 05:18:22 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf054e04a89sm1023030566b.41.2026.06.09.05.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 05:18:22 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 14:18:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-x13s: Use predefined MCLK pinctrl To: Pengyu Luo , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260607160435.36546-1-mitltlatltl@gmail.com> <20260607160435.36546-2-mitltlatltl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260607160435.36546-2-mitltlatltl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 3iDgGp9rOtjoyHaWic4UlCIKatkKa_MP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDExNiBTYWx0ZWRfXxtuhuKHmAisL q4WRW9/pPm3B/jBNcBeFQyJ07Sm2cAQFPS6V947c0U5Hh2LF+PxhuccZe18Tb39ZsJO0COdGbg1 yNWz8BHvWzNTiohfnGpm9VYZq+DrA4TWbsWEBzaSK6Jx8UPTIz1AiuC9FfCPk5U/LVGWD3oDDpZ 1CUac/HF0I8tRGFu1XW6Hgg5nHijql8uBT9mWsqyEj+N0N+PrbaER2LQBfempASPwd+at+A3qqe FKVSyz4gH1W/FhXeTxutfhpIJlzUVDFE7hDMVMgZHV8tweqqwx5S1p5JPKHQJtSEjX2NxivUu8O 20R3k6RTLgtEMDG+oOCtsxhg5tpCOekP1+nkg4IwsJo/6pjYTwalGsWPgkEHEY0wu6ihn6sJf/7 pqrcbjHj3kRZjW1tFYM27ucXVmy/jshhCSYLLlAs5WQ0W4OYw1zobimK5JowEOanAYrOgvARwt7 /VYhb6ZUhodhSDA/16w== X-Authority-Analysis: v=2.4 cv=NKPlPU6g c=1 sm=1 tr=0 ts=6a280492 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=pGLkceISAAAA:8 a=af0J6g1wBCmrdnSuRJEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 3iDgGp9rOtjoyHaWic4UlCIKatkKa_MP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090116 On 6/7/26 6:04 PM, Pengyu Luo wrote: > Now that the predefined MCLK pinctrl configuration is available in the > sc8280xp SoC DTSI, switch the ThinkPad X13s to use it. Drop the local, > duplicate MCLK pin definition from the camera pinctrl node. > > Signed-off-by: Pengyu Luo > --- > .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index abd9c5a67b9f..5d652be69e44 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -674,8 +674,9 @@ camera@10 { > reg = <0x10>; > > reset-gpios = <&tlmm 15 GPIO_ACTIVE_LOW>; > + > + pinctrl-0 = <&cam_rgb_default>, <&cam_mclk3_default>; > pinctrl-names = "default"; > - pinctrl-0 = <&cam_rgb_default>; > > leds = <&privacy_led>; > led-names = "privacy"; > @@ -1552,13 +1553,6 @@ cam_indicator_en: cam-indicator-en-state { > }; > > cam_rgb_default: cam-rgb-default-state { > - mclk-pins { > - pins = "gpio17"; > - function = "cam_mclk"; > - drive-strength = <16>; This changes the value of drive-strength (which is probably way too high, but it would be good to know what Lenovo set originally..) Konrad