mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Romain TISSERAND <romain.tisserand@gmail.com>
Cc: Igor Reznichenko <igor@reznichenko.net>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v2 1/3] dt-bindings: display: panel: ilitek,ili9488: make the port optional
Date: Tue, 10 Nov 2026 13:48:56 +0100	[thread overview]
Message-ID: <aac5e0a0-754a-4323-9417-cc17d7d42930@kernel.org> (raw)
In-Reply-To: <20261110-comical-adder-from-saturn-8c8fbb@quoll>

On 10/11/2026 13:00, Krzysztof Kozlowski wrote:
> On Mon, Nov 09, 2026 at 05:07:04PM +0100, Romain TISSERAND wrote:
>> The panel is a MIPI-DSI peripheral, a child node of its DSI host, and the
>> driver does not use a graph port. A port is only needed when the host
>> links its panel through the graph; other DSI hosts, such as the Allwinner
>> sun6i-a31-mipi-dsi one, link the child node and have no output port to
>> point at. The PinePhone panel is described that way on the same host,
>> without a port.
>>
>> Keep the port allowed (panel-common) but no longer required, as for other
>> DSI panels such as ilitek,ili9881c.
> 
> ilitek,ili7807s and a few others have the same and it is confusing. The
> port should be required when this is connected over SPI or I2C, but not
> for MIPI DSI. I think that for MIPI DSI port is meaningless so actually
> incorrect.
> 
> Why was it added in the first place?
> 

However won't all DRM drivers actually require panel? see b089c0a9b14c
and 169466d4e59c which removed fallback to the child node.

Best regards,
Krzysztof

  reply	other threads:[~2026-11-10 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 16:07 [PATCH v2 0/3] drm/panel: ilitek-ili9488: add the PocketGo S30 panel Romain TISSERAND
2026-11-09 16:07 ` [PATCH v2 1/3] dt-bindings: display: panel: ilitek,ili9488: make the port optional Romain TISSERAND
2026-11-10 12:00   ` Krzysztof Kozlowski
2026-11-10 12:48     ` Krzysztof Kozlowski [this message]
2026-11-09 16:07 ` [PATCH v2 2/3] dt-bindings: display: panel: ilitek,ili9488: add the PocketGo S30 panel Romain TISSERAND
2026-11-10 12:33   ` Krzysztof Kozlowski
2026-11-09 16:07 ` [PATCH v2 3/3] drm/panel: ilitek-ili9488: " Romain TISSERAND

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aac5e0a0-754a-4323-9417-cc17d7d42930@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=igor@reznichenko.net \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=romain.tisserand@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®