From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 759E0328B4B for ; Thu, 19 Feb 2026 10:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771496189; cv=none; b=hfuEhMLYVrd1rl+/cRkENuH09ivrnzBu9M9f4UG0ppBo+ZB15yIMU0UaaWXIakpn4bcIzuFat7xKFbTQlyBa6u8RcRm7GP9RrDq+4ODN9TPsVxar0s7RzaaDFsiPnxTRO5Woned0NZRzwV+gyl6wlmrR+2VWoqAC75jxjCCQFns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771496189; c=relaxed/simple; bh=ZlxuKUVIb1SVqc3Ha3QwyhP1WMf3XlGlPsjwG4TMhqY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MtVrZYaWUd2NMrcpO6LTdfcjon0tGA+RTghN5hhXbHQ80A31t94048ShGu46RjcxpKbenjhuKdlYFfzbE6rxTu4sWRRrmbOpDZAYYLO7rJCKedsCEMvU6Tiexe+D3hmivn+DwhIWvEsWzawzveD4l9jPRQV+rAFn9bgUH0lAtnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TaVJfH2F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Tvncm2Qb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TaVJfH2F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Tvncm2Qb" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61ILinBh1168122 for ; Thu, 19 Feb 2026 10:16:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4ENxyK49X8RDDGbPQRVRi1Jj0dBJbe2aind76FbEKxw=; b=TaVJfH2FqBTkwZUt A3ZwG58kmlehDP6WXBCx9EN8/51XeeVRVltEyobXvowsXIiG9rgEO6a9KXQ3CAhY vwBF6pHm5OnScj2Pp3WI65Pl5hGxvbHHhQkQtRqD66h4JrEDFQqB+Hh38hQlvLJw Ry+k1q5SKav29jOZ3XGNyoR4AbCaM7mbwjpEG4dm0CJ9eggEXr1tY0kgtgbFnzOd HeataRxZTFqnTV8FHouQVdlMeB7fLZFA6QzOO5UDe2IQ3ZLquvpHPOjZUcvHdrBJ P7U3o2LmfNLPlOLzcxaeqc5G+g7lpzXqMk9RKixFuhPmTlsQfx4GnrXNwd66swKg qkxALA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cd3ahcjdc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 10:16:27 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a75ed2f89dso8247795ad.1 for ; Thu, 19 Feb 2026 02:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771496187; x=1772100987; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4ENxyK49X8RDDGbPQRVRi1Jj0dBJbe2aind76FbEKxw=; b=Tvncm2QbyTWw4BjcRAHb+nuDYl0SXf23IjSGbJS+qkCjnlW0Z3hKQSTvARSRVSfPgP unDQRxPUEYluBKIbZeSn21wZ0+PAz9OVUnDJi+GscoTT8oTXdjU8o939KGX7WyxcNqDs 2WFbAB6jKT5RtvYvjFM4PswSSt2NPtZ6wN8yJfWLuklfAgasa8nPNNwL+aG5EXkcWcLc BEdmSyWVotYdJudkq9C3RqqqQcB+L8PgxwSNUr9nNmfUE6dh+GYA5ZIVAviQ5vIsr9W3 CBQcNSQcakItoGDBethGo255c6m98/p4I0rr+jj1QdTKO7NQWc/k/+NNQYuQp0TCAifL EqpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771496187; x=1772100987; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4ENxyK49X8RDDGbPQRVRi1Jj0dBJbe2aind76FbEKxw=; b=NJ/3DWMN95NnP6AlRyu/OqK0uVb2zlJU4ehiaztU0fQRGJcGxWdNlumTHsMQM1b+BL eAxBnNuMGxa3bHarL2jPJjisZWCLQNZJoBlvK346DGWcBezxZqNhICy4VGJMDnX6bOQA KWzROHbljDVvjK+iQsHUXpcALGOomjc/NLuSq7SO53XYFhDKsxSCkpb3aWX09OUnWhjq NF+7bxlvOxKoEbxXaFzy+rtqjgR83rrJzQzU2JYhWsX9ZLzFsci5X5aKnE1tEJz89wmW tHKwZZ8XdNq6bt0l0Pz/2xg7HHmXWjDmiV2wxgHabFcGMqnKONuTmrkaJlQNzOa8sdSU 9RxQ== X-Forwarded-Encrypted: i=1; AJvYcCVGetMPU6vHS3jNiy1anQ6eSRdIEWsRB08CYDYobc72pyiCkPADhgjEVixGrP+0+PnuiIN2VnqUkPRvOtM=@vger.kernel.org X-Gm-Message-State: AOJu0YxFJj6kC+h8sV5EMY+aQi415VnmJlMAFBM3DjpN+psX9AsvibJc /SarXt8VO6oDl8ujC/rJEXPh+XzZQsDnDyV5BFPhHLzwWRsP2y2dad2sBiJDhQI7Obs51ari98f cd+AXzgCOdWsYv740UYTbFU5jeBAI3lCvUepj7XWSXQnU3BCPsBpQonRFWP3zggFE92M= X-Gm-Gg: AZuq6aIHgGuN6B09fsa3hwE2P1E1O6z6OCJAed2AzF9MkHKnxXbUClZdvydLtRgDVxr BffS3jnRbcUlOm1E7FA5Ar+ksnWWgdyJtndeF1tg2j6+ZiIUTuLSCYk4kkk+HngT+7zkEqMFDiA sneTRVtjUZqlYwRuIkWjjfgm3aQkzeMOg9VTnj1gLnlUaK+pn/GG9mnfj7Nb8Gs5tqmtaxvKxik Oab41sjb0xK0NvDv9RtiqSWzy1qLNfxiDX6rdJzohqLzMgv75omZ/5ufvu+KZy2TYZc6ZWaOCuP oEEVL0pum22itqKgdGgGewPt6fA1GM1bK7mwJ3DtEmKzSxeuI71S7QJq2iOCkx+mlyYCHroJIZv yXXzSGBYLz1R+DGginIJ8lETeVTX47KLeyI9QI02iowEGZ7H2G3iNKV8= X-Received: by 2002:a17:902:f612:b0:2a9:616c:1705 with SMTP id d9443c01a7336-2ad1745d9cdmr173111485ad.22.1771496187062; Thu, 19 Feb 2026 02:16:27 -0800 (PST) X-Received: by 2002:a17:902:f612:b0:2a9:616c:1705 with SMTP id d9443c01a7336-2ad1745d9cdmr173111205ad.22.1771496186575; Thu, 19 Feb 2026 02:16:26 -0800 (PST) Received: from [10.218.18.194] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aadd47csm157600955ad.65.2026.02.19.02.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 02:16:26 -0800 (PST) Message-ID: Date: Thu, 19 Feb 2026 15:46:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Enable PCIe1 To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260212-qcm6490-idp-v1-1-80a45bd46ac5@oss.qualcomm.com> <5f62d384-cd53-4e35-87c3-67b45241b90f@oss.qualcomm.com> Content-Language: en-US From: Sushrut Shree Trivedi In-Reply-To: <5f62d384-cd53-4e35-87c3-67b45241b90f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Zo3g6t7G c=1 sm=1 tr=0 ts=6996e2fb cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=yW33yQ_1kbtctqWuQ_4A:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDA5NCBTYWx0ZWRfX0s9p1jINiJuO B3KVCbsIOu1Jf4zmWLOP19mFQIFLS1TTN6R3AZcuEOm4qRtRB+GAdkPzl5K6OKrtCD4Mrr6QE9m LCLMWzJHo7HLLvkku3Eg0a3emc2pgVeKMJhpGTfi7I17dwFKgBaFXwlBIGLsukW7MAEcAY8kJrb JoFhtCvxN1KSYRJ4ZDo3fmD5pPDQIRdiPYOsFMDOYEWs9HHSLTiQzjCqYPf/V5bLsnhPmco+2Zf vBbfugOT1Tw6CqCV14sDaTqnpvZ+op5lRQbj1pYkFomam39AuVLyg02NL1fnEEuec8ZiBz9f8Ge UaS3VKFhwxyjXMNPh/nv/Y8bBWAm737ybpEDYmFspfXkPgi0QSGvtF1oeu1pdPWyYsWRctOax3I omQs+D08tgt+L0rRlpv8rbhXB8dEf+vIPfy/nxK6eDLjK8lyLV1ZDQcJwZZhayaXzupgckwWcWZ 44LUzqeSFLoEMAu+vmg== X-Proofpoint-ORIG-GUID: TSJIVJ3ZEGFF4pZgyF46AHdG6DWzZnG3 X-Proofpoint-GUID: TSJIVJ3ZEGFF4pZgyF46AHdG6DWzZnG3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_03,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 phishscore=0 clxscore=1015 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190094 On 2/12/2026 5:49 PM, Konrad Dybcio wrote: > On 2/12/26 1:06 PM, Sushrut Shree Trivedi wrote: >> Remove PCIe1 clocks from protected-list and enable PCIe1 controller >> and its corresponding PHY nodes on qcm6490-idp platform. >> >> PCIe1 is used to connect NVMe based SSD's on this platform. > Is that a M.2 slot? What key (B/M etc.)? The NVMe is actually soldered onto the board. > > [...] > >> &pm7250b_gpios { >> lcd_disp_bias_en: lcd-disp-bias-en-state { >> pins = "gpio2"; >> @@ -920,6 +931,22 @@ &tlmm { >> gpio-reserved-ranges = <32 2>, /* ADSP */ >> <48 4>; /* NFC */ >> >> + pcie1_reset_n: pcie1-reset-n-state { >> + pins = "gpio2"; >> + function = "gpio"; >> + drive-strength = <16>; >> + output-low; > You're asserting the active state of a pin permanently this way, unless > the driver takes over, please drop this line If we de-assert the reset, it is an indication to the endpoint that it can participate in link-training with the host. Hence, until the host driver is probed and necessary resources enabled, we keep the perst asserted so endpoint doesn't try to participate in link training. > >> + bias-disable; >> + }; > Wrong indentation Ack'd. > >> + >> + pcie1_wake_n: pcie1-wake-n-state { >> + pins = "gpio3"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + > Double \n Ack'd. > >> sd_cd: sd-cd-state { >> pins = "gpio91"; >> function = "gpio"; >> >> --- >> base-commit: 4f938c7d3b25d87b356af4106c2682caf8c835a2 >> change-id: 20260212-qcm6490-idp-24f7b6a1812d >> >> Best regards,