mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeffrey E Altman <jaltman@auristor.com>
To: YueHaibing <yuehaibing@huawei.com>, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH -next] afs: remove unused variable 'afs_zero_fid'
Date: Fri, 9 Aug 2019 13:36:11 -0400	[thread overview]
Message-ID: <aac9a7c0-ff88-b43a-64cf-53abe65298e7@auristor.com> (raw)
In-Reply-To: <20190809084231.62132-1-yuehaibing@huawei.com>


[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

Confirmed.

On 8/9/2019 4:42 AM, YueHaibing wrote:
> fs/afs/fsclient.c:18:29: warning:
>  afs_zero_fid defined but not used [-Wunused-const-variable=]
> 
> It is never used since commit 025db80c9e42 ("afs: Trace
> the initiation and completion of client calls")
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/afs/fsclient.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
> index 114f281..67af068 100644
> --- a/fs/afs/fsclient.c
> +++ b/fs/afs/fsclient.c
> @@ -15,8 +15,6 @@
>  #include "xdr_fs.h"
>  #include "protocol_yfs.h"
>  
> -static const struct afs_fid afs_zero_fid;
> -
>  static inline void afs_use_fs_server(struct afs_call *call, struct afs_cb_interest *cbi)
>  {
>  	call->cbi = afs_get_cb_interest(cbi);
> 

[-- Attachment #1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]

begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4033 bytes --]

  reply	other threads:[~2019-08-09 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  8:42 YueHaibing
2019-08-09 17:36 ` Jeffrey E Altman [this message]
2019-10-23 13:54 YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aac9a7c0-ff88-b43a-64cf-53abe65298e7@auristor.com \
    --to=jaltman@auristor.com \
    --cc=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®