From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D72C433F5 for ; Mon, 1 Nov 2021 10:16:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44036610CF for ; Mon, 1 Nov 2021 10:16:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbhKAKSg (ORCPT ); Mon, 1 Nov 2021 06:18:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35056 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbhKAKSe (ORCPT ); Mon, 1 Nov 2021 06:18:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635761761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCyZG2RTX+Vqn9iHYLmuWFAS4VitdnHe0VPkeFY0Tj0=; b=Qrjz3SSRLgP6STRS4vbIkdXy+7hgQzk8GG5734IR0Pp+Kb1ME9CZL/lWnfHnBPXmWfZ2yh +K9jIQMq0eWGBOcyCW7zTe0Rbd0Akm+B1WCoEmv/P/0NDKCVeP3faVtkwbdJ9dFX54AKl2 Xju8AmtQU4P4FBQ2ubbbpfemIY1eSmg= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-noqK9DOzN-GE1FqZtucN6g-1; Mon, 01 Nov 2021 06:16:00 -0400 X-MC-Unique: noqK9DOzN-GE1FqZtucN6g-1 Received: by mail-ed1-f69.google.com with SMTP id g3-20020a056402424300b003e2981e1edbso577121edb.3 for ; Mon, 01 Nov 2021 03:15:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mCyZG2RTX+Vqn9iHYLmuWFAS4VitdnHe0VPkeFY0Tj0=; b=C2q4vhPQWpmpTMYbajFJ8gKqkxcS/E/6ie7/QEH4Upmf0ltir6lCZa0jqEhl0bRywS XtmuXjcu/5MYoCPyMi3emwyi8Z7GE0BTHqz2c9EGCyA9jeMcgMgje5xFedPFjAI+5Y0R ss2J8oc9ygWBFj7zibx7xITi6KVmR6+31bxQp/tETdjUZAGaN0cTLBy71F27L8h6UjFH 3sXT2hxyD2DChaPfmCq0FRe5OX6C/VxUKoFq1BIbgsCk/1oQ7l67tq363xLZMYMf8HJO /BsxtFm5VkeWXTU9Aqcda6lDjzQGVtz/Zf6mwr6RID0IkfjVq/3EssNhAYN5hFqt2Vzm ci2w== X-Gm-Message-State: AOAM533M7GEuk+LCHlq1g5LaUJUITPp6Z1Uwu0eyEkx1EsoiHwaXNthP 4DkNyUPARATTBGBdJu5dT4wLz+DoZz+G4256lnA3sy0upzM8HAWcQ9LSn7dlLj3eMI2p47/CMwG CLKCToXwEw5aRL8o6uaEdXvzf X-Received: by 2002:a50:da42:: with SMTP id a2mr38031213edk.361.1635761759006; Mon, 01 Nov 2021 03:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU/OUE0zeS+pOm1RbkOpVcbgGfbIMkkKuWLruKx39X7M31EAdG5zA4qvYOYAXDgy0IcBtbRg== X-Received: by 2002:a50:da42:: with SMTP id a2mr38031192edk.361.1635761758856; Mon, 01 Nov 2021 03:15:58 -0700 (PDT) Received: from [10.40.1.223] ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id o5sm2728118edc.25.2021.11.01.03.15.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 03:15:58 -0700 (PDT) Message-ID: Date: Mon, 1 Nov 2021 11:15:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 1/6] HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE() Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Masahiro Yamada , Michal Marek , Nick Desaulniers References: <20211029152901.297939-1-linux@weissschuh.net> <20211029152901.297939-2-linux@weissschuh.net> <091a4bb3-0734-4b58-9417-7ef18fcc385b@t-8ch.de> From: Hans de Goede In-Reply-To: <091a4bb3-0734-4b58-9417-7ef18fcc385b@t-8ch.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/1/21 11:09, Thomas Weißschuh wrote: > On 2021-11-01 10:58+0100, Hans de Goede wrote: >> On 10/29/21 17:28, Thomas Weißschuh wrote: >>> This allows to selectively autoload drivers for ISH devices. >>> Currently all ISH drivers are loaded for all systems having any ISH >>> device. >>> >>> Signed-off-by: Thomas Weißschuh >>> >>> --- >>> >>> Cc: linux-kbuild@vger.kernel.org >>> Cc: linux-input@vger.kernel.org >>> Cc: Srinivas Pandruvada >>> Cc: Jiri Kosina >>> Cc: Benjamin Tissoires >>> Cc: Hans de Goede >>> Cc: Masahiro Yamada >>> Cc: Michal Marek >>> Cc: Nick Desaulniers >>> --- >>> include/linux/mod_devicetable.h | 13 +++++++++++++ >>> scripts/mod/devicetable-offsets.c | 3 +++ >>> scripts/mod/file2alias.c | 24 ++++++++++++++++++++++++ >>> 3 files changed, 40 insertions(+) >>> >>> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h >>> index ae2e75d15b21..befbf53c4b7c 100644 >>> --- a/include/linux/mod_devicetable.h >>> +++ b/include/linux/mod_devicetable.h >>> @@ -895,4 +895,17 @@ struct dfl_device_id { >>> kernel_ulong_t driver_data; >>> }; >>> >>> +/* ISHTP (Integrated Sensor Hub Transport Protocol) */ >>> + >>> +#define ISHTP_MODULE_PREFIX "ishtp:" >>> + >>> +/** >>> + * struct ishtp_device_id - ISHTP device identifier >>> + * @guid_string: 36 char string of the form fa50ff2b-f2e8-45de-83fa-65417f2f49ba >>> + * @context: pointer to driver specific data >>> + */ >>> +struct ishtp_device_id { >>> + guid_t guid; >> >> The kdoc comment documents a context pointer, but this is missing from the >> actual struct. Having some sort of driver_data (1) field here would be good IMHO. > > Fine for me. > > I left it out because nothing would be using it at the moment and > it would have been easy to add when needed. IMHO having a device_id without a context/driver_data field would be weird and is likely asking for needless churn in the future, but see below. > Do you want me to send a v2 for that or would you add it when merging? > (Or remove the spurious comment) As I indicated in my reply to the cover-letter, I believe this series should be merged through the HID tree, so this is up to the HID maintainers to decide. Regards, Hans p.s. Thank you for doing this series I did not realize that the eclite driver would end up being loaded on all systems where the ISH is used, thank you for fixing this.