From: Val Packett <val@packett.cool>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine
Date: Tue, 17 Mar 2026 22:58:44 -0300 [thread overview]
Message-ID: <aacb16c4-e9ad-4455-9636-740464c3273d@packett.cool> (raw)
In-Reply-To: <qr4anmqwa5imhx2gsftggqitasqdhr4bpqimn3e74zj5csgtvy@ozbsty6o33vg>
On 3/17/26 10:03 PM, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 08:15:54PM -0300, Val Packett wrote:
>> On 3/16/26 12:23 AM, Dmitry Baryshkov wrote:
>>> On Sat, Mar 14, 2026 at 10:10:26PM -0300, Val Packett wrote:
>>>> On 3/14/26 9:51 PM, Val Packett wrote:
>>>>> On 3/13/26 10:09 PM, Dmitry Baryshkov wrote:
>>>>>> Currently, all HPD interrupt handling must go through the HPD state
>>>>>> machine.
>>>>>>
>>>>>> This has caused many issues where the DRM framework assumes that DP is
>>>>>> in one state while the state machine is stuck in another state.
>>>>>>
>>>>>> As discussed here [1], this series:
>>>>>>
>>>>>> - Removes the state machine
>>>>>> - Moves link training to atomic_enable()
>>>>>> - Changes the detect() behavior to return true if a display is
>>>>>> physically
>>>>>> plugged in (as opposed to if the DP link is ready).
>>>>>> - Remove event queue and move internal HPD handling to hpd_notify()
>>>>>>
>>>>>> To correctly detect the displays which are plugged on boot on the boards
>>>>>> which use dp-connector devices, this series depends on [2]. USB-C and
>>>>>> eDP panels are handled natively.
>>>>>>
>>>>>> [1] https://patchwork.freedesktop.org/patch/656312/?series=142010&rev=2#comment_1201738
>>>>>> [2] https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com/
>>>>> Unfortunately this currently seems to mostly break link training with
>>>>> USB-C, on x1e80100-dell-latitude-7455:
>>>>>
>>>>> [ 102.190083] [drm:msm_dp_ctrl_link_train_1_2 [msm]] *ERROR* link
>>>>> training #2 on phy 1 failed. ret=-110
>>>>> [ 102.192846] [drm:msm_dp_ctrl_setup_main_link [msm]] *ERROR* link
>>>>> training of LTTPR(s) failed. ret=-110
>>>>> [ 102.211095] [drm:msm_dp_bridge_atomic_enable [msm]] *ERROR* Failed
>>>>> link training (rc=-104)
>>>>> [ 102.211164] [drm:msm_dp_aux_isr [msm]] *ERROR* Unexpected DP AUX IRQ
>>>>> 0x01000000 when not busy
>>>>> [ 102.247168] [drm:msm_dp_ctrl_link_train_1_2 [msm]] *ERROR* link
>>>>> training #2 on phy 1 failed. ret=-110
>>>>> [ 102.252859] [drm:msm_dp_ctrl_setup_main_link [msm]] *ERROR* link
>>>>> training of LTTPR(s) failed. ret=-110
>>>>>
>>>>> [..]
>>>> Actually looks like that might've been due to having applied the [2]
>>>> dp-connector series from above.
>>> Interesting. The series only affects dp-connector. It can't affect
>>> pmic-glink usecase.
>>>
>>>> Removed it and rebooted, now plugging and unplugging multiple times between
>>>> the 2 ports works fine.
>>>>
>>>> Except unplug is still not reliable, the "ghost" monitor often remains after
>>>> unplugging.
>>> Does the patch at [3] fix the issue?
>>>
>>> [3] https://lore.kernel.org/linux-arm-msm/177362655076.7429.3868048981197120360.b4-ty@kernel.org/
>> Yes!
>>
>> Overall works better than ever now, looks like I can unplug the cable with
>> the laptop closed and then open it and it's all fine, and even play with
>> dual-role / gadget mode USB and plug the alt-mode/dock cable back in and it
>> doesn't crash.
> Tested-by?
Yeah, since I guess the link training is kinda orthogonal to this, sure!
Tested-by: Val Packett <val@packett.cool> # x1e80100-dell-latitude-7455
>> Still, rare link training failures can happen, e.g.:
> Thanks!
>
> The link training is one of the items that I want to check next.
>
next prev parent reply other threads:[~2026-03-18 1:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 1:09 Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 01/10] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-05-22 11:28 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 02/10] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-05-22 11:28 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-05-22 11:30 ` Konrad Dybcio
2026-05-22 14:38 ` Dmitry Baryshkov
2026-05-22 14:41 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 04/10] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-05-22 11:33 ` Konrad Dybcio
2026-05-24 9:51 ` Dmitry Baryshkov
2026-05-22 11:33 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 05/10] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-05-22 11:35 ` Konrad Dybcio
2026-05-22 11:35 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 06/10] drm/msm/dp: drop event data Dmitry Baryshkov
2026-05-22 11:36 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 07/10] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 08/10] drm/msm/dp: Add sink_count to debug logs Dmitry Baryshkov
2026-05-22 11:40 ` Konrad Dybcio
2026-05-24 9:57 ` Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 09/10] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-05-22 11:47 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 10/10] drm/msm/dp: clear EDID on display unplug Dmitry Baryshkov
2026-05-22 11:49 ` Konrad Dybcio
2026-05-22 12:02 ` Dmitry Baryshkov
2026-05-22 12:06 ` Konrad Dybcio
2026-03-15 0:51 ` [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine Val Packett
2026-03-15 1:10 ` Val Packett
2026-03-16 3:23 ` Dmitry Baryshkov
2026-03-17 23:15 ` Val Packett
2026-03-18 1:03 ` Dmitry Baryshkov
2026-03-18 1:58 ` Val Packett [this message]
2026-05-22 11:27 ` Konrad Dybcio
2026-05-19 6:25 ` Yongxing Mou
2026-05-20 16:14 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacb16c4-e9ad-4455-9636-740464c3273d@packett.cool \
--to=val@packett.cool \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_khsieh@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®