From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A19F33346BE for ; Sat, 27 Jun 2026 18:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782585686; cv=none; b=A8loWbgKYFtepfHw+OLfEfKhL0Dz9PuvKd8FM7grA+FP3RlsOfX8wbE73UFlzVo7HjEzEXiP+r9O256u0SME/GLolUukUnKedLvYs1dx9v1E4XP1CvDzWVT1vX1UZyvgGpNf6cAD2XmDEsoKklh9Z1sGZq+6iXat1s8rBlxedTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782585686; c=relaxed/simple; bh=8fNyIkfw/0xYqHeJkX6O72fskcyAw69K6eCvgFE0iuI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=deTA1nU0V1RVgnrLRSpv1+3rI3kwNirKsGjeFySoB3Qge4SxLQSZQlELIpAcykuijTSxaa1SZII8sm/AsIGcdzKaRpcKcsZnb4993ybSmABENGsJtyXyQBoad+UMeBb4MgV2zygmCBi6rdiiiERxbJfByowTKYcgZ+Gz9rht3p8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MmYm2D8T; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MmYm2D8T" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-491bc1d4e6bso1554076b6e.0 for ; Sat, 27 Jun 2026 11:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782585684; x=1783190484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SD3aaAda6IdwUA5LxoT3zVkkP/l61F3rjfDVOmdi7Lc=; b=MmYm2D8TUsEQJUpEcDCXHfcCKfj+taX/N6aFJbmJxt6cBEDvcC1X2FmCYHSA0i0Qgh 7l4P3CUWSs84xTzwWVtxjcjQvB3UG34o3GYV7B2klXclP8UXyxexuCJPM4pYLyLRQTpc Z+8FGFhGEEXgxReWLvc+PXW88WN1I9WXptGxWfYZizu86TRVce7JBi39MbxElq+XD/CK OcsK4W1s5P7VJ7G1G8kNCk5nnXYRIHAtXjJx/iFqeRjDrNvLsmlLMuREG7ezs6r8P6+L EEkDUF2HDc93Bl1kE5fLV980SPxzG7fG5VKI4V+68q6xI/Z00kf+9BmUJqdkSm1x8duF QMVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782585684; x=1783190484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SD3aaAda6IdwUA5LxoT3zVkkP/l61F3rjfDVOmdi7Lc=; b=XGEIcOP49q+GCt+vxJSg2lNHp7BZnXpquEaAq65cWjZ3pBBrfXfD4BUefL8UPnfsUy I6StX1CNxUnpNLIlFmZ73sjJZaGTcG4qCYZYHj8hD4NCczrPPKgGvrHqQYbTKegO5pe+ YjHeSpJfrdRiD6qRXBMppjeZ+ecuCy5Anv2dy9I/4EUv9l0HN9QGhUlwGhAhnetBigQT LEg90LZ4QXnQR2UNOm3orWXRMso1eG1vdAgrrgqw6dRDjHlrZ9QawQDsVl/f/XGx6HvE E4kSfbWUfq0aUekXTbzkJHVyRPMMVgZ/0w6r3W0FH3ih7VU3tQ3Xsk26NiBFnXdMA1xg 9slQ== X-Forwarded-Encrypted: i=1; AFNElJ/RLCQlVhRsnxW6GmhPwMSfuiFh2xP/XMB7Pl/dyXsPBAAAKMXSI6m8t2dSWWzlo6oRkAZMiakxA/5c7SE=@vger.kernel.org X-Gm-Message-State: AOJu0YyYDrgVm6gHAPHHjGF9NbUJQz2JyNioIz1SxZk+P5zgeFSF8XWb bgoJ1I7rcioqmKC04G+uH99pQcYK0vzg/Y1KKpDP7doMmzYw/CmsIWOUipPhCye9dNQ= X-Gm-Gg: AfdE7cnbnqJiE6Yq9R9XuXG3bRdAy/go7H07G0XR3KAQKoyGYuWelzcJMWFVuoJF5Q8 Sa351i6WDlxmM1OUZuc8jW1vZaQCzHDYtQDQz5ciu5R0KKZEdPGj3cbdkZtb1rSJVvl9HVoX4bb U15EDQ7zaONKEPwTzJ490/qiEvKTpqRIP7LCONVupQG2EESB6GJ53ZMwFz/MNGb2b+RoxDraPsC NFJ7PffZKKuhjaXGxu9iBma213LBI0DWsc665cQPnkE7w+2tgbL7EXxGGI5u03+u896vWlv1nEQ O18ExZkXfpEodxKXTPpaEys4/G1mDnxICjZLicyHpffq2qdgs/ry7D/XUT5D/2QQoP0ScKC7D53 m1NthuyNhCqFBpyNJ7sYTiRtNc0qV05gUuVC12tgxd7Gbyl3IGpo3km8ueZOsm5eciF0lMS6HdW gbET3Jl1D4ae09ftNjZmxoTBAVLCH3XjJNviLwmyI9Epp5NmFtbBo+DzTu6hA2GY0= X-Received: by 2002:a05:6808:6411:b0:489:97a6:a72a with SMTP id 5614622812f47-49217238baamr9016207b6e.4.1782585683662; Sat, 27 Jun 2026 11:41:23 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:f242:ecd6:f61e:d764? ([2600:8803:e7e4:500:f242:ecd6:f61e:d764]) by smtp.gmail.com with ESMTPSA id 5614622812f47-49352b05f2esm3723287b6e.7.2026.06.27.11.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jun 2026 11:41:22 -0700 (PDT) Message-ID: Date: Sat, 27 Jun 2026 13:41:22 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: iio: magnetometer: add Melexis MLX90393 To: Nikhil Gautam , linux-iio@vger.kernel.org Cc: jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, u.kleine-koenig@baylibre.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260627005843.7786-1-nikhilgtr@gmail.com> <20260627005843.7786-2-nikhilgtr@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260627005843.7786-2-nikhilgtr@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/26/26 7:58 PM, Nikhil Gautam wrote: > Add devicetree bindings for the Melexis MLX90393 > 3-axis magnetometer and temperature sensor. > > The device supports magnetic field and temperature > measurements over I2C and SPI interfaces. > > This initial binding documents the I2C interface. > > Signed-off-by: Nikhil Gautam > --- > .../iio/magnetometer/melexis,mlx90393.yaml | 54 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml > new file mode 100644 > index 000000000000..33ab0be66345 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/magnetometer/melexis,mlx90393.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Melexis MLX90393 magnetometer sensor > + > +maintainers: > + - Nikhil Gautam > + > +description: > + Melexis MLX90393 3-axis magnetometer and temperature sensor. > + > +properties: > + compatible: > + const: melexis,mlx90393 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + trigger-gpios: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - vdd-supply > + - vddio-supply The supplies are required but are missing from the properties and the example. Running `make dt_binding_check` before sending would have caught this. See: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + magnetometer@c { > + compatible = "melexis,mlx90393"; > + reg = <0x0c>; > + > + interrupt-parent = <&gpio>; > + interrupts = <17 IRQ_TYPE_EDGE_RISING>; > + > + trigger-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index a92290fffa16..469ae3f9aa0f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15501,6 +15501,12 @@ F: Documentation/scsi/megaraid.rst > F: drivers/scsi/megaraid.* > F: drivers/scsi/megaraid/ > > +MELEXIS MLX90393 MAGNETOMETER DRIVER > +M: Nikhil Gautam > +L: linux-iio@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/iio/magnetometer/melexis,mlx90393.yaml > + > MELEXIS MLX90614 DRIVER > M: Crt Mori > L: linux-iio@vger.kernel.org