From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932300AbcE0CwZ (ORCPT ); Thu, 26 May 2016 22:52:25 -0400 Received: from mail-bn1on0060.outbound.protection.outlook.com ([157.56.110.60]:6545 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932228AbcE0CwY (ORCPT ); Thu, 26 May 2016 22:52:24 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-72bff70000000ac3-b7-5747ada0c3a2 Subject: Re: [PATCH] Use the correct size to set block max sectors To: Long Li , "James E.J. Bottomley" , "Martin K. Petersen" References: <1464307708-4315-1-git-send-email-longli@microsoft.com> CC: KY Srinivasan , , From: Bart Van Assche Message-ID: Date: Thu, 26 May 2016 19:18:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464307708-4315-1-git-send-email-longli@microsoft.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsWyRoxnke6Ste7hBp132S1WTcyzeLJ6K7vF 5V1z2Cy6r+9gszh+7SCzxfLj/5gc2DweHNrM4tG64y+7x8ent1g8Pm+SC2CJ4rJJSc3JLEst 0rdL4MrYdGQmU8FRjopne++wNzC+YOti5OSQEDCROLbtAWMXIxeHkMBcJomth9ayQjg7GCXe P3rNCFN1vPcpE1QVo8Sk3YtYQBLCAk4SJ6f+AEuICHQCJToXsIMkhAScJZ69eA/WzSyQKjHp wGawfWwCRhLf3s8Ea+YVsJM4u2oHWD2LgKpE08ElYLaoQITEp99fWCFqBCVOznwCVs8p4CKx 5ewnoDkcQDPtJR5sLYMYLy+x/e0cZpAbJAS2sUosb9nCBHGDusTJJfOZJjAKz0IyahZC+ywk 7QsYmVcxiuVm5hTnpqcWGJrqFSfmpWQWZ+sl5+duYoRER+YOxrtPvA8xCnAwKvHwMji7hwux JpYVV+YeYpTgYFYS4f2/BijEm5JYWZValB9fVJqTWnyIUZqDRUmc1+3elzAhgfTEktTs1NSC 1CKYLBMHp1QDYy/Hlr3iJRleflz3bh2bYKd2yHcv27Xe8sQ7G3l3HIwI5j4e90bqmP76kFdX 5367cz364jQL/teVIgarNM6dUlEO/3miv/VNhJX2umnnDGsO2S5hZH38areIxlFr27uFaVyT +PPtdz3ue2zKGlYgtMd/p9PbDobsZvO/D65MO3LqwoNFSQ+K3yqxFGckGmoxFxUnAgB7Yj0u igIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHJMWRmVeSWpSXmKPExsXCtZEjRbdunXu4weLbGharJuZZPFm9ld3i 8q45bBbd13ewWRy/dpDZYvnxf0wObB4PDm1m8Wjd8Zfd4+PTWywenzfJBbBEcdmkpOZklqUW 6dslcGVsOjKTqeAoR8WzvXfYGxhfsHUxcnJICJhIHO99ytTFyMUhJDCbUaJn83R2kISwgJPE yak/wBIiAt2MErPmzwFLCAk4Szx78Z4RxGYWSJQ4t2g52CQ2ASOJb+9nsoDYvAJ2EmdX7QCr ZxFQlWg6uATMFhWIkPj0+wsrRI2gxMmZT8DqOQVcJLac/cQGMdNW4s7c3cwQtrzE9rdzmCcw 8s1C0jILSdksJGULGJlXMYrlZuYU56ZnFhga6RUn5qVkFmfrJefnbmIEhyhn1A7G6xPNDzEy cXBKNTAqzHe6dtzq3ZL6pPMb6pytOU+6nIw/LMV0Xux7tLbPjRdf12/qrWU4+1GO49LC6F7B 8m5F0+2xZQ9CDlR2LjT4cCs80ZlXZ93heQEph99MEJv+Wv0SQ/Zf81KVmbPuOcxvvV3I8eZ3 XKnClNObV/IGsX0I76zf5PqV9am50stPKUmJ070OT/qmxFKckWioxVxUnAgAOaRRDgECAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(189002)(199003)(9170700003)(586003)(77096005)(1220700001)(83506001)(36756003)(2270400002)(230700001)(19580405001)(19580395003)(92566002)(31696002)(50986999)(31686004)(76176999)(5001770100001)(15975445007)(54356999)(4326007)(8936002)(2950100001)(8676002)(4001350100001)(81166006)(87936001)(65806001)(2421001)(1511001)(50466002)(86362001)(47776003)(23746002)(6806005)(106466001)(11100500001)(65956001)(2906002)(64126003)(8666003)(2561002)(5008740100001)(33646002)(189998001)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR02MB517;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD037;1:5ri6PPG+CyOPVAqCi8Y3qdgZ9drv3esh4TTfIMXEO42quT69rT1l0g5TfDziVrv79m0376bimD+9moFgFrojH6THe8CsE3oCYaEaS9pJgDwU7Algr9hwSFn98wxxAuezZg3aksfqKRmV/SBh0KRJaF/rmbRdsyIKk0i0A6Gn2nr/pthiCzSEBAt7h3YSSX9x+g2j1kKA3YynLyhtAKGBo+TuG43qtVjrvKRrXDjvoGRSb1QHxFxswrE2vdwQYuZM+sotSvSn1qzplE3WFmF40uwSDEwDYayxyyr9f5EYFzycZmTp0ZKOyLHdlsNevrcJ0KyWIat8HXu6BWh0NDy3/pns9TI83E07VLnw7bRad8MRgRTAm03SnizMurpjG+pifaZ1UkW7YZS62Q2X4+68c9A6QBHtL2sq4hUtkZ9hdbmLThXrkFPz7VFyOZRA/1g1uD2EmmAhLGeI9oy7x4UdNA== X-MS-Office365-Filtering-Correlation-Id: 8f2dde50-e66a-4014-28d0-08d385d53a22 X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB517;2:laNGDqGu2dBETY4WKQ/hFlDE7KewPr+iLpPzT361nH7Fybkt5p9tjs/RIzzyl0/1RjWs2LSAFfILvYfES7hTYv8AKH9hT21DqKP4700cxfF3gdIg+JZhlwscMo1nCQ721Rm3bcUc4FOeVHmErVErUwr0Fo2rgoSP5V4rd46Yjc1uvZgeorxvOJx8IfEhO9cm;3:E7SgLKyOFMBdD1Tv2E+dbBCqF4sY6YhGTDTxnLgBXefMTr+G571M/IZGeo/DkaE52bbfbAf9tkQl66yg4k5AeOTIYrKvkLMVEOHm9E8HD+xMeud1ARlfkKQcb+0aKqS/9c2ll+G3jxmHWVP0irtD/RQUEBdyjayLTk0L4CdBB8W4LcfuY7zazAwJobnSVhRkB3IMEUNkZ8BER/z8YlIKGvnSjbnJl8GtX/adETqL2e0cZsxZPkGbGUgcPpiEuSpq/Q0WDhssMEw1QE1PC9U0Bg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BLUPR02MB517; X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB517;25:mwKVNClmfTOMRmHdvq2IRtuHxYSyDvuLFHm4NsnctIukWnkPHKx0JiYF9qawvs49F1qS76NJFRKT1SH6Rbt7VirAXBYjbrVkve015pV0+z/H9f5+RBOn6uTXef8hzIISFVweQcY0ccOv+tsqWAd/oDCxc9cL0MxGxskpQ1Wrp1TPJR4OmOfEt3M8EACwDn6JVz9Sxrlk2Mpp8D/dRBDgSElwR9LBjn0nseiinFRFwCl8QFRsy+YkJ6ZLk85PKEvA55vsOxYTsJBch4VbqniEctmSG5Eid087AbNHvOgh2p+UCJb/FsYYRs1XD4pP9oTJ2L1RIfMgUe8wQUv2Sfgzy6H0MeRck6CJj3CYlnMOoMtwo6JNs/yuN8v/MJUypMfwTe1P/XOW+UZEMKKhyveIhruvvAgLNRsa/ww4c9+16X59dJ4RYOoM5lgLRolWB0JCa856+c2Z8RNHA884xIgQv0hFpNTTP6HRW01Kww7oUyFKtVpvUxu3upVGbJ1NxpnEgP0ecCEUqAT1MNhbgFSj3jX12h7WN2X6Qss6gpoB8MTObNCwmQ0NWCm8DzyH6LJp1b1Cirh10hB6D50AcMTBAem4a1iK8ittm3xTPpZC9rVbL0j6nSr1ZJRM+VuW3Qt5LCYFFaUnbKpZnEtI87aiG4PHLFt+2VAQz1tfVnKFTkZ4mJNiwkWdIJaE+96ER33l+QXldI+P1iX4sNPbz9bzR5aSxzq71KfCtk1HdgLy87kl62Xqw5NiCuDG6yYSFU9ddEIBVG1KFC/uI+8b9l82L57WrJVCpJmRb4OdDzMYlglK1LM9RY8h0lltHpr4/sHGRXOyHexcNp7wlmJeMYHw176QxT8+v1rEcq04T7+WwMwpjTZrAMJ4Y02jer/oVT6V X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB517;20:bJnrUS61SRYcTTtc8EoCFkguTGGn81lGYCvfKkqlNdWs35k18ia1pAFC8mruSDSI6mywKJ+I6VMPq+EY3EcEG0QAc30ubPwIgCrMQfWbEozyL6k/pfzV3gyMVJCUr9hrjk7kkCMm9lrj5enAfxci51lZrO35uweIyar05ZCA6OID7PqjdgppXluMClgbnRCDZ0ZiPFnkmcwWET96WqM+0Ctn2NBOXHuvUvuBOMmeQhf5pAEias2vD8UTsLl3Hm1OMM+WIRzJTmf+Rm8z5n1iTmzoQuVvUWlIgpASIZH+lZ4DlXuQ8Qjiac+7P9oi8vy+FJLtbZuqwxFKb7tRFDHVRLkqnv7Ijqp+paqGbEkKMbSkeJdiJqGY2TOSuBQf7k0GHuZDS2p1rpTlCQJ4c4DW38zhCf/lqTh6fkwZM3zgX6kVbu/TUvogkeFVHqMGtISHhQwwJ91GG4VdglmTG7HCexB4jNicH0PqfY73B1DknQU5OOux4eESUT6NdHhH0M4H;4:ebIjeJwX7o5HcQvgeLzuoTRKabX3x3IMPKeSB9AXRTxD4aEyZsVoWX+vlIb0R5wE1jO/7DXw1fF9l+LNLtymDMp3WiQJ7IHhiyDpt0GcRe83S2kzjSxPROEw1Gq+JXWgwTWgEyUGIZDuUbNU7FLs9nPdW24LqiF84GDz+sxEXS5+foJqgZ9rUqO9c+Wz4sH2yGGyQqFt03K5KsylWRwbfgGZjr2gn9eavjHM8zUEG6l2iZKAXPEKiZ+K53St90M/qMCDU3L1do5bchyXtHAlzr2C/eV7+V0YEZ8w1fOO25B00w33Lpo8BuI1OG9vvPQXFRrBFy0Ro2rSsSPLpWbWcizJ0nhBGB15xG9NZ7nKeFGKaAvczl0crtNTnfS6geQTbagjVQk3pWODAA80cSqKUe0MbyNdFZzW6YH0Q6d4+G4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(3002001)(6055026);SRVR:BLUPR02MB517;BCL:0;PCL:0;RULEID:;SRVR:BLUPR02MB517; X-Forefront-PRVS: 09555FB1AD X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR02MB517;23:vdx9K3Vd7imzNQ8xkcoipv9edq5HowP+sHbgUa?= =?Windows-1252?Q?DxwhErWDJE6260sv/eZpGq73ObMlPlB6yVlQBBNsXlq0J8rJR9MPdAU8?= =?Windows-1252?Q?Nb5E1owzbzLiHdU39eJKusZ3hbFDJEpZdZsehOpOoaCKKe9dQgzvGkuK?= =?Windows-1252?Q?AETY3p+RoQ73aLL1F98HnWw0qUHvZR6rmDeJMaMGzqZosi3tXudzkysI?= =?Windows-1252?Q?lIrECCqOPRvs5Z7teahzsCSetQsI+JVWp4+fclgNtMP4e98xK/5TnFoI?= =?Windows-1252?Q?tC2Id3Sm4IwrG4cldP5uIZf0Wj9HvcQ4XGWm4qOeot92ktZzu7AXuprc?= =?Windows-1252?Q?M+xCguLdmeMEpWwFhAIwU+DexqBpBPyMBXtlklWNRkEZyYCt46MQYizg?= =?Windows-1252?Q?7LHQiDyxIWWN7A31SA5DrqpyFnWd31GyGS52zQRaRuCO0WrFoXUjM5LG?= =?Windows-1252?Q?uo6MYV/MhUBWlppcQMtfCFx20BRpgHj7ZjdRqNfpGa5HGJRYWlNZAL2x?= =?Windows-1252?Q?4RPm72YMNwOlZHlSbNmHUd/b/mJY/CaA9xnL2SHyDj7q45ODKMFsa+n6?= =?Windows-1252?Q?idl3WAZjI0FJ1wvK3WnaWoY9y7GDiQ2dFY8D6TNh83P5ydMJH0dCZC+t?= =?Windows-1252?Q?8NjPQnhqA7fErTYGICxIilqDNhzxiuLYLvBianeu9ZiuZvmsNLn0Qvg0?= =?Windows-1252?Q?mwAk+EWz/BJgg66g2S6o64kKmzGBfMafWXr+P3IAjd4bcDBagdHblaOa?= =?Windows-1252?Q?1gVrvvNcg0z+FJvs+xoZHlHpHQ5zeefy0J56xVw2a6NJ8qOt43cd91QD?= =?Windows-1252?Q?RbX2iRlaKNB+PMOoFR2mXaVYfwrSkDSD8luCxin8dU3MYwSj9kQRn8dj?= =?Windows-1252?Q?VMSGrKajv1SVnxatCngmnnXb5DWgLm6/vB40/LwTa9osBUvdDwt9rAE8?= =?Windows-1252?Q?M/ivpoQCSuyPBo0S8u8GRgdgbeHswtFF6d151zob8Uw5pCgeNuoqqB4F?= =?Windows-1252?Q?EbqAowgBBIa2tqVn4uthQfBN4Cm1DWx84o+nFjG5gorhQntEEWLaML4M?= =?Windows-1252?Q?9koksPM+LEntNZ9h1hSvzFbDoj9VvVCYWW+DTNlXYTCmhVsLIq0SqlBp?= =?Windows-1252?Q?cQnra1GGRkJVpgnO+ySCtfQWYxh01pFJvveOTraBnY5kyPkOBvBT0MsX?= =?Windows-1252?Q?chb/e2Kd3xWLBj+EFskZfBznGhEr8/sAamUBc0Hn0K0ZikVj1Zh4YaiU?= =?Windows-1252?Q?1Uz7rtdSFJsAadeM/kZ6TSZwYjILodOUidY8vpMv2d5sjCInLiqiUpga?= =?Windows-1252?Q?+nreG7s0oRSFp6P/5AHnQZnfwekaf4Wa+TBDux63O85Lrf3o1qupVIQm?= =?Windows-1252?Q?/bnMgia1tE?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR02MB517;5:UuzcepiWM9hQxejq2+y3wbas8X4VpnA7KImE6JNwncjRJwwfP6Pr7r2tktEYP3dSoSR49bFOXIrlB3Q04hFAJBB5remCQYecYWWFNLv6J7BwZQAq8hn3KMhiiRbvGblWDQu08eNkf3XwQfkUPNguBw==;24:RRod++ZDq0sMBmZLmltnqgyZI2aPvO+iwHANnBfxnydKd03eM6cSmBiZsBZyapEdAC5E+GUs4KXblr9NonUHB1Ue0Ey4GCUU61wtpPNPgT8=;7:DRL9Pg5b+lUtT5IqNxEWq1yK7CT++pDTV7JP35DlVBi+emugtJHUvfpAFipnGwACqKU66fjU9Z25Rw5YhTzIZg9Ykx6mSWxmixC9yQauZRpt/yvL+u1re0sVNccjvSHIULWfq3pfK1D6mTFgK0BEVg789IEd6XWeBrW4qTCloikWVNrAxmyfs8ID333oh5Xs;20:fx44Ow+154Uo/L572QmZHAeio1YwMHNelrsy/PA7TZtks525eIVqR46VtVAxDXOA1Msl0sdQZnC9OIrUlIg3PSxnnNRwCWeC7owKrjXCNjyJCVafVpFCKVGAFy6p9GR1c0I6jH3I/sce8640m+4TWw0bvKodpRdC1vRH+VF7By0LuvRyiuOHz4VRcogf0WFvUwk/1ygZcrpM9Fn/aR/Dxcto9ztF+stzFrH7kVaYdXAf9zZyjWPR7K+2gm+TSK9h SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2016 02:18:43.3133 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB517 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/16 17:08, Long Li wrote: > The block sector size should be in unit of 512 bytes, not in bytes. > > Signed-off-by: Long Li > > --- > drivers/scsi/sd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 428c03e..4bce17e 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -2862,9 +2862,11 @@ static int sd_revalidate_disk(struct gendisk *disk) > if (sdkp->opt_xfer_blocks && > sdkp->opt_xfer_blocks <= dev_max && > sdkp->opt_xfer_blocks <= SD_DEF_XFER_BLOCKS && > - sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) > - rw_max = q->limits.io_opt = > + sdkp->opt_xfer_blocks * sdp->sector_size >= PAGE_SIZE) { > + q->limits.io_opt = > sdkp->opt_xfer_blocks * sdp->sector_size; > + rw_max = (q->limits.io_opt >> 9); > + } > else > rw_max = BLK_DEF_MAX_SECTORS; Isn't this a duplicate of a patch Martin Petersen posted three weeks ago? See also http://thread.gmane.org/gmane.linux.scsi/113746. Bart.